Re: Review Request 39312: Hierarchical Allocator: Replaced Polymorphic factory with functions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39312/#review102743 --- Ship it! Ship It! - Michael Park On Oct. 14, 2015, 9:15 a.m., Joris Van Remoortere wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39312/ > --- > > (Updated Oct. 14, 2015, 9:15 a.m.) > > > Review request for mesos, Ben Mahler and Michael Park. > > > Bugs: MESOS-3554 > https://issues.apache.org/jira/browse/MESOS-3554 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/master/allocator/mesos/hierarchical.hpp > e468b5ae61e828bf0d1d670582dcf8a6c9fad5a8 > src/master/allocator/mesos/hierarchical.cpp > 0a6f8a67b9a8a0e6d17e4aa0bc3b55cf4787cf01 > > Diff: https://reviews.apache.org/r/39312/diff/ > > > Testing > --- > > make check. > > > Thanks, > > Joris Van Remoortere > >
Re: Review Request 39312: Hierarchical Allocator: Replaced Polymorphic factory with functions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39312/#review102723 --- Ship it! Ship It! - Guangya Liu On Oct. 14, 2015, 9:15 a.m., Joris Van Remoortere wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39312/ > --- > > (Updated Oct. 14, 2015, 9:15 a.m.) > > > Review request for mesos, Ben Mahler and Michael Park. > > > Bugs: MESOS-3554 > https://issues.apache.org/jira/browse/MESOS-3554 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/master/allocator/mesos/hierarchical.hpp > e468b5ae61e828bf0d1d670582dcf8a6c9fad5a8 > src/master/allocator/mesos/hierarchical.cpp > 0a6f8a67b9a8a0e6d17e4aa0bc3b55cf4787cf01 > > Diff: https://reviews.apache.org/r/39312/diff/ > > > Testing > --- > > make check. > > > Thanks, > > Joris Van Remoortere > >
Re: Review Request 39312: Hierarchical Allocator: Replaced Polymorphic factory with functions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39312/#review102680 --- Ship it! Thank you! Yes, this seems simpler to me :) - Ben Mahler On Oct. 14, 2015, 9:15 a.m., Joris Van Remoortere wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39312/ > --- > > (Updated Oct. 14, 2015, 9:15 a.m.) > > > Review request for mesos, Ben Mahler and Michael Park. > > > Bugs: MESOS-3554 > https://issues.apache.org/jira/browse/MESOS-3554 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/master/allocator/mesos/hierarchical.hpp > e468b5ae61e828bf0d1d670582dcf8a6c9fad5a8 > src/master/allocator/mesos/hierarchical.cpp > 0a6f8a67b9a8a0e6d17e4aa0bc3b55cf4787cf01 > > Diff: https://reviews.apache.org/r/39312/diff/ > > > Testing > --- > > make check. > > > Thanks, > > Joris Van Remoortere > >
Re: Review Request 39312: Hierarchical Allocator: Replaced Polymorphic factory with functions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39312/#review102600 --- Patch looks great! Reviews applied: [39312] All tests passed. - Mesos ReviewBot On Oct. 14, 2015, 9:15 a.m., Joris Van Remoortere wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39312/ > --- > > (Updated Oct. 14, 2015, 9:15 a.m.) > > > Review request for mesos, Ben Mahler and Michael Park. > > > Bugs: MESOS-3554 > https://issues.apache.org/jira/browse/MESOS-3554 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/master/allocator/mesos/hierarchical.hpp > e468b5ae61e828bf0d1d670582dcf8a6c9fad5a8 > src/master/allocator/mesos/hierarchical.cpp > 0a6f8a67b9a8a0e6d17e4aa0bc3b55cf4787cf01 > > Diff: https://reviews.apache.org/r/39312/diff/ > > > Testing > --- > > make check. > > > Thanks, > > Joris Van Remoortere > >
Review Request 39312: Hierarchical Allocator: Replaced Polymorphic factory with functions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39312/ --- Review request for mesos, Ben Mahler and Michael Park. Bugs: MESOS-3554 https://issues.apache.org/jira/browse/MESOS-3554 Repository: mesos Description --- See summary. Diffs - src/master/allocator/mesos/hierarchical.hpp e468b5ae61e828bf0d1d670582dcf8a6c9fad5a8 src/master/allocator/mesos/hierarchical.cpp 0a6f8a67b9a8a0e6d17e4aa0bc3b55cf4787cf01 Diff: https://reviews.apache.org/r/39312/diff/ Testing --- make check. Thanks, Joris Van Remoortere
