Re: Review Request 39368: Updated /state.json to show revocable resources.

2015-10-16 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39368/
---

(Updated Oct. 16, 2015, 7:33 p.m.)


Review request for mesos, Ben Mahler and Jie Yu.


Changes
---

jie's comments. also renamed the helper 'value' instead of 'model' to be more 
appropriate. NNFR.


Bugs: MESOS-3563
https://issues.apache.org/jira/browse/MESOS-3563


Repository: mesos


Description
---

Revocable resources now show up in the state.json endpoint with "_revocable" 
suffix.


Diffs (updated)
-

  src/common/http.cpp 99b843afac8bb07ef233c70117f52e64747f9502 
  src/tests/common/http_tests.cpp 8a01ffc655f9c19f776da2f99283a9ffdd7020aa 

Diff: https://reviews.apache.org/r/39368/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 39368: Updated /state.json to show revocable resources.

2015-10-16 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39368/#review102879
---


Patch looks great!

Reviews applied: [39368]

All tests passed.

- Mesos ReviewBot


On Oct. 16, 2015, 12:48 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39368/
> ---
> 
> (Updated Oct. 16, 2015, 12:48 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-3563
> https://issues.apache.org/jira/browse/MESOS-3563
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Revocable resources now show up in the state.json endpoint with "_revocable" 
> suffix.
> 
> 
> Diffs
> -
> 
>   src/common/http.cpp 99b843afac8bb07ef233c70117f52e64747f9502 
>   src/tests/common/http_tests.cpp 8a01ffc655f9c19f776da2f99283a9ffdd7020aa 
> 
> Diff: https://reviews.apache.org/r/39368/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 39368: Updated /state.json to show revocable resources.

2015-10-15 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39368/#review102861
---

Ship it!



src/common/http.cpp (line 68)


static?



src/common/http.cpp (line 101)


Not yours, but any reason need this temp variable? Can we just do:

```
foreachpair (.., .., nonRevocable.types())
```

Also, I prefer Value::Type than Value_Type



src/common/http.cpp (line 103)


s/Value_Type/Value::Type/



src/common/http.cpp (line 110)


Ditto here.



src/common/http.cpp (line 112)


s/Value_Type/Value::Type/


- Jie Yu


On Oct. 16, 2015, 12:48 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39368/
> ---
> 
> (Updated Oct. 16, 2015, 12:48 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-3563
> https://issues.apache.org/jira/browse/MESOS-3563
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Revocable resources now show up in the state.json endpoint with "_revocable" 
> suffix.
> 
> 
> Diffs
> -
> 
>   src/common/http.cpp 99b843afac8bb07ef233c70117f52e64747f9502 
>   src/tests/common/http_tests.cpp 8a01ffc655f9c19f776da2f99283a9ffdd7020aa 
> 
> Diff: https://reviews.apache.org/r/39368/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 39368: Updated /state.json to show revocable resources.

2015-10-15 Thread Jian Qiu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39368/#review102858
---

Ship it!


Ship It!

- Jian Qiu


On Oct. 16, 2015, 12:48 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39368/
> ---
> 
> (Updated Oct. 16, 2015, 12:48 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-3563
> https://issues.apache.org/jira/browse/MESOS-3563
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Revocable resources now show up in the state.json endpoint with "_revocable" 
> suffix.
> 
> 
> Diffs
> -
> 
>   src/common/http.cpp 99b843afac8bb07ef233c70117f52e64747f9502 
>   src/tests/common/http_tests.cpp 8a01ffc655f9c19f776da2f99283a9ffdd7020aa 
> 
> Diff: https://reviews.apache.org/r/39368/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Review Request 39368: Updated /state.json to show revocable resources.

2015-10-15 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39368/
---

Review request for mesos, Ben Mahler and Jie Yu.


Bugs: MESOS-3563
https://issues.apache.org/jira/browse/MESOS-3563


Repository: mesos


Description
---

Revocable resources now show up in the state.json endpoint with "_revocable" 
suffix.


Diffs
-

  src/common/http.cpp 99b843afac8bb07ef233c70117f52e64747f9502 
  src/tests/common/http_tests.cpp 8a01ffc655f9c19f776da2f99283a9ffdd7020aa 

Diff: https://reviews.apache.org/r/39368/diff/


Testing
---

make check


Thanks,

Vinod Kone