Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-20 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39382/#review103283
---

Ship it!


I added a patch before this similar to the other "prepare..." patches to make 
sure mesos still compiles.


3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp (line 17)


`string`
`stdio.h`
`stout/error.hpp`


- Joris Van Remoortere


On Oct. 20, 2015, 7:20 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39382/
> ---
> 
> (Updated Oct. 20, 2015, 7:20 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> e64aa6baeab9d816bb42242e3c9234d4da80f401 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 1c776cd2facfb86854c7b2a8fe6be7949b566587 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> f16ef1998c9b271b35063a2f07cf1c15d6b8bea0 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> eaeed7393b1c44f04737e18cd90a6fc292aa061d 
> 
> Diff: https://reviews.apache.org/r/39382/diff/
> 
> 
> Testing
> ---
> 
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
> on Windows 10.
> 
> Autotools `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-20 Thread Alex Clemmer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39382/
---

(Updated Oct. 20, 2015, 7:20 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
e64aa6baeab9d816bb42242e3c9234d4da80f401 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
1c776cd2facfb86854c7b2a8fe6be7949b566587 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
f16ef1998c9b271b35063a2f07cf1c15d6b8bea0 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
eaeed7393b1c44f04737e18cd90a6fc292aa061d 

Diff: https://reviews.apache.org/r/39382/diff/


Testing
---

CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
on Windows 10.

Autotools `make check` on Ubuntu 15.


Thanks,

Alex Clemmer



Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-19 Thread Alex Clemmer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39382/
---

(Updated Oct. 19, 2015, 11:27 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
e64aa6baeab9d816bb42242e3c9234d4da80f401 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
1c776cd2facfb86854c7b2a8fe6be7949b566587 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
f16ef1998c9b271b35063a2f07cf1c15d6b8bea0 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
eaeed7393b1c44f04737e18cd90a6fc292aa061d 

Diff: https://reviews.apache.org/r/39382/diff/


Testing
---

CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
on Windows 10.

Autotools `make check` on Ubuntu 15.


Thanks,

Alex Clemmer



Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-17 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39382/#review103024
---


Bad patch!

Reviews applied: [39076, 39091, 39092, 39093, 39096, 39097, 39180]

Failed command: ./support/apply-review.sh -n -r 39180

Error:
 2015-10-17 19:10:49 URL:https://reviews.apache.org/r/39180/diff/raw/ 
[16738/16738] -> "39180.patch" [1]
error: patch failed: src/tests/scheduler_http_api_tests.cpp:295
error: src/tests/scheduler_http_api_tests.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Oct. 17, 2015, 6:54 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39382/
> ---
> 
> (Updated Oct. 17, 2015, 6:54 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 5141c1369af60afd6cd5c70c6295d575ea960a83 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> a042d061159c83e1652e7288b90809981d2818c9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> 2b0966889af73238a08e29f1136d0ce286a0ffda 
> 
> Diff: https://reviews.apache.org/r/39382/diff/
> 
> 
> Testing
> ---
> 
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
> on Windows 10.
> 
> Autotools `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-17 Thread Alex Clemmer


> On Oct. 16, 2015, 9:19 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [39076, 39091, 39092, 39093, 39096, 39097, 39180]
> > 
> > Failed command: ./support/apply-review.sh -n -r 39180
> > 
> > Error:
> >  2015-10-16 21:19:05 URL:https://reviews.apache.org/r/39180/diff/raw/ 
> > [16738/16738] -> "39180.patch" [1]
> > error: patch failed: src/tests/scheduler_http_api_tests.cpp:295
> > error: src/tests/scheduler_http_api_tests.cpp: patch does not apply
> > Failed to apply patch

Looks like someone pushed to master after I rebased. Sorry!


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39382/#review102993
---


On Oct. 16, 2015, 7:50 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39382/
> ---
> 
> (Updated Oct. 16, 2015, 7:50 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 5141c1369af60afd6cd5c70c6295d575ea960a83 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> a042d061159c83e1652e7288b90809981d2818c9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> 2b0966889af73238a08e29f1136d0ce286a0ffda 
> 
> Diff: https://reviews.apache.org/r/39382/diff/
> 
> 
> Testing
> ---
> 
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
> on Windows 10.
> 
> Autotools `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-17 Thread Alex Clemmer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39382/
---

(Updated Oct. 17, 2015, 6:54 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
5141c1369af60afd6cd5c70c6295d575ea960a83 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
a042d061159c83e1652e7288b90809981d2818c9 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
2b0966889af73238a08e29f1136d0ce286a0ffda 

Diff: https://reviews.apache.org/r/39382/diff/


Testing
---

CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
on Windows 10.

Autotools `make check` on Ubuntu 15.


Thanks,

Alex Clemmer



Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-16 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39382/#review102993
---


Bad patch!

Reviews applied: [39076, 39091, 39092, 39093, 39096, 39097, 39180]

Failed command: ./support/apply-review.sh -n -r 39180

Error:
 2015-10-16 21:19:05 URL:https://reviews.apache.org/r/39180/diff/raw/ 
[16738/16738] -> "39180.patch" [1]
error: patch failed: src/tests/scheduler_http_api_tests.cpp:295
error: src/tests/scheduler_http_api_tests.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Oct. 16, 2015, 7:50 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39382/
> ---
> 
> (Updated Oct. 16, 2015, 7:50 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 5141c1369af60afd6cd5c70c6295d575ea960a83 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> a042d061159c83e1652e7288b90809981d2818c9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> 2b0966889af73238a08e29f1136d0ce286a0ffda 
> 
> Diff: https://reviews.apache.org/r/39382/diff/
> 
> 
> Testing
> ---
> 
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
> on Windows 10.
> 
> Autotools `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-16 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39382/#review102980
---

Ship it!


Ship It!

- Joseph Wu


On Oct. 16, 2015, 12:50 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39382/
> ---
> 
> (Updated Oct. 16, 2015, 12:50 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 5141c1369af60afd6cd5c70c6295d575ea960a83 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> a042d061159c83e1652e7288b90809981d2818c9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> 2b0966889af73238a08e29f1136d0ce286a0ffda 
> 
> Diff: https://reviews.apache.org/r/39382/diff/
> 
> 
> Testing
> ---
> 
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
> on Windows 10.
> 
> Autotools `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-16 Thread Alex Clemmer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39382/
---

(Updated Oct. 16, 2015, 7:50 p.m.)


Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
5141c1369af60afd6cd5c70c6295d575ea960a83 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
a042d061159c83e1652e7288b90809981d2818c9 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
2b0966889af73238a08e29f1136d0ce286a0ffda 

Diff: https://reviews.apache.org/r/39382/diff/


Testing
---

CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
on Windows 10.

Autotools `make check` on Ubuntu 15.


Thanks,

Alex Clemmer



Re: Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-16 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39382/#review102881
---


Bad patch!

Reviews applied: [39076, 39091, 39092, 39093, 39096, 39097, 39180]

Failed command: ./support/apply-review.sh -n -r 39180

Error:
 2015-10-16 07:30:23 URL:https://reviews.apache.org/r/39180/diff/raw/ 
[16738/16738] -> "39180.patch" [1]
error: patch failed: src/tests/scheduler_http_api_tests.cpp:295
error: src/tests/scheduler_http_api_tests.cpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Oct. 16, 2015, 4:34 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39382/
> ---
> 
> (Updated Oct. 16, 2015, 4:34 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
> Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 5141c1369af60afd6cd5c70c6295d575ea960a83 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> a042d061159c83e1652e7288b90809981d2818c9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> 2b0966889af73238a08e29f1136d0ce286a0ffda 
> 
> Diff: https://reviews.apache.org/r/39382/diff/
> 
> 
> Testing
> ---
> 
> CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
> on Windows 10.
> 
> Autotools `make check` on Ubuntu 15.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Review Request 39382: Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.

2015-10-15 Thread Alex Clemmer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39382/
---

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Windows: Moved `os::rm` to its own file, `stout/os/rm.hpp`.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
9e9c3119ad18f4cbc70c70095c71dc4fd19553df 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
5141c1369af60afd6cd5c70c6295d575ea960a83 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/rm.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
a042d061159c83e1652e7288b90809981d2818c9 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
2b0966889af73238a08e29f1136d0ce286a0ffda 

Diff: https://reviews.apache.org/r/39382/diff/


Testing
---

CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 
on Windows 10.

Autotools `make check` on Ubuntu 15.


Thanks,

Alex Clemmer