Re: Review Request 39384: Added docs for how developers should split their work into Git commits.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39384/#review103015 --- Ship it! Ship It! - Guangya Liu On 十月 16, 2015, 9:25 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39384/ > --- > > (Updated 十月 16, 2015, 9:25 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > --- > > Added docs for how developers should split their work into Git commits. > > > Diffs > - > > docs/submitting-a-patch.md cbd99fe3fd16270316596700e3fc292243a9 > > Diff: https://reviews.apache.org/r/39384/diff/ > > > Testing > --- > > > Thanks, > > Neil Conway > >
Re: Review Request 39384: Added docs for how developers should split their work into Git commits.
> On Oct. 16, 2015, 6:21 p.m., Ben Mahler wrote: > > Thanks Neil! It looks like we have overlap between this and the effective > > code review doc here: > > http://mesos.apache.org/documentation/latest/effective-code-reviewing/ > > > > Should we just link to this from the submitting a patch doc? Anything you > > think should be added / changed in the code review doc? Ah, I hadn't seen that -- I think overlap isn't the end of the world, and a lot of new contributors won't read the code-reviewing page. How about both adding some text to submitting-a-patch and also including a link to the code-reviewing page? - Neil --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39384/#review102955 --- On Oct. 16, 2015, 4:41 a.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39384/ > --- > > (Updated Oct. 16, 2015, 4:41 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > --- > > Added docs for how developers should split their work into Git commits. > > > Diffs > - > > docs/submitting-a-patch.md cbd99fe3fd16270316596700e3fc292243a9 > > Diff: https://reviews.apache.org/r/39384/diff/ > > > Testing > --- > > > Thanks, > > Neil Conway > >
Re: Review Request 39384: Added docs for how developers should split their work into Git commits.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39384/#review102930 --- Ship it! Ship It! - Joseph Wu On Oct. 15, 2015, 9:41 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39384/ > --- > > (Updated Oct. 15, 2015, 9:41 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > --- > > Added docs for how developers should split their work into Git commits. > > > Diffs > - > > docs/submitting-a-patch.md cbd99fe3fd16270316596700e3fc292243a9 > > Diff: https://reviews.apache.org/r/39384/diff/ > > > Testing > --- > > > Thanks, > > Neil Conway > >
Re: Review Request 39384: Added docs for how developers should split their work into Git commits.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39384/#review102994 --- Ship it! Ship It! - Anand Mazumdar On Oct. 16, 2015, 9:25 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39384/ > --- > > (Updated Oct. 16, 2015, 9:25 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > --- > > Added docs for how developers should split their work into Git commits. > > > Diffs > - > > docs/submitting-a-patch.md cbd99fe3fd16270316596700e3fc292243a9 > > Diff: https://reviews.apache.org/r/39384/diff/ > > > Testing > --- > > > Thanks, > > Neil Conway > >
Re: Review Request 39384: Added docs for how developers should split their work into Git commits.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39384/ --- (Updated Oct. 16, 2015, 9:23 p.m.) Review request for mesos and Ben Mahler. Changes --- Add link to review guidelines. Repository: mesos Description --- Added docs for how developers should split their work into Git commits. Diffs (updated) - docs/submitting-a-patch.md cbd99fe3fd16270316596700e3fc292243a9 include/mesos/scheduler/scheduler.proto 417cfe6a9bca418b0ef77cb2268fafeb07867819 include/mesos/v1/scheduler/scheduler.proto 4f6cf5b0da1b89f6cd501c5f917253d428711efa src/common/http.cpp f56d8a178e1f61d91adfeaad32b47718adbc4379 src/tests/common/http_tests.cpp c2e7704f342c2ac98dc5a7bad2f5803b54016b92 Diff: https://reviews.apache.org/r/39384/diff/ Testing --- Thanks, Neil Conway
Re: Review Request 39384: Added docs for how developers should split their work into Git commits.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39384/ --- (Updated Oct. 16, 2015, 9:25 p.m.) Review request for mesos and Ben Mahler. Changes --- Rebase. Repository: mesos Description --- Added docs for how developers should split their work into Git commits. Diffs (updated) - docs/submitting-a-patch.md cbd99fe3fd16270316596700e3fc292243a9 Diff: https://reviews.apache.org/r/39384/diff/ Testing --- Thanks, Neil Conway
Re: Review Request 39384: Added docs for how developers should split their work into Git commits.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39384/#review102885 --- Patch looks great! Reviews applied: [39384] All tests passed. - Mesos ReviewBot On Oct. 16, 2015, 4:41 a.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39384/ > --- > > (Updated Oct. 16, 2015, 4:41 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > --- > > Added docs for how developers should split their work into Git commits. > > > Diffs > - > > docs/submitting-a-patch.md cbd99fe3fd16270316596700e3fc292243a9 > > Diff: https://reviews.apache.org/r/39384/diff/ > > > Testing > --- > > > Thanks, > > Neil Conway > >
Re: Review Request 39384: Added docs for how developers should split their work into Git commits.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39384/#review102893 --- Ship it! Ship It! - Alexander Rukletsov On Oct. 16, 2015, 4:41 a.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39384/ > --- > > (Updated Oct. 16, 2015, 4:41 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > --- > > Added docs for how developers should split their work into Git commits. > > > Diffs > - > > docs/submitting-a-patch.md cbd99fe3fd16270316596700e3fc292243a9 > > Diff: https://reviews.apache.org/r/39384/diff/ > > > Testing > --- > > > Thanks, > > Neil Conway > >
Re: Review Request 39384: Added docs for how developers should split their work into Git commits.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39384/#review103001 --- Patch looks great! Reviews applied: [39384] All tests passed. - Mesos ReviewBot On Oct. 16, 2015, 9:25 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39384/ > --- > > (Updated Oct. 16, 2015, 9:25 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > --- > > Added docs for how developers should split their work into Git commits. > > > Diffs > - > > docs/submitting-a-patch.md cbd99fe3fd16270316596700e3fc292243a9 > > Diff: https://reviews.apache.org/r/39384/diff/ > > > Testing > --- > > > Thanks, > > Neil Conway > >
Re: Review Request 39384: Added docs for how developers should split their work into Git commits.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39384/#review102955 --- Thanks Neil! It looks like we have overlap between this and the effective code review doc here: http://mesos.apache.org/documentation/latest/effective-code-reviewing/ Should we just link to this from the submitting a patch doc? Anything you think should be added / changed in the code review doc? - Ben Mahler On Oct. 16, 2015, 4:41 a.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39384/ > --- > > (Updated Oct. 16, 2015, 4:41 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > --- > > Added docs for how developers should split their work into Git commits. > > > Diffs > - > > docs/submitting-a-patch.md cbd99fe3fd16270316596700e3fc292243a9 > > Diff: https://reviews.apache.org/r/39384/diff/ > > > Testing > --- > > > Thanks, > > Neil Conway > >
