Re: Review Request 39423: Fixed `ExamplesTest.PersistentVolumeFramework` on OS X El Capitan.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39423/#review103143 --- Ship it! Ship It! - Jie Yu On Oct. 19, 2015, 2:39 a.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39423/ > --- > > (Updated Oct. 19, 2015, 2:39 a.m.) > > > Review request for mesos, Jie Yu and Till Toenshoff. > > > Bugs: MESOS-3604 > https://issues.apache.org/jira/browse/MESOS-3604 > > > Repository: mesos > > > Description > --- > > The `MESOS_LAUNCHER_DIR` was being set to `/src/.libs` rather than > `/src`. This leads to us attemping to execute > `/src/.libs/mesos-executor` which doesn't have the correct > `DYLD_LIBRARY_PATH` set. > > > Diffs > - > > src/examples/persistent_volume_framework.cpp > 426d33813f8f17397c6ed29b8a8b33df4137bba6 > > Diff: https://reviews.apache.org/r/39423/diff/ > > > Testing > --- > > ``` > [==] Running 1 test from 1 test case. > [--] Global test environment set-up. > [--] 1 test from ExamplesTest > [ RUN ] ExamplesTest.PersistentVolumeFramework > [ OK ] ExamplesTest.PersistentVolumeFramework (3391 ms) > [--] 1 test from ExamplesTest (3391 ms total) > > [--] Global test environment tear-down > [==] 1 test from 1 test case ran. (3403 ms total) > [ PASSED ] 1 test. > ``` > > > Thanks, > > Michael Park > >
Re: Review Request 39423: Fixed `ExamplesTest.PersistentVolumeFramework` on OS X El Capitan.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39423/#review103072 --- Patch looks great! Reviews applied: [39423] All tests passed. - Mesos ReviewBot On Oct. 18, 2015, 7:35 p.m., Michael Park wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39423/ > --- > > (Updated Oct. 18, 2015, 7:35 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-3604 > https://issues.apache.org/jira/browse/MESOS-3604 > > > Repository: mesos > > > Description > --- > > The `MESOS_LAUNCHER_DIR` was being set to `/src/.libs` rather than > `/src`. This leads to us attemping to execute > `/src/.libs/mesos-executor` which doesn't have the correct > `DYLD_LIBRARY_PATH` set. > > > Diffs > - > > src/examples/persistent_volume_framework.cpp > 426d33813f8f17397c6ed29b8a8b33df4137bba6 > > Diff: https://reviews.apache.org/r/39423/diff/ > > > Testing > --- > > ``` > [==] Running 1 test from 1 test case. > [--] Global test environment set-up. > [--] 1 test from ExamplesTest > [ RUN ] ExamplesTest.PersistentVolumeFramework > [ OK ] ExamplesTest.PersistentVolumeFramework (3391 ms) > [--] 1 test from ExamplesTest (3391 ms total) > > [--] Global test environment tear-down > [==] 1 test from 1 test case ran. (3403 ms total) > [ PASSED ] 1 test. > ``` > > > Thanks, > > Michael Park > >
Review Request 39423: Fixed `ExamplesTest.PersistentVolumeFramework` on OS X El Capitan.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39423/ --- Review request for mesos and Jie Yu. Bugs: MESOS-3604 https://issues.apache.org/jira/browse/MESOS-3604 Repository: mesos Description --- The `MESOS_LAUNCHER_DIR` was being set to `/src/.libs` rather than `/src`. This leads to us attemping to execute `/src/.libs/mesos-executor` which doesn't have the correct `DYLD_LIBRARY_PATH` set. Diffs - src/examples/persistent_volume_framework.cpp 426d33813f8f17397c6ed29b8a8b33df4137bba6 Diff: https://reviews.apache.org/r/39423/diff/ Testing --- ``` [==] Running 1 test from 1 test case. [--] Global test environment set-up. [--] 1 test from ExamplesTest [ RUN ] ExamplesTest.PersistentVolumeFramework [ OK ] ExamplesTest.PersistentVolumeFramework (3391 ms) [--] 1 test from ExamplesTest (3391 ms total) [--] Global test environment tear-down [==] 1 test from 1 test case ran. (3403 ms total) [ PASSED ] 1 test. ``` Thanks, Michael Park
