Re: Review Request 39451: Fix double dashes typo, highlighting, bullet points

2015-10-19 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39451/
---

(Updated Oct. 19, 2015, 3:29 p.m.)


Review request for mesos and Michael Park.


Repository: mesos


Description
---

Fix double dashes typo, highlighting, bullet points


Diffs (updated)
-

  docs/containerizer.md ea195585750bc243cf670287e2e76000bf5fe3cb 
  docs/docker-containerizer.md 091a3ace48aca3b34ba5159f5146237d0bc7611c 

Diff: https://reviews.apache.org/r/39451/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 39451: Fix double dashes typo, highlighting, bullet points

2015-10-19 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39451/#review103177
---


Patch looks great!

Reviews applied: [39451]

All tests passed.

- Mesos ReviewBot


On Oct. 19, 2015, 8:48 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39451/
> ---
> 
> (Updated Oct. 19, 2015, 8:48 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix double dashes typo, highlighting, bullet points
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md ea195585750bc243cf670287e2e76000bf5fe3cb 
>   docs/docker-containerizer.md 091a3ace48aca3b34ba5159f5146237d0bc7611c 
> 
> Diff: https://reviews.apache.org/r/39451/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 39451: Fix double dashes typo, highlighting, bullet points

2015-10-19 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39451/#review103176
---



docs/docker-containerizer.md (lines 22 - 23)


According to 
http://mesos.apache.org/documentation/latest/markdown-style-guide/, I think we 
should still wrap the command in ```.



docs/docker-containerizer.md (line 63)


Another instance of `.dockercfg` to be wrapped in ```?



docs/docker-containerizer.md (line 79)


`s/docker_mesos_image/--docker_mesos_image/`?


- Michael Park


On Oct. 19, 2015, 8:48 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39451/
> ---
> 
> (Updated Oct. 19, 2015, 8:48 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix double dashes typo, highlighting, bullet points
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md ea195585750bc243cf670287e2e76000bf5fe3cb 
>   docs/docker-containerizer.md 091a3ace48aca3b34ba5159f5146237d0bc7611c 
> 
> Diff: https://reviews.apache.org/r/39451/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 39451: Fix double dashes typo, highlighting, bullet points

2015-10-19 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39451/
---

(Updated Oct. 19, 2015, 1:48 p.m.)


Review request for mesos and Michael Park.


Repository: mesos


Description
---

Fix double dashes typo, highlighting, bullet points


Diffs (updated)
-

  docs/containerizer.md ea195585750bc243cf670287e2e76000bf5fe3cb 
  docs/docker-containerizer.md 091a3ace48aca3b34ba5159f5146237d0bc7611c 

Diff: https://reviews.apache.org/r/39451/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 39451: Fix double dashes typo, highlighting, bullet points

2015-10-19 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39451/
---

(Updated Oct. 19, 2015, 1:26 p.m.)


Review request for mesos and Michael Park.


Repository: mesos


Description
---

Fix double dashes typo, highlighting, bullet points


Diffs (updated)
-

  docs/containerizer.md ea195585750bc243cf670287e2e76000bf5fe3cb 
  docs/docker-containerizer.md 091a3ace48aca3b34ba5159f5146237d0bc7611c 

Diff: https://reviews.apache.org/r/39451/diff/


Testing
---

make check


Thanks,

Gilbert Song

Re: Review Request 39451: Fix double dashes typo, highlighting, bullet points

2015-10-19 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39451/#review103149
---



docs/containerizer.md (line 37)


Based on the description above, it seems like `host_path="tmp"` is actually 
correct?


- Michael Park


On Oct. 19, 2015, 7:49 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39451/
> ---
> 
> (Updated Oct. 19, 2015, 7:49 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix double dashes typo, highlighting, bullet points
> 
> 
> Diffs
> -
> 
>   docs/containerizer.md ea195585750bc243cf670287e2e76000bf5fe3cb 
>   docs/docker-containerizer.md 091a3ace48aca3b34ba5159f5146237d0bc7611c 
> 
> Diff: https://reviews.apache.org/r/39451/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 39451: Fix double dashes typo, highlighting, bullet points

2015-10-19 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39451/
---

(Updated Oct. 19, 2015, 12:49 p.m.)


Review request for mesos and Michael Park.


Repository: mesos


Description (updated)
---

Fix double dashes typo, highlighting, bullet points


Diffs
-

  docs/containerizer.md ea195585750bc243cf670287e2e76000bf5fe3cb 
  docs/docker-containerizer.md 091a3ace48aca3b34ba5159f5146237d0bc7611c 

Diff: https://reviews.apache.org/r/39451/diff/


Testing
---

make check


Thanks,

Gilbert Song

Review Request 39451: Fix double dashes typo, highlighting, bullet points

2015-10-19 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39451/
---

Review request for mesos and Michael Park.


Repository: mesos


Description
---

Fix double dashes type, highlighting, bullet points


Diffs
-

  docs/containerizer.md ea195585750bc243cf670287e2e76000bf5fe3cb 
  docs/docker-containerizer.md 091a3ace48aca3b34ba5159f5146237d0bc7611c 

Diff: https://reviews.apache.org/r/39451/diff/


Testing
---

make check


Thanks,

Gilbert Song