Re: Review Request 39456: Documentation: added containerizer internals

2015-12-16 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39456/ --- (Updated Dec. 16, 2015, 9:48 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 39456: Documentation: added containerizer internals

2015-12-16 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39456/#review110764 --- Ship it! docs/containerizer-internals.md (lines 54 - 55)

Re: Review Request 39456: Documentation: added containerizer internals

2015-12-15 Thread Jojy Varghese
> On Dec. 15, 2015, 12:35 a.m., Guangya Liu wrote: > > docs/containerizer-internals.md, lines 15-23 > > > > > > What about moveing this after ### Type of containerizers > > Jojy Varghese wrote: > Since this

Re: Review Request 39456: Documentation: added containerizer internals

2015-12-15 Thread Jojy Varghese
> On Dec. 15, 2015, 12:35 a.m., Guangya Liu wrote: > > docs/containerizer-internals.md, lines 6-10 > > > > > > Does this still needed? As this was already mentioned in > >

Re: Review Request 39456: Documentation: added containerizer internals

2015-12-15 Thread Jojy Varghese
> On Dec. 15, 2015, 12:35 a.m., Guangya Liu wrote: > > docs/containerizer-internals.md, lines 6-10 > > > > > > Does this still needed? As this was already mentioned in > >

Re: Review Request 39456: Documentation: added containerizer internals

2015-12-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39456/#review110581 --- docs/containerizer-internals.md (lines 39 - 43)

Re: Review Request 39456: Documentation: added containerizer internals

2015-12-14 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39456/#review110340 --- docs/containerizer-internals.md (lines 6 - 10)

Re: Review Request 39456: Documentation: added containerizer internals

2015-12-14 Thread Jojy Varghese
> On Dec. 15, 2015, 12:35 a.m., Guangya Liu wrote: > > docs/containerizer-internals.md, lines 15-23 > > > > > > What about moveing this after ### Type of containerizers Since this section is common to all

Re: Review Request 39456: Documentation: added containerizer internals

2015-12-14 Thread Guangya Liu
> On Dec. 15, 2015, 12:35 a.m., Guangya Liu wrote: > > docs/containerizer-internals.md, lines 21-23 > > > > > > Just a kind reminder, https://issues.apache.org/jira/browse/MESOS-1718 > > is planning to move get

Re: Review Request 39456: Documentation: added containerizer internals

2015-12-14 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39456/ --- (Updated Dec. 14, 2015, 8:37 p.m.) Review request for mesos, Jie Yu and

Re: Review Request 39456: Documentation: added containerizer internals

2015-11-30 Thread Jojy Varghese
> On Nov. 21, 2015, 2:19 a.m., Timothy Chen wrote: > > Are you still working on this? This doesn't look complete to me? Thanks for taking a look Tim.Since the area is too big to document all in one go, do you have any particular topics you would like to be in the first iteration? - Jojy

Re: Review Request 39456: Documentation: added containerizer internals

2015-11-20 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39456/#review107467 --- Are you still working on this? This doesn't look complete to me?

Re: Review Request 39456: Documentation: added containerizer internals

2015-10-21 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39456/ --- (Updated Oct. 21, 2015, 9:25 p.m.) Review request for mesos, Connor Doyle and

Re: Review Request 39456: Documentation: added containerizer internals

2015-10-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39456/#review103492 --- Patch looks great! Reviews applied: [39456] All tests passed. -

Review Request 39456: Documentation: added containerizer internals

2015-10-19 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39456/ --- Review request for mesos and Timothy Chen. Repository: mesos Description

Re: Review Request 39456: Documentation: added containerizer internals

2015-10-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39456/#review103197 --- Patch looks great! Reviews applied: [39456] All tests passed. -