Re: Review Request 39497: Fixed quotation of interpolated variables in log messages.

2015-11-10 Thread Joris Van Remoortere
> On Oct. 20, 2015, 10:35 p.m., Greg Mann wrote: > > The executor id now has a stream operator that takes care of this formatting. - Joris --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 39497: Fixed quotation of interpolated variables in log messages.

2015-10-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39497/#review104101 --- Ship it! minus the removal of taskid quotations. - Joris Van

Re: Review Request 39497: Fixed quotation of interpolated variables in log messages.

2015-10-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39497/#review103437 --- Ship it! Ship It! - Greg Mann On Oct. 21, 2015, 2:37 a.m.,

Re: Review Request 39497: Fixed quotation of interpolated variables in log messages.

2015-10-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39497/#review103366 --- Patch looks great! Reviews applied: [39497] All tests passed. -

Re: Review Request 39497: Fixed quotation of interpolated variables in log messages.

2015-10-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39497/#review103320 --- src/slave/slave.cpp (line 1938)

Review Request 39497: Fixed quotation of interpolated variables in log messages.

2015-10-20 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39497/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-3772