Re: Review Request 39590: Made license-headers doxygen-compatible.

2015-11-23 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39590/
---

(Updated Nov. 23, 2015, 1:05 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd 
Mathiske, and Till Toenshoff.


Changes
---

Rebased.


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description
---

This commit adjusts license headers of C++ source and header files, and 
protobuf definitions.

Also, reflect the changed style in the C++ style guide.


Diffs (updated)
-

  docs/c++-style-guide.md 678faebc548fa3a7ad60f72075d36b24af5ee744 
  include/mesos/attributes.hpp 78afcd51b22a9eeb741076a8affeb8f2ae4bdee3 
  include/mesos/authentication/authenticatee.hpp 
17fb7aa0f4d8a43f9cee0aab305af05f4fa7888f 
  include/mesos/authentication/authentication.hpp 
699aa886286bc7d9c05592e71232ab1c1084871f 
  include/mesos/authentication/authentication.proto 
a7db56d643aa01ca2e3cd3e4268bd75b54136727 
  include/mesos/authentication/authenticator.hpp 
aa3818c31fee3b2e7c17d80dcceb8d41a38bbd06 
  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  include/mesos/authorizer/authorizer.proto 
86bbb45f9d91b4098a262e3e50a793f3bb39497e 
  include/mesos/containerizer/containerizer.hpp 
9bf76e066f390c36392c469b3d2cd92e2d10f3c7 
  include/mesos/containerizer/containerizer.proto 
7cf6d2bb8c6636cbb3ea8c44fb45a41b93c8603d 
  include/mesos/executor.hpp 72eca97dd84fb1300b37764a3ef3a57fb5e676c2 
  include/mesos/executor/executor.hpp 85f181c72cdb5e80d6c549a4d663d9bad261693a 
  include/mesos/executor/executor.proto 
a9243c7a10c32f104c12cbce835bc23a7c75a275 
  include/mesos/fetcher/fetcher.hpp b7e6a717ed329d7f2586607cfe90342a96ae14a8 
  include/mesos/fetcher/fetcher.proto 1b2f4936d8dcd2b5e6d3ca2c85b3fa9df74a5797 
  include/mesos/hook.hpp 6d7fee85566cf6c057296b5f4a9c14c9fab31085 
  include/mesos/http.hpp 8b9b748fee5b2a8cc2261456cd6a74ebf9313164 
  include/mesos/maintenance/maintenance.hpp 
f676d01c2c81250b6e4740ab0934f966b50ed76d 
  include/mesos/maintenance/maintenance.proto 
aaca2513e2c30297bf624a831f5aa135f9f47e48 
  include/mesos/master/allocator.hpp 08e42f31ff347fa12b492713511fbc9cd465ee73 
  include/mesos/master/allocator.proto 224da71e9f34d2ea11a6e6e235d0f8196abaeb90 
  include/mesos/mesos.hpp 371d14a6cf802d1099be84f217a1af6554cc4eee 
  include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
  include/mesos/module.hpp 01dd713941d504c3dfe606bfdf346d4702dc1495 
  include/mesos/module/allocator.hpp 376eb4860322582f911d7a07253b79b1c9aa9292 
  include/mesos/module/anonymous.hpp 22862bdba93537b7524f3143884b4d13d17c604a 
  include/mesos/module/authenticatee.hpp 
aafca1214cfdecb0479e4e8ab20fe9ffc8272473 
  include/mesos/module/authenticator.hpp 
b57938f8f4c5603b8e8e6d2e77f27a5eb302e99b 
  include/mesos/module/authorizer.hpp 7d8fc2123ac4132a7a698c855db03433eb77cea6 
  include/mesos/module/hook.hpp fdbc5b19fe04ac9456b4141d673d9fec03e9c70d 
  include/mesos/module/isolator.hpp 347d6d442debc70ff8accc4d89c944c2a2b7 
  include/mesos/module/module.hpp 6ef106ee6f1559f8e95b8309f36af2b2d6e2c48b 
  include/mesos/module/module.proto 821fc0e72ece7c497595859fc5efc1c64ea49b9b 
  include/mesos/module/qos_controller.hpp 
462f07608fb2b580cee9548b5506e9896ee7077a 
  include/mesos/module/resource_estimator.hpp 
c1e42b97d831093bb92f8666fdfd53c8a9cae83f 
  include/mesos/quota/quota.hpp 8276749efbca167c56e337aa9155fb7db739c1c9 
  include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
  include/mesos/resources.hpp ce12a26e9cc9057d6612cf2380c07be959e2990b 
  include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
  include/mesos/scheduler/scheduler.hpp 
30de72b1b535831e074cd132b61e74fec2f4890a 
  include/mesos/scheduler/scheduler.proto 
417cfe6a9bca418b0ef77cb2268fafeb07867819 
  include/mesos/slave/isolator.hpp ea14bff0d31ffc440b0451675bfa440e09a524d8 
  include/mesos/slave/isolator.proto 0e71a9381061e3d0ece8f03ae6c9d2c82d48aba7 
  include/mesos/slave/oversubscription.hpp 
ffefaa08da1de27d9e0ccb0dc833e998e1638eef 
  include/mesos/slave/oversubscription.proto 
588316739018a4360d37d64e4bb1655c488b2456 
  include/mesos/slave/qos_controller.hpp 
7e280ccabd153eb10ae72cc48078d660df9f2011 
  include/mesos/slave/resource_estimator.hpp 
731ec3a470dcc8e90199e774d6fcd1d5635be296 
  include/mesos/type_utils.hpp 1076cbda64382be29348dd5679c0e3e414aa6e67 
  include/mesos/uri/fetcher.hpp 0d58231eaacac3502e4b02769522bcda441078f4 
  include/mesos/uri/uri.hpp f278480a24152272db5df09f4a7d952b0c6f38cf 
  include/mesos/uri/uri.proto eaa15447571ea164193ce0b15e0c1b36e50cc609 
  include/mesos/v1/attributes.hpp d8b35079f41adc4e22c45c5c40698d664810e5cd 
  include/mesos/v1/executor/executor.hpp 
f50533f8120908cb5b1144bd18a4e097c5336fde 
  include/mesos/v1/executor/executor.proto 
20c712c3f952d3299f2a7c23e185ed588ef13251

Re: Review Request 39590: Made license-headers doxygen-compatible.

2015-11-23 Thread Benjamin Hindman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39590/#review107591
---

Ship it!


Ship It!

- Benjamin Hindman


On Nov. 23, 2015, 1:05 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39590/
> ---
> 
> (Updated Nov. 23, 2015, 1:05 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd 
> Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit adjusts license headers of C++ source and header files, and 
> protobuf definitions.
> 
> Also, reflect the changed style in the C++ style guide.
> 
> 
> Diffs
> -
> 
>   docs/c++-style-guide.md 678faebc548fa3a7ad60f72075d36b24af5ee744 
>   include/mesos/attributes.hpp 78afcd51b22a9eeb741076a8affeb8f2ae4bdee3 
>   include/mesos/authentication/authenticatee.hpp 
> 17fb7aa0f4d8a43f9cee0aab305af05f4fa7888f 
>   include/mesos/authentication/authentication.hpp 
> 699aa886286bc7d9c05592e71232ab1c1084871f 
>   include/mesos/authentication/authentication.proto 
> a7db56d643aa01ca2e3cd3e4268bd75b54136727 
>   include/mesos/authentication/authenticator.hpp 
> aa3818c31fee3b2e7c17d80dcceb8d41a38bbd06 
>   include/mesos/authorizer/authorizer.hpp 
> d667a52f90f970a313580446a5a006cec4b5e25b 
>   include/mesos/authorizer/authorizer.proto 
> 86bbb45f9d91b4098a262e3e50a793f3bb39497e 
>   include/mesos/containerizer/containerizer.hpp 
> 9bf76e066f390c36392c469b3d2cd92e2d10f3c7 
>   include/mesos/containerizer/containerizer.proto 
> 7cf6d2bb8c6636cbb3ea8c44fb45a41b93c8603d 
>   include/mesos/executor.hpp 72eca97dd84fb1300b37764a3ef3a57fb5e676c2 
>   include/mesos/executor/executor.hpp 
> 85f181c72cdb5e80d6c549a4d663d9bad261693a 
>   include/mesos/executor/executor.proto 
> a9243c7a10c32f104c12cbce835bc23a7c75a275 
>   include/mesos/fetcher/fetcher.hpp b7e6a717ed329d7f2586607cfe90342a96ae14a8 
>   include/mesos/fetcher/fetcher.proto 
> 1b2f4936d8dcd2b5e6d3ca2c85b3fa9df74a5797 
>   include/mesos/hook.hpp 6d7fee85566cf6c057296b5f4a9c14c9fab31085 
>   include/mesos/http.hpp 8b9b748fee5b2a8cc2261456cd6a74ebf9313164 
>   include/mesos/maintenance/maintenance.hpp 
> f676d01c2c81250b6e4740ab0934f966b50ed76d 
>   include/mesos/maintenance/maintenance.proto 
> aaca2513e2c30297bf624a831f5aa135f9f47e48 
>   include/mesos/master/allocator.hpp 08e42f31ff347fa12b492713511fbc9cd465ee73 
>   include/mesos/master/allocator.proto 
> 224da71e9f34d2ea11a6e6e235d0f8196abaeb90 
>   include/mesos/mesos.hpp 371d14a6cf802d1099be84f217a1af6554cc4eee 
>   include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
>   include/mesos/module.hpp 01dd713941d504c3dfe606bfdf346d4702dc1495 
>   include/mesos/module/allocator.hpp 376eb4860322582f911d7a07253b79b1c9aa9292 
>   include/mesos/module/anonymous.hpp 22862bdba93537b7524f3143884b4d13d17c604a 
>   include/mesos/module/authenticatee.hpp 
> aafca1214cfdecb0479e4e8ab20fe9ffc8272473 
>   include/mesos/module/authenticator.hpp 
> b57938f8f4c5603b8e8e6d2e77f27a5eb302e99b 
>   include/mesos/module/authorizer.hpp 
> 7d8fc2123ac4132a7a698c855db03433eb77cea6 
>   include/mesos/module/hook.hpp fdbc5b19fe04ac9456b4141d673d9fec03e9c70d 
>   include/mesos/module/isolator.hpp 347d6d442debc70ff8accc4d89c944c2a2b7 
>   include/mesos/module/module.hpp 6ef106ee6f1559f8e95b8309f36af2b2d6e2c48b 
>   include/mesos/module/module.proto 821fc0e72ece7c497595859fc5efc1c64ea49b9b 
>   include/mesos/module/qos_controller.hpp 
> 462f07608fb2b580cee9548b5506e9896ee7077a 
>   include/mesos/module/resource_estimator.hpp 
> c1e42b97d831093bb92f8666fdfd53c8a9cae83f 
>   include/mesos/quota/quota.hpp 8276749efbca167c56e337aa9155fb7db739c1c9 
>   include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
>   include/mesos/resources.hpp ce12a26e9cc9057d6612cf2380c07be959e2990b 
>   include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
>   include/mesos/scheduler/scheduler.hpp 
> 30de72b1b535831e074cd132b61e74fec2f4890a 
>   include/mesos/scheduler/scheduler.proto 
> 417cfe6a9bca418b0ef77cb2268fafeb07867819 
>   include/mesos/slave/isolator.hpp ea14bff0d31ffc440b0451675bfa440e09a524d8 
>   include/mesos/slave/isolator.proto 0e71a9381061e3d0ece8f03ae6c9d2c82d48aba7 
>   include/mesos/slave/oversubscription.hpp 
> ffefaa08da1de27d9e0ccb0dc833e998e1638eef 
>   include/mesos/slave/oversubscription.proto 
> 588316739018a4360d37d64e4bb1655c488b2456 
>   include/mesos/slave/qos_controller.hpp 
> 7e280ccabd153eb10ae72cc48078d660df9f2011 
>   include/mesos/slave/resource_estimator.hpp 
> 731ec3a470dcc8e90199e774d6fcd1d5635be296 
>   include/mesos/type_utils.hpp

Re: Review Request 39590: Made license-headers doxygen-compatible.

2015-11-18 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39590/
---

(Updated Nov. 18, 2015, 4:05 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd 
Mathiske, and Till Toenshoff.


Changes
---

Just used C++-style comments for license headers.

This was suggested by benh; the strong argument for this approach instead of 
C-style block comments is that reduces the number of typically used comment 
styles (C-style block comments with `/**  */` for Doxygen, and C++-style 
comments `//` for almost everything else).


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description (updated)
---

This commit adjusts license headers of C++ source and header files, and 
protobuf definitions.

Also, reflect the changed style in the C++ style guide.


Diffs (updated)
-

  docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 
  include/mesos/attributes.hpp 78afcd51b22a9eeb741076a8affeb8f2ae4bdee3 
  include/mesos/authentication/authenticatee.hpp 
17fb7aa0f4d8a43f9cee0aab305af05f4fa7888f 
  include/mesos/authentication/authentication.hpp 
699aa886286bc7d9c05592e71232ab1c1084871f 
  include/mesos/authentication/authentication.proto 
a7db56d643aa01ca2e3cd3e4268bd75b54136727 
  include/mesos/authentication/authenticator.hpp 
aa3818c31fee3b2e7c17d80dcceb8d41a38bbd06 
  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  include/mesos/authorizer/authorizer.proto 
86bbb45f9d91b4098a262e3e50a793f3bb39497e 
  include/mesos/containerizer/containerizer.hpp 
9bf76e066f390c36392c469b3d2cd92e2d10f3c7 
  include/mesos/containerizer/containerizer.proto 
7cf6d2bb8c6636cbb3ea8c44fb45a41b93c8603d 
  include/mesos/executor.hpp 72eca97dd84fb1300b37764a3ef3a57fb5e676c2 
  include/mesos/executor/executor.hpp 85f181c72cdb5e80d6c549a4d663d9bad261693a 
  include/mesos/executor/executor.proto 
a9243c7a10c32f104c12cbce835bc23a7c75a275 
  include/mesos/fetcher/fetcher.hpp b7e6a717ed329d7f2586607cfe90342a96ae14a8 
  include/mesos/fetcher/fetcher.proto 1b2f4936d8dcd2b5e6d3ca2c85b3fa9df74a5797 
  include/mesos/hook.hpp 6d7fee85566cf6c057296b5f4a9c14c9fab31085 
  include/mesos/http.hpp 8b9b748fee5b2a8cc2261456cd6a74ebf9313164 
  include/mesos/maintenance/maintenance.hpp 
f676d01c2c81250b6e4740ab0934f966b50ed76d 
  include/mesos/maintenance/maintenance.proto 
aaca2513e2c30297bf624a831f5aa135f9f47e48 
  include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3 
  include/mesos/master/allocator.proto 224da71e9f34d2ea11a6e6e235d0f8196abaeb90 
  include/mesos/mesos.hpp 371d14a6cf802d1099be84f217a1af6554cc4eee 
  include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b 
  include/mesos/module.hpp 01dd713941d504c3dfe606bfdf346d4702dc1495 
  include/mesos/module/allocator.hpp 376eb4860322582f911d7a07253b79b1c9aa9292 
  include/mesos/module/anonymous.hpp 22862bdba93537b7524f3143884b4d13d17c604a 
  include/mesos/module/authenticatee.hpp 
aafca1214cfdecb0479e4e8ab20fe9ffc8272473 
  include/mesos/module/authenticator.hpp 
b57938f8f4c5603b8e8e6d2e77f27a5eb302e99b 
  include/mesos/module/authorizer.hpp 7d8fc2123ac4132a7a698c855db03433eb77cea6 
  include/mesos/module/hook.hpp fdbc5b19fe04ac9456b4141d673d9fec03e9c70d 
  include/mesos/module/isolator.hpp 347d6d442debc70ff8accc4d89c944c2a2b7 
  include/mesos/module/module.hpp 6ef106ee6f1559f8e95b8309f36af2b2d6e2c48b 
  include/mesos/module/module.proto 821fc0e72ece7c497595859fc5efc1c64ea49b9b 
  include/mesos/module/qos_controller.hpp 
462f07608fb2b580cee9548b5506e9896ee7077a 
  include/mesos/module/resource_estimator.hpp 
c1e42b97d831093bb92f8666fdfd53c8a9cae83f 
  include/mesos/quota/quota.hpp 38a5cbabe803611f7181a54ca52fbf2ccfb42773 
  include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
  include/mesos/resources.hpp ce12a26e9cc9057d6612cf2380c07be959e2990b 
  include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
  include/mesos/scheduler/scheduler.hpp 
30de72b1b535831e074cd132b61e74fec2f4890a 
  include/mesos/scheduler/scheduler.proto 
417cfe6a9bca418b0ef77cb2268fafeb07867819 
  include/mesos/slave/isolator.hpp ea14bff0d31ffc440b0451675bfa440e09a524d8 
  include/mesos/slave/isolator.proto 0e71a9381061e3d0ece8f03ae6c9d2c82d48aba7 
  include/mesos/slave/oversubscription.hpp 
ffefaa08da1de27d9e0ccb0dc833e998e1638eef 
  include/mesos/slave/oversubscription.proto 
588316739018a4360d37d64e4bb1655c488b2456 
  include/mesos/slave/qos_controller.hpp 
7e280ccabd153eb10ae72cc48078d660df9f2011 
  include/mesos/slave/resource_estimator.hpp 
731ec3a470dcc8e90199e774d6fcd1d5635be296 
  include/mesos/type_utils.hpp 1076cbda64382be29348dd5679c0e3e414aa6e67 
  include/mesos/v1/attributes.hpp d8b35079f41adc4e22c45c5c40698d664810e5cd 
  include/mesos/v1/executor/executor.hpp

Re: Review Request 39590: Made license-headers doxygen-compatible.

2015-11-09 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39590/
---

(Updated Nov. 9, 2015, 1:37 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd 
Mathiske, and Till Toenshoff.


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description
---

This commit is the result of running

for f in `find . -name '*.hpp' -or -name '*.cpp'`; do
  sed -i -E '1 s~^\/\*\*~\/\*~' $f
done

plus manual cleanup not matching that pattern or in protobuf
definitions, and updating the C++ style guide.


Diffs
-

  docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 
  include/mesos/attributes.hpp 78afcd51b22a9eeb741076a8affeb8f2ae4bdee3 
  include/mesos/authentication/authenticatee.hpp 
17fb7aa0f4d8a43f9cee0aab305af05f4fa7888f 
  include/mesos/authentication/authentication.hpp 
699aa886286bc7d9c05592e71232ab1c1084871f 
  include/mesos/authentication/authentication.proto 
a7db56d643aa01ca2e3cd3e4268bd75b54136727 
  include/mesos/authentication/authenticator.hpp 
aa3818c31fee3b2e7c17d80dcceb8d41a38bbd06 
  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  include/mesos/authorizer/authorizer.proto 
86bbb45f9d91b4098a262e3e50a793f3bb39497e 
  include/mesos/containerizer/containerizer.hpp 
9bf76e066f390c36392c469b3d2cd92e2d10f3c7 
  include/mesos/containerizer/containerizer.proto 
7cf6d2bb8c6636cbb3ea8c44fb45a41b93c8603d 
  include/mesos/executor.hpp 72eca97dd84fb1300b37764a3ef3a57fb5e676c2 
  include/mesos/executor/executor.hpp 85f181c72cdb5e80d6c549a4d663d9bad261693a 
  include/mesos/executor/executor.proto 
a9243c7a10c32f104c12cbce835bc23a7c75a275 
  include/mesos/fetcher/fetcher.hpp b7e6a717ed329d7f2586607cfe90342a96ae14a8 
  include/mesos/fetcher/fetcher.proto 1b2f4936d8dcd2b5e6d3ca2c85b3fa9df74a5797 
  include/mesos/hook.hpp 6d7fee85566cf6c057296b5f4a9c14c9fab31085 
  include/mesos/http.hpp 8b9b748fee5b2a8cc2261456cd6a74ebf9313164 
  include/mesos/maintenance/maintenance.hpp 
f676d01c2c81250b6e4740ab0934f966b50ed76d 
  include/mesos/maintenance/maintenance.proto 
aaca2513e2c30297bf624a831f5aa135f9f47e48 
  include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611 
  include/mesos/master/allocator.proto 224da71e9f34d2ea11a6e6e235d0f8196abaeb90 
  include/mesos/master/quota.hpp 5f7822f40af6fb23cdafdd0c205bcdc67e596935 
  include/mesos/master/quota.proto d2e3a45735e4ebcf257682556aff5075e6e3bf79 
  include/mesos/mesos.hpp 371d14a6cf802d1099be84f217a1af6554cc4eee 
  include/mesos/mesos.proto 94004343ea615d87d7c7d63a6a811cf8002e 
  include/mesos/module.hpp 01dd713941d504c3dfe606bfdf346d4702dc1495 
  include/mesos/module/allocator.hpp 376eb4860322582f911d7a07253b79b1c9aa9292 
  include/mesos/module/anonymous.hpp 22862bdba93537b7524f3143884b4d13d17c604a 
  include/mesos/module/authenticatee.hpp 
aafca1214cfdecb0479e4e8ab20fe9ffc8272473 
  include/mesos/module/authenticator.hpp 
b57938f8f4c5603b8e8e6d2e77f27a5eb302e99b 
  include/mesos/module/authorizer.hpp 7d8fc2123ac4132a7a698c855db03433eb77cea6 
  include/mesos/module/hook.hpp fdbc5b19fe04ac9456b4141d673d9fec03e9c70d 
  include/mesos/module/isolator.hpp 347d6d442debc70ff8accc4d89c944c2a2b7 
  include/mesos/module/module.hpp 6ef106ee6f1559f8e95b8309f36af2b2d6e2c48b 
  include/mesos/module/module.proto 821fc0e72ece7c497595859fc5efc1c64ea49b9b 
  include/mesos/module/qos_controller.hpp 
462f07608fb2b580cee9548b5506e9896ee7077a 
  include/mesos/module/resource_estimator.hpp 
c1e42b97d831093bb92f8666fdfd53c8a9cae83f 
  include/mesos/resources.hpp 6c3a065945eb56dc88df9c977e5ca11d4cbcbf61 
  include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
  include/mesos/scheduler/scheduler.hpp 
30de72b1b535831e074cd132b61e74fec2f4890a 
  include/mesos/scheduler/scheduler.proto 
417cfe6a9bca418b0ef77cb2268fafeb07867819 
  include/mesos/slave/isolator.hpp ea14bff0d31ffc440b0451675bfa440e09a524d8 
  include/mesos/slave/isolator.proto 0e71a9381061e3d0ece8f03ae6c9d2c82d48aba7 
  include/mesos/slave/oversubscription.hpp 
ffefaa08da1de27d9e0ccb0dc833e998e1638eef 
  include/mesos/slave/oversubscription.proto 
588316739018a4360d37d64e4bb1655c488b2456 
  include/mesos/slave/qos_controller.hpp 
7e280ccabd153eb10ae72cc48078d660df9f2011 
  include/mesos/slave/resource_estimator.hpp 
731ec3a470dcc8e90199e774d6fcd1d5635be296 
  include/mesos/type_utils.hpp 1076cbda64382be29348dd5679c0e3e414aa6e67 
  include/mesos/v1/attributes.hpp d8b35079f41adc4e22c45c5c40698d664810e5cd 
  include/mesos/v1/executor/executor.hpp 
f50533f8120908cb5b1144bd18a4e097c5336fde 
  include/mesos/v1/executor/executor.proto 
20c712c3f952d3299f2a7c23e185ed588ef13251 
  include/mesos/v1/mesos.hpp fe4c4b73d41505eeb977f818aecab3cd037668da 
  include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a

Re: Review Request 39590: Made license-headers doxygen-compatible.

2015-10-27 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39590/
---

(Updated Oct. 27, 2015, 10:45 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd 
Mathiske, and Till Toenshoff.


Changes
---

Updated description, and rebased.


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description (updated)
---

This commit is the result of running

for f in `find . -name '*.hpp' -or -name '*.cpp'`; do
  sed -i -E '1 s~^\/\*\*~\/\*~' $f
done

plus manual cleanup not matching that pattern or in protobuf
definitions, and updating the C++ style guide.


Diffs (updated)
-

  docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 
  include/mesos/attributes.hpp 78afcd51b22a9eeb741076a8affeb8f2ae4bdee3 
  include/mesos/authentication/authenticatee.hpp 
17fb7aa0f4d8a43f9cee0aab305af05f4fa7888f 
  include/mesos/authentication/authentication.hpp 
699aa886286bc7d9c05592e71232ab1c1084871f 
  include/mesos/authentication/authentication.proto 
a7db56d643aa01ca2e3cd3e4268bd75b54136727 
  include/mesos/authentication/authenticator.hpp 
aa3818c31fee3b2e7c17d80dcceb8d41a38bbd06 
  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  include/mesos/authorizer/authorizer.proto 
86bbb45f9d91b4098a262e3e50a793f3bb39497e 
  include/mesos/containerizer/containerizer.hpp 
9bf76e066f390c36392c469b3d2cd92e2d10f3c7 
  include/mesos/containerizer/containerizer.proto 
7cf6d2bb8c6636cbb3ea8c44fb45a41b93c8603d 
  include/mesos/executor.hpp 72eca97dd84fb1300b37764a3ef3a57fb5e676c2 
  include/mesos/executor/executor.hpp 85f181c72cdb5e80d6c549a4d663d9bad261693a 
  include/mesos/executor/executor.proto 
a9243c7a10c32f104c12cbce835bc23a7c75a275 
  include/mesos/fetcher/fetcher.hpp b7e6a717ed329d7f2586607cfe90342a96ae14a8 
  include/mesos/fetcher/fetcher.proto 1b2f4936d8dcd2b5e6d3ca2c85b3fa9df74a5797 
  include/mesos/hook.hpp 6d7fee85566cf6c057296b5f4a9c14c9fab31085 
  include/mesos/http.hpp 8b9b748fee5b2a8cc2261456cd6a74ebf9313164 
  include/mesos/maintenance/maintenance.hpp 
f676d01c2c81250b6e4740ab0934f966b50ed76d 
  include/mesos/maintenance/maintenance.proto 
aaca2513e2c30297bf624a831f5aa135f9f47e48 
  include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611 
  include/mesos/master/allocator.proto 224da71e9f34d2ea11a6e6e235d0f8196abaeb90 
  include/mesos/master/quota.hpp 5f7822f40af6fb23cdafdd0c205bcdc67e596935 
  include/mesos/master/quota.proto d2e3a45735e4ebcf257682556aff5075e6e3bf79 
  include/mesos/mesos.hpp 371d14a6cf802d1099be84f217a1af6554cc4eee 
  include/mesos/mesos.proto 94004343ea615d87d7c7d63a6a811cf8002e 
  include/mesos/module.hpp 01dd713941d504c3dfe606bfdf346d4702dc1495 
  include/mesos/module/allocator.hpp 376eb4860322582f911d7a07253b79b1c9aa9292 
  include/mesos/module/anonymous.hpp 22862bdba93537b7524f3143884b4d13d17c604a 
  include/mesos/module/authenticatee.hpp 
aafca1214cfdecb0479e4e8ab20fe9ffc8272473 
  include/mesos/module/authenticator.hpp 
b57938f8f4c5603b8e8e6d2e77f27a5eb302e99b 
  include/mesos/module/authorizer.hpp 7d8fc2123ac4132a7a698c855db03433eb77cea6 
  include/mesos/module/hook.hpp fdbc5b19fe04ac9456b4141d673d9fec03e9c70d 
  include/mesos/module/isolator.hpp 347d6d442debc70ff8accc4d89c944c2a2b7 
  include/mesos/module/module.hpp 6ef106ee6f1559f8e95b8309f36af2b2d6e2c48b 
  include/mesos/module/module.proto 821fc0e72ece7c497595859fc5efc1c64ea49b9b 
  include/mesos/module/qos_controller.hpp 
462f07608fb2b580cee9548b5506e9896ee7077a 
  include/mesos/module/resource_estimator.hpp 
c1e42b97d831093bb92f8666fdfd53c8a9cae83f 
  include/mesos/resources.hpp 6c3a065945eb56dc88df9c977e5ca11d4cbcbf61 
  include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
  include/mesos/scheduler/scheduler.hpp 
30de72b1b535831e074cd132b61e74fec2f4890a 
  include/mesos/scheduler/scheduler.proto 
417cfe6a9bca418b0ef77cb2268fafeb07867819 
  include/mesos/slave/isolator.hpp ea14bff0d31ffc440b0451675bfa440e09a524d8 
  include/mesos/slave/isolator.proto 0e71a9381061e3d0ece8f03ae6c9d2c82d48aba7 
  include/mesos/slave/oversubscription.hpp 
ffefaa08da1de27d9e0ccb0dc833e998e1638eef 
  include/mesos/slave/oversubscription.proto 
588316739018a4360d37d64e4bb1655c488b2456 
  include/mesos/slave/qos_controller.hpp 
7e280ccabd153eb10ae72cc48078d660df9f2011 
  include/mesos/slave/resource_estimator.hpp 
731ec3a470dcc8e90199e774d6fcd1d5635be296 
  include/mesos/type_utils.hpp 1076cbda64382be29348dd5679c0e3e414aa6e67 
  include/mesos/v1/attributes.hpp d8b35079f41adc4e22c45c5c40698d664810e5cd 
  include/mesos/v1/executor/executor.hpp 
f50533f8120908cb5b1144bd18a4e097c5336fde 
  include/mesos/v1/executor/executor.proto 
20c712c3f952d3299f2a7c23e185ed588ef13251 
  include/mesos/v1/mesos.hpp fe4c4b73d41505eeb977f818aecab3cd037668da

Re: Review Request 39590: Made license-headers doxygen-compatible.

2015-10-26 Thread Alexander Rukletsov 


> On Oct. 24, 2015, 7:23 p.m., Alexander Rukletsov wrote:
> > What about `.proto` files?
> 
> Benjamin Bannier wrote:
> Good point, since they contain C++ embedded they should follow a similar 
> style. I pushed an updated RR.
> 
> Most files follow that format; I cross-checked with a WIP linter check, 
> https://gist.github.com/bbannier/02231787b107b71360f7.

I think you also want to update description.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39590/#review103903
---


On Oct. 25, 2015, 2:49 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39590/
> ---
> 
> (Updated Oct. 25, 2015, 2:49 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd 
> Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit is the result of running
> 
> for f in `find . -name '*.hpp' -or -name '*.cpp'`; do
>   sed -i -E '1 s~^\/\*\*~\/\*~' $f
> done
> 
> and updating the C++ style guide.
> 
> 
> Diffs
> -
> 
>   docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 
>   include/mesos/attributes.hpp 78afcd51b22a9eeb741076a8affeb8f2ae4bdee3 
>   include/mesos/authentication/authenticatee.hpp 
> 17fb7aa0f4d8a43f9cee0aab305af05f4fa7888f 
>   include/mesos/authentication/authentication.hpp 
> 699aa886286bc7d9c05592e71232ab1c1084871f 
>   include/mesos/authentication/authentication.proto 
> a7db56d643aa01ca2e3cd3e4268bd75b54136727 
>   include/mesos/authentication/authenticator.hpp 
> aa3818c31fee3b2e7c17d80dcceb8d41a38bbd06 
>   include/mesos/authorizer/authorizer.hpp 
> d667a52f90f970a313580446a5a006cec4b5e25b 
>   include/mesos/authorizer/authorizer.proto 
> 86bbb45f9d91b4098a262e3e50a793f3bb39497e 
>   include/mesos/containerizer/containerizer.hpp 
> 9bf76e066f390c36392c469b3d2cd92e2d10f3c7 
>   include/mesos/containerizer/containerizer.proto 
> 7cf6d2bb8c6636cbb3ea8c44fb45a41b93c8603d 
>   include/mesos/executor.hpp 72eca97dd84fb1300b37764a3ef3a57fb5e676c2 
>   include/mesos/executor/executor.hpp 
> 85f181c72cdb5e80d6c549a4d663d9bad261693a 
>   include/mesos/executor/executor.proto 
> a9243c7a10c32f104c12cbce835bc23a7c75a275 
>   include/mesos/fetcher/fetcher.hpp b7e6a717ed329d7f2586607cfe90342a96ae14a8 
>   include/mesos/fetcher/fetcher.proto 
> 1b2f4936d8dcd2b5e6d3ca2c85b3fa9df74a5797 
>   include/mesos/hook.hpp 6d7fee85566cf6c057296b5f4a9c14c9fab31085 
>   include/mesos/http.hpp 8b9b748fee5b2a8cc2261456cd6a74ebf9313164 
>   include/mesos/maintenance/maintenance.hpp 
> f676d01c2c81250b6e4740ab0934f966b50ed76d 
>   include/mesos/maintenance/maintenance.proto 
> aaca2513e2c30297bf624a831f5aa135f9f47e48 
>   include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611 
>   include/mesos/master/allocator.proto 
> 224da71e9f34d2ea11a6e6e235d0f8196abaeb90 
>   include/mesos/master/quota.hpp 5f7822f40af6fb23cdafdd0c205bcdc67e596935 
>   include/mesos/master/quota.proto d2e3a45735e4ebcf257682556aff5075e6e3bf79 
>   include/mesos/mesos.hpp 371d14a6cf802d1099be84f217a1af6554cc4eee 
>   include/mesos/mesos.proto 94004343ea615d87d7c7d63a6a811cf8002e 
>   include/mesos/module.hpp 01dd713941d504c3dfe606bfdf346d4702dc1495 
>   include/mesos/module/allocator.hpp 376eb4860322582f911d7a07253b79b1c9aa9292 
>   include/mesos/module/anonymous.hpp 22862bdba93537b7524f3143884b4d13d17c604a 
>   include/mesos/module/authenticatee.hpp 
> aafca1214cfdecb0479e4e8ab20fe9ffc8272473 
>   include/mesos/module/authenticator.hpp 
> b57938f8f4c5603b8e8e6d2e77f27a5eb302e99b 
>   include/mesos/module/authorizer.hpp 
> 7d8fc2123ac4132a7a698c855db03433eb77cea6 
>   include/mesos/module/hook.hpp fdbc5b19fe04ac9456b4141d673d9fec03e9c70d 
>   include/mesos/module/isolator.hpp 347d6d442debc70ff8accc4d89c944c2a2b7 
>   include/mesos/module/module.hpp 6ef106ee6f1559f8e95b8309f36af2b2d6e2c48b 
>   include/mesos/module/module.proto 821fc0e72ece7c497595859fc5efc1c64ea49b9b 
>   include/mesos/module/qos_controller.hpp 
> 462f07608fb2b580cee9548b5506e9896ee7077a 
>   include/mesos/module/resource_estimator.hpp 
> c1e42b97d831093bb92f8666fdfd53c8a9cae83f 
>   include/mesos/resources.hpp 6c3a065945eb56dc88df9c977e5ca11d4cbcbf61 
>   include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
>   include/mesos/scheduler/scheduler.hpp 
> 30de72b1b535831e074cd132b61e74fec2f4890a 
>   include/mesos/scheduler/scheduler.proto 
> 417cfe6a9bca418b0ef77cb2268fafeb07867819 
>   include/mesos/slave/isolator.hpp ea14bff0d31ffc440b0451675bfa440e09a524d8 
>   include/mesos/slave/isolator.proto

Re: Review Request 39590: Made license-headers doxygen-compatible.

2015-10-25 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39590/
---

(Updated Oct. 25, 2015, 2:49 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd 
Mathiske, and Till Toenshoff.


Changes
---

Also fixed license block in proto files.


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description
---

This commit is the result of running

for f in `find . -name '*.hpp' -or -name '*.cpp'`; do
  sed -i -E '1 s~^\/\*\*~\/\*~' $f
done

and updating the C++ style guide.


Diffs (updated)
-

  docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 
  include/mesos/attributes.hpp 78afcd51b22a9eeb741076a8affeb8f2ae4bdee3 
  include/mesos/authentication/authenticatee.hpp 
17fb7aa0f4d8a43f9cee0aab305af05f4fa7888f 
  include/mesos/authentication/authentication.hpp 
699aa886286bc7d9c05592e71232ab1c1084871f 
  include/mesos/authentication/authentication.proto 
a7db56d643aa01ca2e3cd3e4268bd75b54136727 
  include/mesos/authentication/authenticator.hpp 
aa3818c31fee3b2e7c17d80dcceb8d41a38bbd06 
  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  include/mesos/authorizer/authorizer.proto 
86bbb45f9d91b4098a262e3e50a793f3bb39497e 
  include/mesos/containerizer/containerizer.hpp 
9bf76e066f390c36392c469b3d2cd92e2d10f3c7 
  include/mesos/containerizer/containerizer.proto 
7cf6d2bb8c6636cbb3ea8c44fb45a41b93c8603d 
  include/mesos/executor.hpp 72eca97dd84fb1300b37764a3ef3a57fb5e676c2 
  include/mesos/executor/executor.hpp 85f181c72cdb5e80d6c549a4d663d9bad261693a 
  include/mesos/executor/executor.proto 
a9243c7a10c32f104c12cbce835bc23a7c75a275 
  include/mesos/fetcher/fetcher.hpp b7e6a717ed329d7f2586607cfe90342a96ae14a8 
  include/mesos/fetcher/fetcher.proto 1b2f4936d8dcd2b5e6d3ca2c85b3fa9df74a5797 
  include/mesos/hook.hpp 6d7fee85566cf6c057296b5f4a9c14c9fab31085 
  include/mesos/http.hpp 8b9b748fee5b2a8cc2261456cd6a74ebf9313164 
  include/mesos/maintenance/maintenance.hpp 
f676d01c2c81250b6e4740ab0934f966b50ed76d 
  include/mesos/maintenance/maintenance.proto 
aaca2513e2c30297bf624a831f5aa135f9f47e48 
  include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611 
  include/mesos/master/allocator.proto 224da71e9f34d2ea11a6e6e235d0f8196abaeb90 
  include/mesos/master/quota.hpp 5f7822f40af6fb23cdafdd0c205bcdc67e596935 
  include/mesos/master/quota.proto d2e3a45735e4ebcf257682556aff5075e6e3bf79 
  include/mesos/mesos.hpp 371d14a6cf802d1099be84f217a1af6554cc4eee 
  include/mesos/mesos.proto 94004343ea615d87d7c7d63a6a811cf8002e 
  include/mesos/module.hpp 01dd713941d504c3dfe606bfdf346d4702dc1495 
  include/mesos/module/allocator.hpp 376eb4860322582f911d7a07253b79b1c9aa9292 
  include/mesos/module/anonymous.hpp 22862bdba93537b7524f3143884b4d13d17c604a 
  include/mesos/module/authenticatee.hpp 
aafca1214cfdecb0479e4e8ab20fe9ffc8272473 
  include/mesos/module/authenticator.hpp 
b57938f8f4c5603b8e8e6d2e77f27a5eb302e99b 
  include/mesos/module/authorizer.hpp 7d8fc2123ac4132a7a698c855db03433eb77cea6 
  include/mesos/module/hook.hpp fdbc5b19fe04ac9456b4141d673d9fec03e9c70d 
  include/mesos/module/isolator.hpp 347d6d442debc70ff8accc4d89c944c2a2b7 
  include/mesos/module/module.hpp 6ef106ee6f1559f8e95b8309f36af2b2d6e2c48b 
  include/mesos/module/module.proto 821fc0e72ece7c497595859fc5efc1c64ea49b9b 
  include/mesos/module/qos_controller.hpp 
462f07608fb2b580cee9548b5506e9896ee7077a 
  include/mesos/module/resource_estimator.hpp 
c1e42b97d831093bb92f8666fdfd53c8a9cae83f 
  include/mesos/resources.hpp 6c3a065945eb56dc88df9c977e5ca11d4cbcbf61 
  include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
  include/mesos/scheduler/scheduler.hpp 
30de72b1b535831e074cd132b61e74fec2f4890a 
  include/mesos/scheduler/scheduler.proto 
417cfe6a9bca418b0ef77cb2268fafeb07867819 
  include/mesos/slave/isolator.hpp ea14bff0d31ffc440b0451675bfa440e09a524d8 
  include/mesos/slave/isolator.proto 0e71a9381061e3d0ece8f03ae6c9d2c82d48aba7 
  include/mesos/slave/oversubscription.hpp 
ffefaa08da1de27d9e0ccb0dc833e998e1638eef 
  include/mesos/slave/oversubscription.proto 
588316739018a4360d37d64e4bb1655c488b2456 
  include/mesos/slave/qos_controller.hpp 
7e280ccabd153eb10ae72cc48078d660df9f2011 
  include/mesos/slave/resource_estimator.hpp 
731ec3a470dcc8e90199e774d6fcd1d5635be296 
  include/mesos/type_utils.hpp 1076cbda64382be29348dd5679c0e3e414aa6e67 
  include/mesos/v1/attributes.hpp d8b35079f41adc4e22c45c5c40698d664810e5cd 
  include/mesos/v1/executor/executor.hpp 
f50533f8120908cb5b1144bd18a4e097c5336fde 
  include/mesos/v1/executor/executor.proto 
20c712c3f952d3299f2a7c23e185ed588ef13251 
  include/mesos/v1/mesos.hpp fe4c4b73d41505eeb977f818aecab3cd037668da 
  include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a

Re: Review Request 39590: Made license-headers doxygen-compatible.

2015-10-25 Thread Benjamin Bannier 


> On Oct. 24, 2015, 7:23 p.m., Alexander Rukletsov wrote:
> > What about `.proto` files?

Good point, since they contain C++ embedded they should follow a similar style. 
I pushed an updated RR.

Most files follow that format; I cross-checked with a WIP linter check, 
https://gist.github.com/bbannier/02231787b107b71360f7.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39590/#review103903
---


On Oct. 24, 2015, 12:06 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39590/
> ---
> 
> (Updated Oct. 24, 2015, 12:06 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd 
> Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit is the result of running
> 
> for f in `find . -name '*.hpp' -or -name '*.cpp'`; do
>   sed -i -E '1 s~^\/\*\*~\/\*~' $f
> done
> 
> and updating the C++ style guide.
> 
> 
> Diffs
> -
> 
>   docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 
>   include/mesos/attributes.hpp 78afcd51b22a9eeb741076a8affeb8f2ae4bdee3 
>   include/mesos/authentication/authenticatee.hpp 
> 17fb7aa0f4d8a43f9cee0aab305af05f4fa7888f 
>   include/mesos/authentication/authentication.hpp 
> 699aa886286bc7d9c05592e71232ab1c1084871f 
>   include/mesos/authentication/authenticator.hpp 
> aa3818c31fee3b2e7c17d80dcceb8d41a38bbd06 
>   include/mesos/authorizer/authorizer.hpp 
> d667a52f90f970a313580446a5a006cec4b5e25b 
>   include/mesos/containerizer/containerizer.hpp 
> 9bf76e066f390c36392c469b3d2cd92e2d10f3c7 
>   include/mesos/executor.hpp 72eca97dd84fb1300b37764a3ef3a57fb5e676c2 
>   include/mesos/executor/executor.hpp 
> 85f181c72cdb5e80d6c549a4d663d9bad261693a 
>   include/mesos/fetcher/fetcher.hpp b7e6a717ed329d7f2586607cfe90342a96ae14a8 
>   include/mesos/hook.hpp 6d7fee85566cf6c057296b5f4a9c14c9fab31085 
>   include/mesos/http.hpp 8b9b748fee5b2a8cc2261456cd6a74ebf9313164 
>   include/mesos/maintenance/maintenance.hpp 
> f676d01c2c81250b6e4740ab0934f966b50ed76d 
>   include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611 
>   include/mesos/master/quota.hpp 5f7822f40af6fb23cdafdd0c205bcdc67e596935 
>   include/mesos/mesos.hpp 371d14a6cf802d1099be84f217a1af6554cc4eee 
>   include/mesos/module.hpp 01dd713941d504c3dfe606bfdf346d4702dc1495 
>   include/mesos/module/allocator.hpp 376eb4860322582f911d7a07253b79b1c9aa9292 
>   include/mesos/module/anonymous.hpp 22862bdba93537b7524f3143884b4d13d17c604a 
>   include/mesos/module/authenticatee.hpp 
> aafca1214cfdecb0479e4e8ab20fe9ffc8272473 
>   include/mesos/module/authenticator.hpp 
> b57938f8f4c5603b8e8e6d2e77f27a5eb302e99b 
>   include/mesos/module/authorizer.hpp 
> 7d8fc2123ac4132a7a698c855db03433eb77cea6 
>   include/mesos/module/hook.hpp fdbc5b19fe04ac9456b4141d673d9fec03e9c70d 
>   include/mesos/module/isolator.hpp 347d6d442debc70ff8accc4d89c944c2a2b7 
>   include/mesos/module/module.hpp 6ef106ee6f1559f8e95b8309f36af2b2d6e2c48b 
>   include/mesos/module/qos_controller.hpp 
> 462f07608fb2b580cee9548b5506e9896ee7077a 
>   include/mesos/module/resource_estimator.hpp 
> c1e42b97d831093bb92f8666fdfd53c8a9cae83f 
>   include/mesos/resources.hpp 6c3a065945eb56dc88df9c977e5ca11d4cbcbf61 
>   include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
>   include/mesos/scheduler/scheduler.hpp 
> 30de72b1b535831e074cd132b61e74fec2f4890a 
>   include/mesos/slave/isolator.hpp ea14bff0d31ffc440b0451675bfa440e09a524d8 
>   include/mesos/slave/oversubscription.hpp 
> ffefaa08da1de27d9e0ccb0dc833e998e1638eef 
>   include/mesos/slave/qos_controller.hpp 
> 7e280ccabd153eb10ae72cc48078d660df9f2011 
>   include/mesos/slave/resource_estimator.hpp 
> 731ec3a470dcc8e90199e774d6fcd1d5635be296 
>   include/mesos/type_utils.hpp 1076cbda64382be29348dd5679c0e3e414aa6e67 
>   include/mesos/v1/attributes.hpp d8b35079f41adc4e22c45c5c40698d664810e5cd 
>   include/mesos/v1/executor/executor.hpp 
> f50533f8120908cb5b1144bd18a4e097c5336fde 
>   include/mesos/v1/mesos.hpp fe4c4b73d41505eeb977f818aecab3cd037668da 
>   include/mesos/v1/resources.hpp fe8925ac851b74d1b37919f00afc7ed816f47ea5 
>   include/mesos/v1/scheduler.hpp 9d3355ed1cd32ec2641082358aaf9c589ef698e3 
>   include/mesos/v1/scheduler/scheduler.hpp 
> eaf9f90fc9da4d03871145874599bb6d4b781567 
>   include/mesos/v1/values.hpp 4e53297854a79a820f652e69fea36319a97ecf5e 
>   include/mesos/values.hpp e300580431f7fd6cff06e9617c0227b51c4cb8e2 
>   src/authentication/cram_md5/authenticatee.hpp 
> 9d6293c32722272228652d0241c59c7eeb88d0a3 
>

Re: Review Request 39590: Made license-headers doxygen-compatible.

2015-10-24 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39590/#review103903
---


What about `.proto` files?

- Alexander Rukletsov


On Oct. 24, 2015, 2:06 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39590/
> ---
> 
> (Updated Oct. 24, 2015, 2:06 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd 
> Mathiske, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3581
> https://issues.apache.org/jira/browse/MESOS-3581
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit is the result of running
> 
> for f in `find . -name '*.hpp' -or -name '*.cpp'`; do
>   sed -i -E '1 s~^\/\*\*~\/\*~' $f
> done
> 
> and updating the C++ style guide.
> 
> 
> Diffs
> -
> 
>   docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 
>   include/mesos/attributes.hpp 78afcd51b22a9eeb741076a8affeb8f2ae4bdee3 
>   include/mesos/authentication/authenticatee.hpp 
> 17fb7aa0f4d8a43f9cee0aab305af05f4fa7888f 
>   include/mesos/authentication/authentication.hpp 
> 699aa886286bc7d9c05592e71232ab1c1084871f 
>   include/mesos/authentication/authenticator.hpp 
> aa3818c31fee3b2e7c17d80dcceb8d41a38bbd06 
>   include/mesos/authorizer/authorizer.hpp 
> d667a52f90f970a313580446a5a006cec4b5e25b 
>   include/mesos/containerizer/containerizer.hpp 
> 9bf76e066f390c36392c469b3d2cd92e2d10f3c7 
>   include/mesos/executor.hpp 72eca97dd84fb1300b37764a3ef3a57fb5e676c2 
>   include/mesos/executor/executor.hpp 
> 85f181c72cdb5e80d6c549a4d663d9bad261693a 
>   include/mesos/fetcher/fetcher.hpp b7e6a717ed329d7f2586607cfe90342a96ae14a8 
>   include/mesos/hook.hpp 6d7fee85566cf6c057296b5f4a9c14c9fab31085 
>   include/mesos/http.hpp 8b9b748fee5b2a8cc2261456cd6a74ebf9313164 
>   include/mesos/maintenance/maintenance.hpp 
> f676d01c2c81250b6e4740ab0934f966b50ed76d 
>   include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611 
>   include/mesos/master/quota.hpp 5f7822f40af6fb23cdafdd0c205bcdc67e596935 
>   include/mesos/mesos.hpp 371d14a6cf802d1099be84f217a1af6554cc4eee 
>   include/mesos/module.hpp 01dd713941d504c3dfe606bfdf346d4702dc1495 
>   include/mesos/module/allocator.hpp 376eb4860322582f911d7a07253b79b1c9aa9292 
>   include/mesos/module/anonymous.hpp 22862bdba93537b7524f3143884b4d13d17c604a 
>   include/mesos/module/authenticatee.hpp 
> aafca1214cfdecb0479e4e8ab20fe9ffc8272473 
>   include/mesos/module/authenticator.hpp 
> b57938f8f4c5603b8e8e6d2e77f27a5eb302e99b 
>   include/mesos/module/authorizer.hpp 
> 7d8fc2123ac4132a7a698c855db03433eb77cea6 
>   include/mesos/module/hook.hpp fdbc5b19fe04ac9456b4141d673d9fec03e9c70d 
>   include/mesos/module/isolator.hpp 347d6d442debc70ff8accc4d89c944c2a2b7 
>   include/mesos/module/module.hpp 6ef106ee6f1559f8e95b8309f36af2b2d6e2c48b 
>   include/mesos/module/qos_controller.hpp 
> 462f07608fb2b580cee9548b5506e9896ee7077a 
>   include/mesos/module/resource_estimator.hpp 
> c1e42b97d831093bb92f8666fdfd53c8a9cae83f 
>   include/mesos/resources.hpp 6c3a065945eb56dc88df9c977e5ca11d4cbcbf61 
>   include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
>   include/mesos/scheduler/scheduler.hpp 
> 30de72b1b535831e074cd132b61e74fec2f4890a 
>   include/mesos/slave/isolator.hpp ea14bff0d31ffc440b0451675bfa440e09a524d8 
>   include/mesos/slave/oversubscription.hpp 
> ffefaa08da1de27d9e0ccb0dc833e998e1638eef 
>   include/mesos/slave/qos_controller.hpp 
> 7e280ccabd153eb10ae72cc48078d660df9f2011 
>   include/mesos/slave/resource_estimator.hpp 
> 731ec3a470dcc8e90199e774d6fcd1d5635be296 
>   include/mesos/type_utils.hpp 1076cbda64382be29348dd5679c0e3e414aa6e67 
>   include/mesos/v1/attributes.hpp d8b35079f41adc4e22c45c5c40698d664810e5cd 
>   include/mesos/v1/executor/executor.hpp 
> f50533f8120908cb5b1144bd18a4e097c5336fde 
>   include/mesos/v1/mesos.hpp fe4c4b73d41505eeb977f818aecab3cd037668da 
>   include/mesos/v1/resources.hpp fe8925ac851b74d1b37919f00afc7ed816f47ea5 
>   include/mesos/v1/scheduler.hpp 9d3355ed1cd32ec2641082358aaf9c589ef698e3 
>   include/mesos/v1/scheduler/scheduler.hpp 
> eaf9f90fc9da4d03871145874599bb6d4b781567 
>   include/mesos/v1/values.hpp 4e53297854a79a820f652e69fea36319a97ecf5e 
>   include/mesos/values.hpp e300580431f7fd6cff06e9617c0227b51c4cb8e2 
>   src/authentication/cram_md5/authenticatee.hpp 
> 9d6293c32722272228652d0241c59c7eeb88d0a3 
>   src/authentication/cram_md5/authenticatee.cpp 
> b03b44a924632edf4424cfef1ae4163c4abc7b1a 
>   src/authentication/cram_md5/authenticator.hpp 
> e75469a2e50167582711308b301802c9dfd9fb97 
>   src/authentication/cram_md5/authenticator.cpp 
> f238872476d422856db48bd845d5941911fdf2b0 
>

Review Request 39590: Made license-headers doxygen-compatible.

2015-10-23 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39590/
---

Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Till 
Toenshoff.


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description
---

This commit is the result of running

for f in `find . -name '*.hpp' -or -name '*.cpp'`; do
  sed -i -E '1 s~^\/\*\*~\/\*~' $f
done

and updating the C++ style guide.


Diffs
-

  docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 
  include/mesos/attributes.hpp 78afcd51b22a9eeb741076a8affeb8f2ae4bdee3 
  include/mesos/authentication/authenticatee.hpp 
17fb7aa0f4d8a43f9cee0aab305af05f4fa7888f 
  include/mesos/authentication/authentication.hpp 
699aa886286bc7d9c05592e71232ab1c1084871f 
  include/mesos/authentication/authenticator.hpp 
aa3818c31fee3b2e7c17d80dcceb8d41a38bbd06 
  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  include/mesos/containerizer/containerizer.hpp 
9bf76e066f390c36392c469b3d2cd92e2d10f3c7 
  include/mesos/executor.hpp 72eca97dd84fb1300b37764a3ef3a57fb5e676c2 
  include/mesos/executor/executor.hpp 85f181c72cdb5e80d6c549a4d663d9bad261693a 
  include/mesos/fetcher/fetcher.hpp b7e6a717ed329d7f2586607cfe90342a96ae14a8 
  include/mesos/hook.hpp 6d7fee85566cf6c057296b5f4a9c14c9fab31085 
  include/mesos/http.hpp 8b9b748fee5b2a8cc2261456cd6a74ebf9313164 
  include/mesos/maintenance/maintenance.hpp 
f676d01c2c81250b6e4740ab0934f966b50ed76d 
  include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611 
  include/mesos/master/quota.hpp 5f7822f40af6fb23cdafdd0c205bcdc67e596935 
  include/mesos/mesos.hpp 371d14a6cf802d1099be84f217a1af6554cc4eee 
  include/mesos/module.hpp 01dd713941d504c3dfe606bfdf346d4702dc1495 
  include/mesos/module/allocator.hpp 376eb4860322582f911d7a07253b79b1c9aa9292 
  include/mesos/module/anonymous.hpp 22862bdba93537b7524f3143884b4d13d17c604a 
  include/mesos/module/authenticatee.hpp 
aafca1214cfdecb0479e4e8ab20fe9ffc8272473 
  include/mesos/module/authenticator.hpp 
b57938f8f4c5603b8e8e6d2e77f27a5eb302e99b 
  include/mesos/module/authorizer.hpp 7d8fc2123ac4132a7a698c855db03433eb77cea6 
  include/mesos/module/hook.hpp fdbc5b19fe04ac9456b4141d673d9fec03e9c70d 
  include/mesos/module/isolator.hpp 347d6d442debc70ff8accc4d89c944c2a2b7 
  include/mesos/module/module.hpp 6ef106ee6f1559f8e95b8309f36af2b2d6e2c48b 
  include/mesos/module/qos_controller.hpp 
462f07608fb2b580cee9548b5506e9896ee7077a 
  include/mesos/module/resource_estimator.hpp 
c1e42b97d831093bb92f8666fdfd53c8a9cae83f 
  include/mesos/resources.hpp 6c3a065945eb56dc88df9c977e5ca11d4cbcbf61 
  include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
  include/mesos/scheduler/scheduler.hpp 
30de72b1b535831e074cd132b61e74fec2f4890a 
  include/mesos/slave/isolator.hpp ea14bff0d31ffc440b0451675bfa440e09a524d8 
  include/mesos/slave/oversubscription.hpp 
ffefaa08da1de27d9e0ccb0dc833e998e1638eef 
  include/mesos/slave/qos_controller.hpp 
7e280ccabd153eb10ae72cc48078d660df9f2011 
  include/mesos/slave/resource_estimator.hpp 
731ec3a470dcc8e90199e774d6fcd1d5635be296 
  include/mesos/type_utils.hpp 1076cbda64382be29348dd5679c0e3e414aa6e67 
  include/mesos/v1/attributes.hpp d8b35079f41adc4e22c45c5c40698d664810e5cd 
  include/mesos/v1/executor/executor.hpp 
f50533f8120908cb5b1144bd18a4e097c5336fde 
  include/mesos/v1/mesos.hpp fe4c4b73d41505eeb977f818aecab3cd037668da 
  include/mesos/v1/resources.hpp fe8925ac851b74d1b37919f00afc7ed816f47ea5 
  include/mesos/v1/scheduler.hpp 9d3355ed1cd32ec2641082358aaf9c589ef698e3 
  include/mesos/v1/scheduler/scheduler.hpp 
eaf9f90fc9da4d03871145874599bb6d4b781567 
  include/mesos/v1/values.hpp 4e53297854a79a820f652e69fea36319a97ecf5e 
  include/mesos/values.hpp e300580431f7fd6cff06e9617c0227b51c4cb8e2 
  src/authentication/cram_md5/authenticatee.hpp 
9d6293c32722272228652d0241c59c7eeb88d0a3 
  src/authentication/cram_md5/authenticatee.cpp 
b03b44a924632edf4424cfef1ae4163c4abc7b1a 
  src/authentication/cram_md5/authenticator.hpp 
e75469a2e50167582711308b301802c9dfd9fb97 
  src/authentication/cram_md5/authenticator.cpp 
f238872476d422856db48bd845d5941911fdf2b0 
  src/authentication/cram_md5/auxprop.hpp 
0fa87f45a40bdb99a5f8088c0d55144ffc2804db 
  src/authentication/cram_md5/auxprop.cpp 
abf0f8dfb7367342d11c2d7a99b9fc73d09b57a8 
  src/authorizer/authorizer.cpp e1b7057701b6219ee5f74885b364fdaf4bfe7843 
  src/authorizer/local/authorizer.hpp 32de102fd588f029882ef121ca83a7410c65 
  src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 
  src/cli/execute.cpp d070164e080cb74ee15d3184487a121f429a29fc 
  src/cli/mesos.cpp 80c3c1a7e30e7e148e17c379ec6824ab7e4c0f12 
  src/cli/resolve.cpp dcb1d37a79a43c4692e7da21f9c95d79c539d095 
  src/common/attributes.cpp

Re: Review Request 39590: Made license-headers doxygen-compatible.

2015-10-23 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39590/
---

(Updated Oct. 24, 2015, 12:06 a.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd 
Mathiske, and Till Toenshoff.


Changes
---

Also applied patchset with manual changes.


Bugs: MESOS-3581
https://issues.apache.org/jira/browse/MESOS-3581


Repository: mesos


Description
---

This commit is the result of running

for f in `find . -name '*.hpp' -or -name '*.cpp'`; do
  sed -i -E '1 s~^\/\*\*~\/\*~' $f
done

and updating the C++ style guide.


Diffs (updated)
-

  docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 
  include/mesos/attributes.hpp 78afcd51b22a9eeb741076a8affeb8f2ae4bdee3 
  include/mesos/authentication/authenticatee.hpp 
17fb7aa0f4d8a43f9cee0aab305af05f4fa7888f 
  include/mesos/authentication/authentication.hpp 
699aa886286bc7d9c05592e71232ab1c1084871f 
  include/mesos/authentication/authenticator.hpp 
aa3818c31fee3b2e7c17d80dcceb8d41a38bbd06 
  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  include/mesos/containerizer/containerizer.hpp 
9bf76e066f390c36392c469b3d2cd92e2d10f3c7 
  include/mesos/executor.hpp 72eca97dd84fb1300b37764a3ef3a57fb5e676c2 
  include/mesos/executor/executor.hpp 85f181c72cdb5e80d6c549a4d663d9bad261693a 
  include/mesos/fetcher/fetcher.hpp b7e6a717ed329d7f2586607cfe90342a96ae14a8 
  include/mesos/hook.hpp 6d7fee85566cf6c057296b5f4a9c14c9fab31085 
  include/mesos/http.hpp 8b9b748fee5b2a8cc2261456cd6a74ebf9313164 
  include/mesos/maintenance/maintenance.hpp 
f676d01c2c81250b6e4740ab0934f966b50ed76d 
  include/mesos/master/allocator.hpp dbceb53a3accd32762d09785ecae06667c3cb611 
  include/mesos/master/quota.hpp 5f7822f40af6fb23cdafdd0c205bcdc67e596935 
  include/mesos/mesos.hpp 371d14a6cf802d1099be84f217a1af6554cc4eee 
  include/mesos/module.hpp 01dd713941d504c3dfe606bfdf346d4702dc1495 
  include/mesos/module/allocator.hpp 376eb4860322582f911d7a07253b79b1c9aa9292 
  include/mesos/module/anonymous.hpp 22862bdba93537b7524f3143884b4d13d17c604a 
  include/mesos/module/authenticatee.hpp 
aafca1214cfdecb0479e4e8ab20fe9ffc8272473 
  include/mesos/module/authenticator.hpp 
b57938f8f4c5603b8e8e6d2e77f27a5eb302e99b 
  include/mesos/module/authorizer.hpp 7d8fc2123ac4132a7a698c855db03433eb77cea6 
  include/mesos/module/hook.hpp fdbc5b19fe04ac9456b4141d673d9fec03e9c70d 
  include/mesos/module/isolator.hpp 347d6d442debc70ff8accc4d89c944c2a2b7 
  include/mesos/module/module.hpp 6ef106ee6f1559f8e95b8309f36af2b2d6e2c48b 
  include/mesos/module/qos_controller.hpp 
462f07608fb2b580cee9548b5506e9896ee7077a 
  include/mesos/module/resource_estimator.hpp 
c1e42b97d831093bb92f8666fdfd53c8a9cae83f 
  include/mesos/resources.hpp 6c3a065945eb56dc88df9c977e5ca11d4cbcbf61 
  include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
  include/mesos/scheduler/scheduler.hpp 
30de72b1b535831e074cd132b61e74fec2f4890a 
  include/mesos/slave/isolator.hpp ea14bff0d31ffc440b0451675bfa440e09a524d8 
  include/mesos/slave/oversubscription.hpp 
ffefaa08da1de27d9e0ccb0dc833e998e1638eef 
  include/mesos/slave/qos_controller.hpp 
7e280ccabd153eb10ae72cc48078d660df9f2011 
  include/mesos/slave/resource_estimator.hpp 
731ec3a470dcc8e90199e774d6fcd1d5635be296 
  include/mesos/type_utils.hpp 1076cbda64382be29348dd5679c0e3e414aa6e67 
  include/mesos/v1/attributes.hpp d8b35079f41adc4e22c45c5c40698d664810e5cd 
  include/mesos/v1/executor/executor.hpp 
f50533f8120908cb5b1144bd18a4e097c5336fde 
  include/mesos/v1/mesos.hpp fe4c4b73d41505eeb977f818aecab3cd037668da 
  include/mesos/v1/resources.hpp fe8925ac851b74d1b37919f00afc7ed816f47ea5 
  include/mesos/v1/scheduler.hpp 9d3355ed1cd32ec2641082358aaf9c589ef698e3 
  include/mesos/v1/scheduler/scheduler.hpp 
eaf9f90fc9da4d03871145874599bb6d4b781567 
  include/mesos/v1/values.hpp 4e53297854a79a820f652e69fea36319a97ecf5e 
  include/mesos/values.hpp e300580431f7fd6cff06e9617c0227b51c4cb8e2 
  src/authentication/cram_md5/authenticatee.hpp 
9d6293c32722272228652d0241c59c7eeb88d0a3 
  src/authentication/cram_md5/authenticatee.cpp 
b03b44a924632edf4424cfef1ae4163c4abc7b1a 
  src/authentication/cram_md5/authenticator.hpp 
e75469a2e50167582711308b301802c9dfd9fb97 
  src/authentication/cram_md5/authenticator.cpp 
f238872476d422856db48bd845d5941911fdf2b0 
  src/authentication/cram_md5/auxprop.hpp 
0fa87f45a40bdb99a5f8088c0d55144ffc2804db 
  src/authentication/cram_md5/auxprop.cpp 
abf0f8dfb7367342d11c2d7a99b9fc73d09b57a8 
  src/authorizer/authorizer.cpp e1b7057701b6219ee5f74885b364fdaf4bfe7843 
  src/authorizer/local/authorizer.hpp 32de102fd588f029882ef121ca83a7410c65 
  src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 
  src/cli/execute.cpp d070164e080cb74ee15d3184487a121f429a29fc 
  src/cli/mesos.cpp