Re: Review Request 39702: Fixed incorrect signed vs. unsigned comparisons.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39702/#review105496 --- AFAIK this should be marked as submitted. - Neil Conway On Oct. 27, 2015, 9:54 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39702/ > --- > > (Updated Oct. 27, 2015, 9:54 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-3688 > https://issues.apache.org/jira/browse/MESOS-3688 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/tests/executor_http_api_tests.cpp > e429d84a4a7bf9248cd9b644a93be3b7d9058ae9 > > Diff: https://reviews.apache.org/r/39702/diff/ > > > Testing > --- > > Builds fine with the patch and fails with compilation errors without it. > > > Thanks, > > Kapil Arya > >
Re: Review Request 39702: Fixed incorrect signed vs. unsigned comparisons.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39702/#review104513 --- Ship it! Ship It! - Guangya Liu On Oct. 27, 2015, 9:54 p.m., Kapil Arya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39702/ > --- > > (Updated Oct. 27, 2015, 9:54 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-3688 > https://issues.apache.org/jira/browse/MESOS-3688 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/tests/executor_http_api_tests.cpp > e429d84a4a7bf9248cd9b644a93be3b7d9058ae9 > > Diff: https://reviews.apache.org/r/39702/diff/ > > > Testing > --- > > Builds fine with the patch and fails with compilation errors without it. > > > Thanks, > > Kapil Arya > >
Review Request 39702: Fixed incorrect signed vs. unsigned comparisons.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39702/ --- Review request for mesos and Jie Yu. Bugs: MESOS-3688 https://issues.apache.org/jira/browse/MESOS-3688 Repository: mesos Description --- See summary. Diffs - src/tests/executor_http_api_tests.cpp e429d84a4a7bf9248cd9b644a93be3b7d9058ae9 Diff: https://reviews.apache.org/r/39702/diff/ Testing --- Builds fine with the patch and fails with compilation errors without it. Thanks, Kapil Arya
