Re: Review Request 39791: Updated createStatusUpdate() to unset StatusUpdate.uuid instead of setting it to an empty string.

2015-11-02 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39791/
---

(Updated Nov. 2, 2015, 7:31 p.m.)


Review request for mesos, Anand Mazumdar and Ben Mahler.


Changes
---

adjusted jaggedness of the comment. NNFR.


Repository: mesos


Description
---

As the deleted comment says, we were setting it to emtpy because the 'uuid' was 
a required field until 0.22.x. Since we are at 0.26 now, it should be safe to 
just unset it.


Diffs (updated)
-

  src/common/protobuf_utils.cpp 1e795dcc90b2225ad7b0a124dbdcdabdc9d2e6aa 
  src/messages/messages.proto 9a1564ff38fa1b984e92cb0abfde2108385f9e2a 

Diff: https://reviews.apache.org/r/39791/diff/


Testing
---

make check


Thanks,

Vinod Kone

Re: Review Request 39791: Updated createStatusUpdate() to unset StatusUpdate.uuid instead of setting it to an empty string.

2015-10-31 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39791/#review104641
---

Ship it!


Ship It!

- Guangya Liu


On 十月 30, 2015, 12:21 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39791/
> ---
> 
> (Updated 十月 30, 2015, 12:21 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As the deleted comment says, we were setting it to emtpy because the 'uuid' 
> was a required field until 0.22.x. Since we are at 0.26 now, it should be 
> safe to just unset it.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.cpp 1e795dcc90b2225ad7b0a124dbdcdabdc9d2e6aa 
>   src/messages/messages.proto 9a1564ff38fa1b984e92cb0abfde2108385f9e2a 
> 
> Diff: https://reviews.apache.org/r/39791/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Re: Review Request 39791: Updated createStatusUpdate() to unset StatusUpdate.uuid instead of setting it to an empty string.

2015-10-30 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39791/#review104621
---

Ship it!


Thanks for taking care of this


src/messages/messages.proto (lines 86 - 87)


Mind making this less jagged? :)


- Ben Mahler


On Oct. 30, 2015, 12:21 a.m., Vinod Kone wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39791/
> ---
> 
> (Updated Oct. 30, 2015, 12:21 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As the deleted comment says, we were setting it to emtpy because the 'uuid' 
> was a required field until 0.22.x. Since we are at 0.26 now, it should be 
> safe to just unset it.
> 
> 
> Diffs
> -
> 
>   src/common/protobuf_utils.cpp 1e795dcc90b2225ad7b0a124dbdcdabdc9d2e6aa 
>   src/messages/messages.proto 9a1564ff38fa1b984e92cb0abfde2108385f9e2a 
> 
> Diff: https://reviews.apache.org/r/39791/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>

Review Request 39791: Updated createStatusUpdate() to unset StatusUpdate.uuid instead of setting it to an empty string.

2015-10-29 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39791/
---

Review request for mesos, Anand Mazumdar and Ben Mahler.


Repository: mesos


Description
---

As the deleted comment says, we were setting it to emtpy because the 'uuid' was 
a required field until 0.22.x. Since we are at 0.26 now, it should be safe to 
just unset it.


Diffs
-

  src/common/protobuf_utils.cpp 1e795dcc90b2225ad7b0a124dbdcdabdc9d2e6aa 
  src/messages/messages.proto 9a1564ff38fa1b984e92cb0abfde2108385f9e2a 

Diff: https://reviews.apache.org/r/39791/diff/


Testing
---

make check


Thanks,

Vinod Kone