Re: Review Request 39841: WIP: Used cgroups::enabled() to check for the availability of the freezer.

2015-11-03 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39841/#review105012
---

Ship it!


Ship It!

- Jie Yu


On Nov. 2, 2015, 1:36 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39841/
> ---
> 
> (Updated Nov. 2, 2015, 1:36 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3814
> https://issues.apache.org/jira/browse/MESOS-3814
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> WIP: Used cgroups::enabled() to check for the availability of the freezer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.cpp 
> c0adb34771fdb5a85d087296a8f98b890254ddf7 
> 
> Diff: https://reviews.apache.org/r/39841/diff/
> 
> 
> Testing
> ---
> 
> This should solve the problem reported in 
> https://issues.apache.org/jira/browse/MESOS-3814, however with this test in 
> Docker still fail. The reason is that `freezer` subsytem is actually enabled 
> in docker, however the Linux launcher fails because the file system is not 
> mounted.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>



Re: Review Request 39841: WIP: Used cgroups::enabled() to check for the availability of the freezer.

2015-11-01 Thread Artem Harutyunyan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39841/
---

(Updated Nov. 1, 2015, 5:36 p.m.)


Review request for mesos, Jie Yu and Joris Van Remoortere.


Bugs: MESOS-3814
https://issues.apache.org/jira/browse/MESOS-3814


Repository: mesos


Description
---

WIP: Used cgroups::enabled() to check for the availability of the freezer.


Diffs
-

  src/slave/containerizer/linux_launcher.cpp 
c0adb34771fdb5a85d087296a8f98b890254ddf7 

Diff: https://reviews.apache.org/r/39841/diff/


Testing (updated)
---

This should solve the problem reported in 
https://issues.apache.org/jira/browse/MESOS-3814, however with this test in 
Docker still fail. The reason is that `freezer` subsytem is actually enabled in 
docker, however the Linux launcher fails because the file system is not mounted.


Thanks,

Artem Harutyunyan



Re: Review Request 39841: WIP: Used cgroups::enabled() to check for the availability of the freezer.

2015-11-01 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39841/#review104674
---


Patch looks great!

Reviews applied: [39841]

All tests passed.

- Mesos ReviewBot


On Nov. 2, 2015, 1:36 a.m., Artem Harutyunyan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39841/
> ---
> 
> (Updated Nov. 2, 2015, 1:36 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3814
> https://issues.apache.org/jira/browse/MESOS-3814
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> WIP: Used cgroups::enabled() to check for the availability of the freezer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/linux_launcher.cpp 
> c0adb34771fdb5a85d087296a8f98b890254ddf7 
> 
> Diff: https://reviews.apache.org/r/39841/diff/
> 
> 
> Testing
> ---
> 
> This should solve the problem reported in 
> https://issues.apache.org/jira/browse/MESOS-3814, however with this test in 
> Docker still fail. The reason is that `freezer` subsytem is actually enabled 
> in docker, however the Linux launcher fails because the file system is not 
> mounted.
> 
> 
> Thanks,
> 
> Artem Harutyunyan
> 
>



Review Request 39841: WIP: Used cgroups::enabled() to check for the availability of the freezer.

2015-11-01 Thread Artem Harutyunyan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39841/
---

Review request for mesos, Jie Yu and Joris Van Remoortere.


Bugs: MESOS-3814
https://issues.apache.org/jira/browse/MESOS-3814


Repository: mesos


Description
---

WIP: Used cgroups::enabled() to check for the availability of the freezer.


Diffs
-

  src/slave/containerizer/linux_launcher.cpp 
c0adb34771fdb5a85d087296a8f98b890254ddf7 

Diff: https://reviews.apache.org/r/39841/diff/


Testing
---


Thanks,

Artem Harutyunyan