Re: Review Request 39869: Added provisioner TestStore.

2015-11-04 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39869/
---

(Updated Nov. 4, 2015, 9:03 p.m.)


Review request for mesos, Jie Yu and Jojy Varghese.


Repository: mesos


Description
---

Added provisioner TestStore.


Diffs (updated)
-

  src/tests/containerizer/store.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39869/diff/


Testing
---

make check


Thanks,

Timothy Chen

Re: Review Request 39869: Added provisioner TestStore.

2015-11-02 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39869/#review104840
---

Ship it!



src/tests/containerizer/store.hpp (line 80)


Add parathesis around initializing list:

```
return vector({rootfs.get()->root});
```


- Jie Yu


On Nov. 2, 2015, 7:04 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39869/
> ---
> 
> (Updated Nov. 2, 2015, 7:04 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added provisioner TestStore.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/store.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39869/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Review Request 39869: Added provisioner TestStore.

2015-11-02 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39869/
---

Review request for mesos, Jie Yu and Jojy Varghese.


Repository: mesos


Description
---

Added provisioner TestStore.


Diffs
-

  src/tests/containerizer/store.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39869/diff/


Testing
---

make check


Thanks,

Timothy Chen