Review Request 39940: Globally ignore SIGPIPE in libprocess.

2015-11-04 Thread James Peach

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39940/
---

Review request for mesos and Ben Mahler.


Bugs: MESOS-2079
https://issues.apache.org/jira/browse/MESOS-2079


Repository: mesos


Description
---

Reliably turning SIGPIPE into EPIPE while allowing the main executable
to still own SIGPIPE handling is complex and hard to make reliable
across platforms. Globally ignore SIPIPE when we start up libprocess.


Diffs
-

  3rdparty/libprocess/src/io.cpp 26686e1a96484e3f09d41a7292f38b7579ce9c48 
  3rdparty/libprocess/src/libevent.cpp 7b4299df0e07f4f365ac1cdb24917c804cc72cdc 
  3rdparty/libprocess/src/process.cpp a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 
  3rdparty/libprocess/src/tests/main.cpp 
4a7b9b68731ba1ac489109f20af2c1eec0bdc84f 

Diff: https://reviews.apache.org/r/39940/diff/


Testing
---

make check.
Run IOTest.Write in a loop on OS X.


Thanks,

James Peach



Re: Review Request 39940: Globally ignore SIGPIPE in libprocess.

2015-11-04 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39940/#review105086
---

Ship it!


Ship It!

- haosdent huang


On Nov. 4, 2015, 5:16 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39940/
> ---
> 
> (Updated Nov. 4, 2015, 5:16 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-2079
> https://issues.apache.org/jira/browse/MESOS-2079
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Reliably turning SIGPIPE into EPIPE while allowing the main executable
> to still own SIGPIPE handling is complex and hard to make reliable
> across platforms. Globally ignore SIPIPE when we start up libprocess.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/io.cpp 26686e1a96484e3f09d41a7292f38b7579ce9c48 
>   3rdparty/libprocess/src/libevent.cpp 
> 7b4299df0e07f4f365ac1cdb24917c804cc72cdc 
>   3rdparty/libprocess/src/process.cpp 
> a94712b9ac3b60fb047b3a5a4d84a56fa4d02313 
>   3rdparty/libprocess/src/tests/main.cpp 
> 4a7b9b68731ba1ac489109f20af2c1eec0bdc84f 
> 
> Diff: https://reviews.apache.org/r/39940/diff/
> 
> 
> Testing
> ---
> 
> make check.
> Run IOTest.Write in a loop on OS X.
> 
> 
> Thanks,
> 
> James Peach
> 
>