Re: Review Request 39945: Pass SSL related environment variables to executor.

2015-11-05 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39945/
---

(Updated Nov. 5, 2015, 8:25 a.m.)


Review request for mesos, Ben Mahler, Jojy Varghese, and Timothy Chen.


Changes
---

Fix error in gcc 4.8


Repository: mesos


Description
---

Pass SSL related environment variables to executor.


Diffs (updated)
-

  src/slave/containerizer/containerizer.cpp 
06753365e2ec7cb59edd1ed6ecfe1a794498ee9b 

Diff: https://reviews.apache.org/r/39945/diff/


Testing
---


Thanks,

haosdent huang

Re: Review Request 39945: Pass SSL related environment variables to executor.

2015-11-05 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39945/#review105230
---


Patch looks great!

Reviews applied: [39944, 39945]

All tests passed.

- Mesos ReviewBot


On Nov. 5, 2015, 8:25 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39945/
> ---
> 
> (Updated Nov. 5, 2015, 8:25 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Pass SSL related environment variables to executor.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/containerizer.cpp 
> 06753365e2ec7cb59edd1ed6ecfe1a794498ee9b 
> 
> Diff: https://reviews.apache.org/r/39945/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39945: Pass SSL related environment variables to executor.

2015-11-04 Thread haosdent huang 


> On Nov. 4, 2015, 6:25 p.m., Jojy Varghese wrote:
> > src/slave/containerizer/containerizer.cpp, line 259
> > 
> >
> > Wondering if we can pass in a prefix set to the os::environment. This 
> > way, we get LIBPROCESS_IP, SSL etc all in at the same time.

Thank you very much. I use regex according you review.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39945/#review105111
---


On Nov. 5, 2015, 3:19 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39945/
> ---
> 
> (Updated Nov. 5, 2015, 3:19 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Pass SSL related environment variables to executor.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/containerizer.cpp 
> 06753365e2ec7cb59edd1ed6ecfe1a794498ee9b 
> 
> Diff: https://reviews.apache.org/r/39945/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 39945: Pass SSL related environment variables to executor.

2015-11-04 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39945/#review105111
---



src/slave/containerizer/containerizer.cpp (line 259)


Wondering if we can pass in a prefix set to the os::environment. This way, 
we get LIBPROCESS_IP, SSL etc all in at the same time.


- Jojy Varghese


On Nov. 4, 2015, 6:03 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39945/
> ---
> 
> (Updated Nov. 4, 2015, 6:03 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Jojy Varghese, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Pass SSL related environment variables to executor.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/containerizer.cpp 
> 06753365e2ec7cb59edd1ed6ecfe1a794498ee9b 
> 
> Diff: https://reviews.apache.org/r/39945/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>