Re: Review Request 40013: Stout: Corrected style of Makefiles.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40013/ --- (Updated Nov. 7, 2015, 12:50 p.m.) Review request for mesos and Till Toenshoff. Bugs: MESOS-3849 https://issues.apache.org/jira/browse/MESOS-3849 Repository: mesos Description --- This is not a full standartization of Makefile format, however, it is a step towards consistency. This patch focuses mainly on the order of files and corrects obvious issues. These are guidelines behind the change: - Files in the same folder should appear in lexicographical order. - Subfolders should appear in lexicographical order either after files or mixed with them (depending on the current consensus in the file). - Though tabs are preferred, spaces are not replaced if they are current consensus in the file or current section. Diffs - 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 67b142bbc2d80f40a1e893cc5813d58dd2aa8381 Diff: https://reviews.apache.org/r/40013/diff/ Testing --- make check (Mac OS X 10.10.4) make distcheck (CentOS 7.1.1503) Thanks, Alexander Rukletsov
Re: Review Request 40013: Stout: Corrected style of Makefiles.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40013/#review105514 --- Patch looks great! Reviews applied: [40023, 40011, 40012, 40013] All tests passed. - Mesos ReviewBot On Nov. 6, 2015, 4:22 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40013/ > --- > > (Updated Nov. 6, 2015, 4:22 p.m.) > > > Review request for mesos and Till Toenshoff. > > > Repository: mesos > > > Description > --- > > This is not a full standartization of Makefile format, however, it is a step > towards consistency. This patch focuses mainly on the order of files and > corrects obvious issues. These are guidelines behind the change: > > - Files in the same folder should appear in lexicographical order. > - Subfolders should appear in lexicographical order either after files or > mixed with them (depending on the current consensus in the file). > - Though tabs are preferred, spaces are not replaced if they are current > consensus in the file or current section. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 67b142bbc2d80f40a1e893cc5813d58dd2aa8381 > > Diff: https://reviews.apache.org/r/40013/diff/ > > > Testing > --- > > make check (Mac OS X 10.10.4) > make distcheck (CentOS 7.1.1503) > > > Thanks, > > Alexander Rukletsov > >
Re: Review Request 40013: Stout: Corrected style of Makefiles.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40013/ --- (Updated Nov. 6, 2015, 4:22 p.m.) Review request for mesos and Till Toenshoff. Changes --- Rebased, run distcheck. Repository: mesos Description --- This is not a full standartization of Makefile format, however, it is a step towards consistency. This patch focuses mainly on the order of files and corrects obvious issues. These are guidelines behind the change: - Files in the same folder should appear in lexicographical order. - Subfolders should appear in lexicographical order either after files or mixed with them (depending on the current consensus in the file). - Though tabs are preferred, spaces are not replaced if they are current consensus in the file or current section. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 67b142bbc2d80f40a1e893cc5813d58dd2aa8381 Diff: https://reviews.apache.org/r/40013/diff/ Testing (updated) --- make check (Mac OS X 10.10.4) make distcheck (CentOS 7.1.1503) Thanks, Alexander Rukletsov
Re: Review Request 40013: Stout: Corrected style of Makefiles.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40013/#review105413 --- Ship it! Ship It! - Guangya Liu On 十一月 6, 2015, 11:07 a.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40013/ > --- > > (Updated 十一月 6, 2015, 11:07 a.m.) > > > Review request for mesos and Till Toenshoff. > > > Repository: mesos > > > Description > --- > > This is not a full standartization of Makefile format, however, it is a step > towards consistency. This patch focuses mainly on the order of files and > corrects obvious issues. These are guidelines behind the change: > > - Files in the same folder should appear in lexicographical order. > - Subfolders should appear in lexicographical order either after files or > mixed with them (depending on the current consensus in the file). > - Though tabs are preferred, spaces are not replaced if they are current > consensus in the file or current section. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 67b142bbc2d80f40a1e893cc5813d58dd2aa8381 > > Diff: https://reviews.apache.org/r/40013/diff/ > > > Testing > --- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
Re: Review Request 40013: Stout: Corrected style of Makefiles.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40013/#review105412 --- Ship it! Thanks again Alex. Will commit them once you confirmed a successful `make distcheck` in the `Testing done` and/or the Apache CI ran through this patchset successfully. - Till Toenshoff On Nov. 6, 2015, 11:07 a.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40013/ > --- > > (Updated Nov. 6, 2015, 11:07 a.m.) > > > Review request for mesos and Till Toenshoff. > > > Repository: mesos > > > Description > --- > > This is not a full standartization of Makefile format, however, it is a step > towards consistency. This patch focuses mainly on the order of files and > corrects obvious issues. These are guidelines behind the change: > > - Files in the same folder should appear in lexicographical order. > - Subfolders should appear in lexicographical order either after files or > mixed with them (depending on the current consensus in the file). > - Though tabs are preferred, spaces are not replaced if they are current > consensus in the file or current section. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 67b142bbc2d80f40a1e893cc5813d58dd2aa8381 > > Diff: https://reviews.apache.org/r/40013/diff/ > > > Testing > --- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
Review Request 40013: Stout: Corrected style of Makefiles.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40013/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description --- This is not a full standartization of Makefile format, however, it is a step towards consistency. This patch focuses mainly on the order of files and corrects obvious issues. These are guidelines behind the change: - Files in the same folder should appear in lexicographical order. - Subfolders should appear in lexicographical order either after files or mixed with them (depending on the current consensus in the file). - Though tabs are preferred, spaces are not replaced if they are current consensus in the file or current section. Diffs - 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 67b142bbc2d80f40a1e893cc5813d58dd2aa8381 Diff: https://reviews.apache.org/r/40013/diff/ Testing --- make check (Mac OS X 10.10.4) Thanks, Alexander Rukletsov
