Re: Review Request 40070: Refactored registry puller pull to smaller functions.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40070/#review105656
---


Bad patch!

Reviews applied: [39832, 39882, 39839, 38579, 39015, 39016, 39017, 39053, 
39112, 39340, 39840, 38580, 40069]

Failed command: ./support/apply-review.sh -n -r 40069

Error:
 2015-11-09 07:01:23 URL:https://reviews.apache.org/r/40069/diff/raw/ 
[16792/16792] -> "40069.patch" [1]
error: patch failed: src/Makefile.am:562
error: src/Makefile.am: patch does not apply
error: patch failed: 
src/slave/containerizer/mesos/provisioner/docker/puller.cpp:19
error: src/slave/containerizer/mesos/provisioner/docker/puller.cpp: patch does 
not apply
error: src/slave/containerizer/mesos/provisioner/docker/remote_puller.hpp: does 
not exist in index
error: src/slave/containerizer/mesos/provisioner/docker/remote_puller.cpp: does 
not exist in index
error: patch failed: src/tests/containerizer/provisioner_docker_tests.cpp:42
error: src/tests/containerizer/provisioner_docker_tests.cpp: patch does not 
apply
Failed to apply patch

- Mesos ReviewBot


On Nov. 9, 2015, 6:24 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40070/
> ---
> 
> (Updated Nov. 9, 2015, 6:24 a.m.)
> 
> 
> Review request for mesos and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactored registry puller pull to smaller blocks.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp 
> PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40070/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Review Request 40070: Refactored registry puller pull to smaller functions.

[Timothy Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40070/
---

Review request for mesos and Jojy Varghese.


Repository: mesos


Description
---

Refactored registry puller pull to smaller blocks.


Diffs
-

  src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp 
PRE-CREATION 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
PRE-CREATION 

Diff: https://reviews.apache.org/r/40070/diff/


Testing
---


Thanks,

Timothy Chen

Re: Review Request 40070: Refactored registry puller pull to smaller functions.

[Jojy Varghese]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40070/#review105657
---

Ship it!


Ship It!


src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp (line 58)


i thought you wanted to add more to this comment. That it downloads 
multiple layers for the image.


- Jojy Varghese


On Nov. 9, 2015, 6:24 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40070/
> ---
> 
> (Updated Nov. 9, 2015, 6:24 a.m.)
> 
> 
> Review request for mesos and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Refactored registry puller pull to smaller blocks.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp 
> PRE-CREATION 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40070/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>