Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-26 Thread Neil Conway 


> On Nov. 25, 2015, 5:01 a.m., Michael Park wrote:
> > src/master/http.cpp, lines 541-551
> > 
> >
> > As far as its implementation, let's do:
> > 
> > ```cpp
> > static Resources removeDisks(Resources resources)
> > {
> >   foreach (Resource& resource, resources) {
> > resource.clear_disk();
> >   }
> >   return resources;
> > }
> > ```
> 
> Neil Conway wrote:
> Is this really better? You C++ guys are so tricky with your value 
> semantics :)
> 
> To me, the version in the review makes it more obvious that we are 
> copying the input value, mutating the copy, and then returning the copy. 
> Whereas in your version, at first glance the reader might think the function 
> modifies its input value in place.
> 
> What do you think? Happy to make the change if you think it is an 
> improvement.
> 
> Michael Park wrote:
> Well, I suppose "better" is subjective. It's more efficient,
> but I didn't think (and don't think) that this is less readable. But that 
> may be just me.
> 
> Also, the code that fits your description would be:
> 
> ```cpp
> static Resources removeDisks(const Resources& resources)
> {
>   Resources result = resources;  // copying the input value.
>   
>   // mutating the copy.
>   foreach (Resource& resource, result) {
> resource.clear_disk();
>   }
>   
>   return result;  // returning the copy.
> }
> ```
> 
> This version has half as many copies as the one in the review, and (I 
> think) is also just as readable.
> 
> So you have 3 options, I'll leave it upto you :)

Cool -- I went with the last version (copy input and then mutate the copy 
in-place). Thanks for the advice! :)


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review107913
---


On Nov. 26, 2015, 9:26 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated Nov. 26, 2015, 9:26 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0c9e0e93c3ae8e00f841303e8c2b26b36a775eac 
>   docs/reservation.md e297921e709838a6780c58a12637b261fa7f18cb 
>   src/Makefile.am de68e24fb2ad4c6e4175fbf8658b23bc6434a356 
>   src/master/http.cpp cffd20b2557b84b415940ab9af8d374c71b6627b 
>   src/master/master.hpp 0bb315a16801de9e7014ca0a83c5152faa75eb38 
>   src/master/master.cpp 92380952277ae3fe0b535718b6b1b8732e960745 
>   src/tests/mesos.hpp eabbf44626b0e14d93febb55b1b22c9ad236daa1 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-26 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/
---

(Updated Nov. 26, 2015, 9:26 p.m.)


Review request for mesos, Greg Mann and Michael Park.


Changes
---

Rename endpoints to use plural, tweak removeDiskInfos() implementation.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Added HTTP endpoints for creating and destroying persistent volumes.


Diffs (updated)
-

  docs/persistent-volume.md 0c9e0e93c3ae8e00f841303e8c2b26b36a775eac 
  docs/reservation.md e297921e709838a6780c58a12637b261fa7f18cb 
  src/Makefile.am de68e24fb2ad4c6e4175fbf8658b23bc6434a356 
  src/master/http.cpp cffd20b2557b84b415940ab9af8d374c71b6627b 
  src/master/master.hpp 0bb315a16801de9e7014ca0a83c5152faa75eb38 
  src/master/master.cpp 92380952277ae3fe0b535718b6b1b8732e960745 
  src/tests/mesos.hpp eabbf44626b0e14d93febb55b1b22c9ad236daa1 
  src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40247/diff/


Testing
---

(1) make check, including newly added tests

(2) Manually created/removed persistent volumes via HTTP endpoints + curl.

(3) Previewed docs in Github gist.


Thanks,

Neil Conway

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-26 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/
---

(Updated Nov. 26, 2015, 10:42 p.m.)


Review request for mesos, Greg Mann and Michael Park.


Changes
---

Fix whitespace.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Added HTTP endpoints for creating and destroying persistent volumes.


Diffs (updated)
-

  docs/persistent-volume.md 0c9e0e93c3ae8e00f841303e8c2b26b36a775eac 
  docs/reservation.md e297921e709838a6780c58a12637b261fa7f18cb 
  src/Makefile.am de68e24fb2ad4c6e4175fbf8658b23bc6434a356 
  src/master/http.cpp cffd20b2557b84b415940ab9af8d374c71b6627b 
  src/master/master.hpp 0bb315a16801de9e7014ca0a83c5152faa75eb38 
  src/master/master.cpp 92380952277ae3fe0b535718b6b1b8732e960745 
  src/tests/mesos.hpp eabbf44626b0e14d93febb55b1b22c9ad236daa1 
  src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40247/diff/


Testing
---

(1) make check, including newly added tests

(2) Manually created/removed persistent volumes via HTTP endpoints + curl.

(3) Previewed docs in Github gist.


Thanks,

Neil Conway

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-26 Thread Klaus Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review108181
---



src/Makefile.am (line 1708)


Shoud '\' align with other line?


- Klaus Ma


On Nov. 27, 2015, 6:42 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated Nov. 27, 2015, 6:42 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0c9e0e93c3ae8e00f841303e8c2b26b36a775eac 
>   docs/reservation.md e297921e709838a6780c58a12637b261fa7f18cb 
>   src/Makefile.am de68e24fb2ad4c6e4175fbf8658b23bc6434a356 
>   src/master/http.cpp cffd20b2557b84b415940ab9af8d374c71b6627b 
>   src/master/master.hpp 0bb315a16801de9e7014ca0a83c5152faa75eb38 
>   src/master/master.cpp 92380952277ae3fe0b535718b6b1b8732e960745 
>   src/tests/mesos.hpp eabbf44626b0e14d93febb55b1b22c9ad236daa1 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-26 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review108180
---


Submitted with the following minor changes.


src/master/http.cpp (line 618)


`s/create-volume/create-volumes/`



src/master/http.cpp (line 706)


`s/destroy-volume/destroy-volumes/`


- Michael Park


On Nov. 26, 2015, 10:42 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated Nov. 26, 2015, 10:42 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0c9e0e93c3ae8e00f841303e8c2b26b36a775eac 
>   docs/reservation.md e297921e709838a6780c58a12637b261fa7f18cb 
>   src/Makefile.am de68e24fb2ad4c6e4175fbf8658b23bc6434a356 
>   src/master/http.cpp cffd20b2557b84b415940ab9af8d374c71b6627b 
>   src/master/master.hpp 0bb315a16801de9e7014ca0a83c5152faa75eb38 
>   src/master/master.cpp 92380952277ae3fe0b535718b6b1b8732e960745 
>   src/tests/mesos.hpp eabbf44626b0e14d93febb55b1b22c9ad236daa1 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-25 Thread Neil Conway 


> On Nov. 25, 2015, 5:01 a.m., Michael Park wrote:
> > src/tests/persistent_volume_endpoints_tests.cpp, lines 159-162
> > 
> >
> > I would suggest that we reorder these since we expect `registered` to 
> > occur before `resourceOffers`. Although functionally, it should have no 
> > difference.
> > 
> > Occurences below as well.

Sounds good. Actually I just copied this code from 
reservation_endpoints_test.cpp :) So I'll fix similar code there, in a separate 
review.


> On Nov. 25, 2015, 5:01 a.m., Michael Park wrote:
> > src/master/http.cpp, line 541
> > 
> >
> > I feel like this could be taken as "remove/filter the disk resources" 
> > rather than "remove the DiskInfo portion of each resource" :(
> > 
> > I thought maybe `removeVolumes` but I think that has the same issue as 
> > before. I also think we should keep in mind that we may introduce an alias 
> > for, and deprecate `flatten`.
> > 
> > Another one would be `removeDiskInfos` to be more indicative that the 
> > `DiskInfo` portion of the `Resource`s are being removed, but then the alias 
> > for `flatten` would end up as something like, 
> > `removeRolesAndReservationInfos`...
> > 
> > This brings me to maybe declaring the state in which this resource is 
> > being transformed into. Something like... `makeRegularDisk` and 
> > `makeUnreserved`?
> > 
> > What do you think?

I vote for `removeDiskInfos()`, since it is an improvement. If/when we want to 
rename `flatten()` we can always revisit this -- since `removeDiskInfos` is 
private anyway, it should be easy to rename.


> On Nov. 25, 2015, 5:01 a.m., Michael Park wrote:
> > docs/persistent-volume.md, line 248
> > 
> >
> > It looks pretty clear that we allow the creation and destruction of 
> > multiple volumes via these endpoints. Should we call them `create-volumes` 
> > and `destroy-volumes` respectively?

Yeah, I suppose that is better. I guess it a bit weird that you can't create 
multiple volumes in the general case (i.e., you can only create n volumes on a 
single agent, not n volumes in general), but I suppose that is okay.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review107913
---


On Nov. 23, 2015, 5:06 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated Nov. 23, 2015, 5:06 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 8d14ff803249b5b81b696d40d37e013960dee41b 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp d4b1edde98925fd51e056f253758afea779be9ed 
>   src/master/master.cpp d2bc83cd77ae7fe723ccb35a7c1e0b70a04a0d6e 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-25 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/
---

(Updated Nov. 25, 2015, 10:21 p.m.)


Review request for mesos, Greg Mann and Michael Park.


Changes
---

Address comments. Two open issues left to do.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Added HTTP endpoints for creating and destroying persistent volumes.


Diffs (updated)
-

  docs/persistent-volume.md 0c9e0e93c3ae8e00f841303e8c2b26b36a775eac 
  docs/reservation.md e297921e709838a6780c58a12637b261fa7f18cb 
  src/Makefile.am de68e24fb2ad4c6e4175fbf8658b23bc6434a356 
  src/master/http.cpp cffd20b2557b84b415940ab9af8d374c71b6627b 
  src/master/master.hpp e89c11a1709f0c94c1f5fb988e71d081900a4325 
  src/master/master.cpp 92380952277ae3fe0b535718b6b1b8732e960745 
  src/tests/mesos.hpp eabbf44626b0e14d93febb55b1b22c9ad236daa1 
  src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40247/diff/


Testing
---

(1) make check, including newly added tests

(2) Manually created/removed persistent volumes via HTTP endpoints + curl.

(3) Previewed docs in Github gist.


Thanks,

Neil Conway

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-25 Thread Neil Conway 


> On Nov. 25, 2015, 5:01 a.m., Michael Park wrote:
> > src/master/http.cpp, lines 541-551
> > 
> >
> > As far as its implementation, let's do:
> > 
> > ```cpp
> > static Resources removeDisks(Resources resources)
> > {
> >   foreach (Resource& resource, resources) {
> > resource.clear_disk();
> >   }
> >   return resources;
> > }
> > ```

Is this really better? You C++ guys are so tricky with your value semantics :)

To me, the version in the review makes it more obvious that we are copying the 
input value, mutating the copy, and then returning the copy. Whereas in your 
version, at first glance the reader might think the function modifies its input 
value in place.

What do you think? Happy to make the change if you think it is an improvement.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review107913
---


On Nov. 23, 2015, 5:06 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated Nov. 23, 2015, 5:06 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 8d14ff803249b5b81b696d40d37e013960dee41b 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp d4b1edde98925fd51e056f253758afea779be9ed 
>   src/master/master.cpp d2bc83cd77ae7fe723ccb35a7c1e0b70a04a0d6e 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-24 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review107913
---

Ship it!


Looks good overall! Some nit-picks, some thoughts on naming, etc.


docs/persistent-volume.md (line 248)


It looks pretty clear that we allow the creation and destruction of 
multiple volumes via these endpoints. Should we call them `create-volumes` and 
`destroy-volumes` respectively?



docs/persistent-volume.md (lines 258 - 259)


Sorry to be nit-picking, but this still looks like the `-u` and below is 1 
space further indented than the `-i`?



src/master/http.cpp (line 541)


I feel like this could be taken as "remove/filter the disk resources" 
rather than "remove the DiskInfo portion of each resource" :(

I thought maybe `removeVolumes` but I think that has the same issue as 
before. I also think we should keep in mind that we may introduce an alias for, 
and deprecate `flatten`.

Another one would be `removeDiskInfos` to be more indicative that the 
`DiskInfo` portion of the `Resource`s are being removed, but then the alias for 
`flatten` would end up as something like, `removeRolesAndReservationInfos`...

This brings me to maybe declaring the state in which this resource is being 
transformed into. Something like... `makeRegularDisk` and `makeUnreserved`?

What do you think?



src/master/http.cpp (lines 541 - 551)


As far as its implementation, let's do:

```cpp
static Resources removeDisks(Resources resources)
{
  foreach (Resource& resource, resources) {
resource.clear_disk();
  }
  return resources;
}
```



src/master/http.cpp (lines 614 - 617)


```cpp
Option validate = validation::operation::validate(
operation.create(), slave->checkpointedResources);
```

or

```cpp
Option validate = validation::operation::validate(
operation.create(),
slave->checkpointedResources);
```



src/master/http.cpp (lines 704 - 707)


Similar to above.



src/master/http.cpp (line 1046)


`flatten()` removes `role` and `ReservationInfo` from the resources.



src/tests/mesos.hpp (line 520)


`s/reservationPrinciple/reservationPrincipal/`



src/tests/persistent_volume_endpoints_tests.cpp (lines 159 - 162)


I would suggest that we reorder these since we expect `registered` to occur 
before `resourceOffers`. Although functionally, it should have no difference.

Occurences below as well.



src/tests/persistent_volume_endpoints_tests.cpp (line 277)


We should perhaps use `frameworkInfo.role()` here to make sure that it 
matches the dynamically reserved role?



src/tests/persistent_volume_endpoints_tests.cpp (line 382)


Would the following serve as good documentation of the test?

```
ASSERT_NE(frameworkInfo.role(), "role2");
```



src/tests/persistent_volume_endpoints_tests.cpp (line 443)


This also needs to match the dynamically reserved role, right? 
`frameworkInfo.role()`?


- Michael Park


On Nov. 23, 2015, 5:06 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated Nov. 23, 2015, 5:06 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 8d14ff803249b5b81b696d40d37e013960dee41b 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp d4b1edde98925fd51e056f253758afea779be9ed 
>   src/master/master.cpp d2bc83cd77ae7fe723ccb35a7c1e0b70a04a0d6e 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-23 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review107637
---


Patch looks great!

Reviews applied: [40242, 40243, 40244, 40245, 40246, 40247]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 23, 2015, 5:06 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated Nov. 23, 2015, 5:06 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 8d14ff803249b5b81b696d40d37e013960dee41b 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp d4b1edde98925fd51e056f253758afea779be9ed 
>   src/master/master.cpp d2bc83cd77ae7fe723ccb35a7c1e0b70a04a0d6e 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-23 Thread Neil Conway 


> On Nov. 23, 2015, 1:35 a.m., Guangya Liu wrote:
> > src/master/http.cpp, line 541
> > 
> >
> > Can you please add some comments here to clarify why need this?
> 
> Guangya Liu wrote:
> Another point is that can we set this as a helper function in 
> resources.cpp?

I considered making removeDisks() a helper method in 
resources.cpp/resources.hpp, but I opted against it because resources.hpp is a 
quasi-public header (so changing it later has backward compat concerns), and it 
wasn't clear to me that this functionality will be useful for other callers.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review107531
---


On Nov. 20, 2015, 10:32 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated Nov. 20, 2015, 10:32 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-23 Thread Guangya Liu 


> On 十一月 23, 2015, 1:35 a.m., Guangya Liu wrote:
> > src/master/http.cpp, line 541
> > 
> >
> > Can you please add some comments here to clarify why need this?
> 
> Guangya Liu wrote:
> Another point is that can we set this as a helper function in 
> resources.cpp?
> 
> Neil Conway wrote:
> I considered making removeDisks() a helper method in 
> resources.cpp/resources.hpp, but I opted against it because resources.hpp is 
> a quasi-public header (so changing it later has backward compat concerns), 
> and it wasn't clear to me that this functionality will be useful for other 
> callers.

I think adding a new function will not cause backward compat issues, comments?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review107531
---


On 十一月 23, 2015, 11:44 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated 十一月 23, 2015, 11:44 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 8d14ff803249b5b81b696d40d37e013960dee41b 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp d4b1edde98925fd51e056f253758afea779be9ed 
>   src/master/master.cpp d2bc83cd77ae7fe723ccb35a7c1e0b70a04a0d6e 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-23 Thread Guangya Liu 


> On 十一月 19, 2015, 3:14 a.m., Guangya Liu wrote:
> > docs/persistent-volume.md, line 258
> > 
> >
> > I think that the http endpoint should also works without autherization, 
> > for such case, the principal and password are not needed.
> 
> Neil Conway wrote:
> I opened MESOS-3987 for this.

Thanks for filing this ticket!


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review107121
---


On 十一月 23, 2015, 11:44 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated 十一月 23, 2015, 11:44 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 8d14ff803249b5b81b696d40d37e013960dee41b 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp d4b1edde98925fd51e056f253758afea779be9ed 
>   src/master/master.cpp d2bc83cd77ae7fe723ccb35a7c1e0b70a04a0d6e 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-23 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/
---

(Updated Nov. 23, 2015, 11:44 a.m.)


Review request for mesos, Greg Mann and Michael Park.


Changes
---

Address comments.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Added HTTP endpoints for creating and destroying persistent volumes.


Diffs (updated)
-

  docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
  docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
  src/Makefile.am 8d14ff803249b5b81b696d40d37e013960dee41b 
  src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
  src/master/master.hpp d4b1edde98925fd51e056f253758afea779be9ed 
  src/master/master.cpp d2bc83cd77ae7fe723ccb35a7c1e0b70a04a0d6e 
  src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
  src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40247/diff/


Testing
---

(1) make check, including newly added tests

(2) Manually created/removed persistent volumes via HTTP endpoints + curl.

(3) Previewed docs in Github gist.


Thanks,

Neil Conway

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-23 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review107584
---


Patch looks great!

Reviews applied: [40242, 40243, 40244, 40245, 40246, 40247]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 23, 2015, 11:44 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated Nov. 23, 2015, 11:44 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 8d14ff803249b5b81b696d40d37e013960dee41b 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp d4b1edde98925fd51e056f253758afea779be9ed 
>   src/master/master.cpp d2bc83cd77ae7fe723ccb35a7c1e0b70a04a0d6e 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-23 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review107718
---

Ship it!


Ship It!

- Greg Mann


On Nov. 23, 2015, 5:06 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated Nov. 23, 2015, 5:06 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 8d14ff803249b5b81b696d40d37e013960dee41b 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp d4b1edde98925fd51e056f253758afea779be9ed 
>   src/master/master.cpp d2bc83cd77ae7fe723ccb35a7c1e0b70a04a0d6e 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-23 Thread Guangya Liu 


> On 十一月 23, 2015, 1:35 a.m., Guangya Liu wrote:
> > src/master/http.cpp, line 541
> > 
> >
> > Can you please add some comments here to clarify why need this?
> 
> Guangya Liu wrote:
> Another point is that can we set this as a helper function in 
> resources.cpp?
> 
> Neil Conway wrote:
> I considered making removeDisks() a helper method in 
> resources.cpp/resources.hpp, but I opted against it because resources.hpp is 
> a quasi-public header (so changing it later has backward compat concerns), 
> and it wasn't clear to me that this functionality will be useful for other 
> callers.
> 
> Guangya Liu wrote:
> I think adding a new function will not cause backward compat issues, 
> comments?
> 
> Neil Conway wrote:
> Adding a new function will not, but if we want to change the function 
> later, it might. For example, we should rename `flatten()` because it is a 
> not a well-chosen name, but it won't be trivial to do so because the 
> resources API is semi-public.

Yes, changing names in resources.cpp/hpp will cause backward compat issues, for 
this patch, can we just move removeDisks() to resources.cpp/hpp without 
changing any existing function names?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review107531
---


On 十一月 23, 2015, 5:06 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated 十一月 23, 2015, 5:06 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 8d14ff803249b5b81b696d40d37e013960dee41b 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp d4b1edde98925fd51e056f253758afea779be9ed 
>   src/master/master.cpp d2bc83cd77ae7fe723ccb35a7c1e0b70a04a0d6e 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-23 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/
---

(Updated Nov. 23, 2015, 5:06 p.m.)


Review request for mesos, Greg Mann and Michael Park.


Changes
---

Remove tabs from docs.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Added HTTP endpoints for creating and destroying persistent volumes.


Diffs (updated)
-

  docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
  docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
  src/Makefile.am 8d14ff803249b5b81b696d40d37e013960dee41b 
  src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
  src/master/master.hpp d4b1edde98925fd51e056f253758afea779be9ed 
  src/master/master.cpp d2bc83cd77ae7fe723ccb35a7c1e0b70a04a0d6e 
  src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
  src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40247/diff/


Testing
---

(1) make check, including newly added tests

(2) Manually created/removed persistent volumes via HTTP endpoints + curl.

(3) Previewed docs in Github gist.


Thanks,

Neil Conway

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-22 Thread Michael Park 


> On Nov. 19, 2015, 7:09 p.m., Michael Park wrote:
> > docs/persistent-volume.md, lines 255-280
> > 
> >
> > This looks to be formatted weird, could you double check? Here and below
> 
> Neil Conway wrote:
> I previewed with mesos-website-container and it seems fine to me -- what 
> weirdness did you notice?

>From the diff here, it looks like the `-u` and below are indented 1 space more 
>than `-i`.

I just noticed that there is a tab character on line 277 (279 in the latest 
diff).

```
274   "container_path": 
275 }
276   }
277 }  // tab character here
278   ]' \
279   -X POST http://:/master/create-volume
```


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review106966
---


On Nov. 20, 2015, 10:32 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated Nov. 20, 2015, 10:32 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-22 Thread Guangya Liu 


> On 十一月 23, 2015, 1:35 a.m., Guangya Liu wrote:
> > src/master/http.cpp, line 541
> > 
> >
> > Can you please add some comments here to clarify why need this?

Another point is that can we set this as a helper function in resources.cpp?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review107531
---


On 十一月 20, 2015, 10:32 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated 十一月 20, 2015, 10:32 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-22 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review107531
---



docs/persistent-volume.md (line 236)


not yours, but here should be MESOS-2408



src/master/http.cpp (line 541)


Can you please add some comments here to clarify why need this?


- Guangya Liu


On 十一月 20, 2015, 10:32 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated 十一月 20, 2015, 10:32 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-20 Thread Neil Conway 


> On Nov. 19, 2015, 7:09 p.m., Michael Park wrote:
> > docs/persistent-volume.md, lines 255-280
> > 
> >
> > This looks to be formatted weird, could you double check? Here and below

I previewed with mesos-website-container and it seems fine to me -- what 
weirdness did you notice?


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review106966
---


On Nov. 18, 2015, 11:28 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated Nov. 18, 2015, 11:28 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-20 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/
---

(Updated Nov. 20, 2015, 10:32 p.m.)


Review request for mesos, Greg Mann and Michael Park.


Changes
---

Fixed bug in /create-volume, new tests, rebase.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Added HTTP endpoints for creating and destroying persistent volumes.


Diffs (updated)
-

  docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
  docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
  src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
  src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
  src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
  src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28 
  src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
  src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40247/diff/


Testing
---

(1) make check, including newly added tests

(2) Manually created/removed persistent volumes via HTTP endpoints + curl.

(3) Previewed docs in Github gist.


Thanks,

Neil Conway

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-20 Thread Neil Conway 


> On Nov. 19, 2015, 7:09 p.m., Michael Park wrote:
> > src/master/http.cpp, line 612
> > 
> >
> > The `volumes.flatten()` here looks incorrect to me. For `/reserve`, we 
> > call `flatten` since the `required` resources are the same resources in 
> > their unreserved state. For `/create-volume` however, I think the 
> > `required` resources are the same resources with no `DiskInfo` information.
> > 
> > For example, suppose we're requested to perform a `CREATE` operation 
> > with a 4GB volume statically reserved for role R. The resources we're 
> > searching for is 4GB disk statically reserved for role R. As opposed to 4GB 
> > volume unreserved, which is what `flatten()` gives us.

Good catch! I fixed this in the most recent version of the patch.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review106966
---


On Nov. 20, 2015, 10:32 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated Nov. 20, 2015, 10:32 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-20 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review107477
---


Patch looks great!

Reviews applied: [40242, 40243, 40244, 40245, 40246, 40247]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 20, 2015, 10:32 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated Nov. 20, 2015, 10:32 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-19 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review106966
---



docs/persistent-volume.md (lines 255 - 280)


This looks to be formatted weird, could you double check? Here and below



src/master/http.cpp (line 612)


The `volumes.flatten()` here looks incorrect to me. For `/reserve`, we call 
`flatten` since the `required` resources are the same resources in their 
unreserved state. For `/create-volume` however, I think the `required` 
resources are the same resources with no `DiskInfo` information.

For example, suppose we're requested to perform a `CREATE` operation with a 
4GB volume statically reserved for role R. The resources we're searching for is 
4GB disk statically reserved for role R. As opposed to 4GB volume unreserved, 
which is what `flatten()` gives us.


- Michael Park


On Nov. 18, 2015, 11:28 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated Nov. 18, 2015, 11:28 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-18 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/
---

(Updated Nov. 18, 2015, 11:28 a.m.)


Review request for mesos, Greg Mann and Michael Park.


Changes
---

Rebase.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Added HTTP endpoints for creating and destroying persistent volumes.


Diffs (updated)
-

  docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
  docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
  src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
  src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
  src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
  src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28 
  src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
  src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40247/diff/


Testing
---

(1) make check, including newly added tests

(2) Manually created/removed persistent volumes via HTTP endpoints + curl.

(3) Previewed docs in Github gist.


Thanks,

Neil Conway

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-18 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review107022
---


Patch looks great!

Reviews applied: [40242, 40243, 40244, 40245, 40246, 40247]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 18, 2015, 11:28 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated Nov. 18, 2015, 11:28 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-18 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review107121
---



docs/persistent-volume.md (line 258)


I think that the http endpoint should also works without autherization, for 
such case, the principal and password are not needed.



docs/persistent-volume.md (line 296)


ditto


- Guangya Liu


On 十一月 18, 2015, 11:28 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated 十一月 18, 2015, 11:28 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
>   src/master/http.cpp 1c4f1406f5d917f5d655a7d61d311365f8999ce0 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28 
>   src/tests/mesos.hpp b3f69ccb9870b17a335a2fe7dbf2802c1b709e6b 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-13 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review106413
---


Patch looks great!

Reviews applied: [40242, 40243, 40244, 40245, 40246, 40247]

All tests passed.

- Mesos ReviewBot


On Nov. 13, 2015, 12:47 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated Nov. 13, 2015, 12:47 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am 09c3d8cb3bcdaca7a061574646da8f51cc2c1698 
>   src/master/http.cpp f4ec23d74e203b2a8f2af187f0e56fbde7d9b3e5 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 
>   src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> (1) make check, including newly added tests
> 
> (2) Manually created/removed persistent volumes via HTTP endpoints + curl.
> 
> (3) Previewed docs in Github gist.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-13 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/
---

(Updated Nov. 13, 2015, 12:47 p.m.)


Review request for mesos, Greg Mann and Michael Park.


Changes
---

Rebase.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Added HTTP endpoints for creating and destroying persistent volumes.


Diffs (updated)
-

  docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
  docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
  src/Makefile.am 09c3d8cb3bcdaca7a061574646da8f51cc2c1698 
  src/master/http.cpp f4ec23d74e203b2a8f2af187f0e56fbde7d9b3e5 
  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 
  src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed 
  src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40247/diff/


Testing (updated)
---

(1) make check, including newly added tests

(2) Manually created/removed persistent volumes via HTTP endpoints + curl.

(3) Previewed docs in Github gist.


Thanks,

Neil Conway

Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-12 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/
---

Review request for mesos, Greg Mann and Michael Park.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Added HTTP endpoints for creating and destroying persistent volumes.


Diffs
-

  docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
  docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
  src/Makefile.am d40378f8dc85a3b98d826e6516e17c05cd7ce174 
  src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf 
  src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
  src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 
  src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed 
  src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/40247/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 40247: Added HTTP endpoints for creating and destroying persistent volumes.

2015-11-12 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40247/#review106294
---


Patch looks great!

Reviews applied: [40242, 40243, 40244, 40245, 40246, 40247]

All tests passed.

- Mesos ReviewBot


On Nov. 12, 2015, 6 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40247/
> ---
> 
> (Updated Nov. 12, 2015, 6 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP endpoints for creating and destroying persistent volumes.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 0951ccb69daaa19b959e11cf3bf972a674a58305 
>   docs/reservation.md 81f21c3755b216b0932876c1ddd9de4d3fbe814a 
>   src/Makefile.am d40378f8dc85a3b98d826e6516e17c05cd7ce174 
>   src/master/http.cpp b0bec97ee69413bb70c2673c4ae49e74988796bf 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 
>   src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed 
>   src/tests/persistent_volume_endpoints_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40247/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>