Re: Review Request 40402: Quota: Loaded quotas upon master recovery.

2015-11-22 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40402/#review107514
---

Ship it!



src/master/master.cpp (lines 1421 - 1423)


With the modified allocator interface that also uses the C++ wrapper, we 
don't need to make an "allocator-friendly" map anymore.



src/master/master.cpp (lines 1429 - 1441)


Let's recover every time. This will be less confusing to the allocator 
writer, especially since the interface comment suggests that the quota map can 
be empty.


- Joris Van Remoortere


On Nov. 17, 2015, 8:54 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40402/
> ---
> 
> (Updated Nov. 17, 2015, 8:54 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3717
> https://issues.apache.org/jira/browse/MESOS-3717
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Populate master bookkeeping structures and notify allocator about quota upon 
> recovery.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28 
> 
> Diff: https://reviews.apache.org/r/40402/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 40402: Quota: Loaded quotas upon master recovery.

2015-11-17 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40402/#review106945
---


Patch looks great!

Reviews applied: [40399, 40400, 40401, 40398, 40402]

All tests passed.

- Mesos ReviewBot


On Nov. 17, 2015, 8:54 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40402/
> ---
> 
> (Updated Nov. 17, 2015, 8:54 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3717
> https://issues.apache.org/jira/browse/MESOS-3717
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Populate master bookkeeping structures and notify allocator about quota upon 
> recovery.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28 
> 
> Diff: https://reviews.apache.org/r/40402/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 40402: Quota: Loaded quotas upon master recovery.

2015-11-17 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40402/
---

(Updated Nov. 17, 2015, 8:52 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
and Joseph Wu.


Bugs: MESOS-3717
https://issues.apache.org/jira/browse/MESOS-3717


Repository: mesos


Description
---

Populate master bookkeeping structures and notify allocator about quota upon 
recovery.


Diffs
-

  src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28 

Diff: https://reviews.apache.org/r/40402/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Review Request 40402: Quota: Loaded quotas upon master recovery.

2015-11-17 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40402/
---

Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
and Joseph Wu.


Bugs: MESOS-3717
https://issues.apache.org/jira/browse/MESOS-3717


Repository: mesos


Description
---

Populate master bookkeeping structures and notify allocator about quota upon 
recovery.


Diffs
-

  src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28 

Diff: https://reviews.apache.org/r/40402/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov

Re: Review Request 40402: Quota: Loaded quotas upon master recovery.

2015-11-17 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40402/
---

(Updated Nov. 17, 2015, 8:54 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
and Joseph Wu.


Bugs: MESOS-3717
https://issues.apache.org/jira/browse/MESOS-3717


Repository: mesos


Description
---

Populate master bookkeeping structures and notify allocator about quota upon 
recovery.


Diffs (updated)
-

  src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28 

Diff: https://reviews.apache.org/r/40402/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov