Re: Review Request 40487: MESOS-3959: show slave hostname on executor page

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40487/#review152729
---


Fix it, then Ship it!




Looks like the file has been renamed. Thanks for the patch and sorry it fell 
through the cracks! I'll rebase, fix and commit shortly.


src/webui/master/static/slave_executor.html (line 47)


s/Slave/Agent


- Alexander Rukletsov


On Oct. 14, 2016, 8:19 p.m., Ian Babrou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40487/
> ---
> 
> (Updated Oct. 14, 2016, 8:19 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-3959
> https://issues.apache.org/jira/browse/MESOS-3959
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3959: show slave hostname on executor page
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/slave_executor.html 
> 7c66405090f46f89bdd29806a58c05dc76c0ad23 
> 
> Diff: https://reviews.apache.org/r/40487/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ian Babrou
> 
>

Re: Review Request 40487: MESOS-3959: show slave hostname on executor page

[Ian Babrou]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40487/
---

(Updated Oct. 14, 2016, 8:19 p.m.)


Review request for mesos and Benjamin Mahler.


Bugs: MESOS-3959
https://issues.apache.org/jira/browse/MESOS-3959


Repository: mesos


Description
---

MESOS-3959: show slave hostname on executor page


Diffs
-

  src/webui/master/static/slave_executor.html 
7c66405090f46f89bdd29806a58c05dc76c0ad23 

Diff: https://reviews.apache.org/r/40487/diff/


Testing
---


Thanks,

Ian Babrou

Re: Review Request 40487: MESOS-3959: show slave hostname on executor page

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40487/#review141773
---



Hey Ian,

It does appear that we still do not have the hostname in this page:
https://github.com/apache/mesos/blob/master/src/webui/master/static/agent_executor.html

However, this patch needs a rebase. Can you also include a screenshot to prove 
you've tested this? :)

- Benjamin Mahler


On July 10, 2016, 12:44 a.m., Ian Babrou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40487/
> ---
> 
> (Updated July 10, 2016, 12:44 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3959: show slave hostname on executor page
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/slave_executor.html 
> 7c66405090f46f89bdd29806a58c05dc76c0ad23 
> 
> Diff: https://reviews.apache.org/r/40487/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ian Babrou
> 
>

Re: Review Request 40487: MESOS-3959: show slave hostname on executor page

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40487/#review108774
---


Bad review!

Reviews applied: []

Error:
 No reviewers specified. Please find a reviewer by asking on JIRA or the 
mailing list.

- Mesos ReviewBot


On Nov. 20, 2015, 5 p.m., Ian Babrou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40487/
> ---
> 
> (Updated Nov. 20, 2015, 5 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3959: show slave hostname on executor page
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/slave_executor.html 
> 7c66405090f46f89bdd29806a58c05dc76c0ad23 
> 
> Diff: https://reviews.apache.org/r/40487/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ian Babrou
> 
>

Re: Review Request 40487: MESOS-3959: show slave hostname on executor page

[Ben Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40487/#review108765
---


Hey Ian thanks for your patch!

While this is pretty trivial, would you mind sharing a screenshot before I 
commit this so that I know you've actually checked how this looks?

- Ben Mahler


On Nov. 20, 2015, 5 p.m., Ian Babrou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40487/
> ---
> 
> (Updated Nov. 20, 2015, 5 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3959: show slave hostname on executor page
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/slave_executor.html 
> 7c66405090f46f89bdd29806a58c05dc76c0ad23 
> 
> Diff: https://reviews.apache.org/r/40487/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ian Babrou
> 
>