Re: Review Request 40545: MESOS-3970: fix cpu usage in mesos ui

2016-09-14 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40545/#review148880
---



@Ian can you please re-open if this is still an issue? I could not reproduce.
Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Sept. 14, 2016, 9:16 a.m., Ian Babrou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40545/
> ---
> 
> (Updated Sept. 14, 2016, 9:16 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-3970
> https://issues.apache.org/jira/browse/MESOS-3970
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3970: fix cpu usage in mesos ui
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/js/services.js 
> d41bc7142ae0182e25b2ae9dce960ee38ab22361 
> 
> Diff: https://reviews.apache.org/r/40545/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ian Babrou
> 
>

Re: Review Request 40545: MESOS-3970: fix cpu usage in mesos ui

2016-09-14 Thread Ian Babrou 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40545/
---

(Updated Sept. 14, 2016, 9:16 a.m.)


Review request for mesos.


Bugs: MESOS-3970
https://issues.apache.org/jira/browse/MESOS-3970


Repository: mesos


Description
---

MESOS-3970: fix cpu usage in mesos ui


Diffs
-

  src/webui/master/static/js/services.js 
d41bc7142ae0182e25b2ae9dce960ee38ab22361 

Diff: https://reviews.apache.org/r/40545/diff/


Testing
---


Thanks,

Ian Babrou

Re: Review Request 40545: MESOS-3970: fix cpu usage in mesos ui

2015-11-24 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40545/#review107763
---


Bad review!

Reviews applied: []

Error:
 No reviewers specified. Please find a reviewer by asking on JIRA or the 
mailing list.

- Mesos ReviewBot


On Nov. 20, 2015, 5:01 p.m., Ian Babrou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40545/
> ---
> 
> (Updated Nov. 20, 2015, 5:01 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3970: fix cpu usage in mesos ui
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/js/services.js 
> d41bc7142ae0182e25b2ae9dce960ee38ab22361 
> 
> Diff: https://reviews.apache.org/r/40545/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ian Babrou
> 
>

Re: Review Request 40545: MESOS-3970: fix cpu usage in mesos ui

2015-11-24 Thread Klaus Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40545/#review107739
---

Ship it!


Ship It!

- Klaus Ma


On Nov. 21, 2015, 1:01 a.m., Ian Babrou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40545/
> ---
> 
> (Updated Nov. 21, 2015, 1:01 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3970: fix cpu usage in mesos ui
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/js/services.js 
> d41bc7142ae0182e25b2ae9dce960ee38ab22361 
> 
> Diff: https://reviews.apache.org/r/40545/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ian Babrou
> 
>

Re: Review Request 40545: MESOS-3970: fix cpu usage in mesos ui

2015-11-24 Thread Ian Babrou 


> On Nov. 24, 2015, 8:14 a.m., Klaus Ma wrote:
> > src/webui/master/static/js/services.js, line 130
> > 
> >
> > Do we know why timestamp is NaN?

Because mesos slaves do not supply it in metrics. It's not NaN, it's undefined, 
and undefined - undefined = NaN:

> undefined - undefined
NaN


- Ian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40545/#review107734
---


On Nov. 20, 2015, 5:01 p.m., Ian Babrou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40545/
> ---
> 
> (Updated Nov. 20, 2015, 5:01 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3970: fix cpu usage in mesos ui
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/js/services.js 
> d41bc7142ae0182e25b2ae9dce960ee38ab22361 
> 
> Diff: https://reviews.apache.org/r/40545/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ian Babrou
> 
>

Re: Review Request 40545: MESOS-3970: fix cpu usage in mesos ui

2015-11-24 Thread Klaus Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40545/#review107734
---



src/webui/master/static/js/services.js (line 130)


Do we know why timestamp is NaN?


- Klaus Ma


On Nov. 21, 2015, 1:01 a.m., Ian Babrou wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40545/
> ---
> 
> (Updated Nov. 21, 2015, 1:01 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> MESOS-3970: fix cpu usage in mesos ui
> 
> 
> Diffs
> -
> 
>   src/webui/master/static/js/services.js 
> d41bc7142ae0182e25b2ae9dce960ee38ab22361 
> 
> Diff: https://reviews.apache.org/r/40545/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ian Babrou
> 
>

Review Request 40545: MESOS-3970: fix cpu usage in mesos ui

2015-11-20 Thread Ian Babrou 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40545/
---

Review request for mesos.


Repository: mesos


Description
---

MESOS-3970: fix cpu usage in mesos ui


Diffs
-

  src/webui/master/static/js/services.js 
d41bc7142ae0182e25b2ae9dce960ee38ab22361 

Diff: https://reviews.apache.org/r/40545/diff/


Testing
---


Thanks,

Ian Babrou