Re: Review Request 41060: Made v1 API in mesos.proto equivalent to non-v1 for 0.26.0.

2015-12-07 Thread Michael Park
> On Dec. 8, 2015, 1 a.m., Michael Park wrote: > > include/mesos/v1/mesos.proto, lines 1507-1508 > > > > > > It looks like we're also missing this from `include/mesos/mesos.proto`? > > ``` > > 1510 // Th

Re: Review Request 41060: Made v1 API in mesos.proto equivalent to non-v1 for 0.26.0.

2015-12-07 Thread Till Toenshoff
> On Dec. 8, 2015, 1 a.m., Michael Park wrote: > > include/mesos/v1/mesos.proto, lines 1507-1508 > > > > > > It looks like we're also missing this from `include/mesos/mesos.proto`? > > ``` > > 1510 // Th

Re: Review Request 41060: Made v1 API in mesos.proto equivalent to non-v1 for 0.26.0.

2015-12-07 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41060/ --- (Updated Dec. 8, 2015, 2:23 a.m.) Review request for mesos, Bernd Mathiske, Ben

Re: Review Request 41060: Made v1 API in mesos.proto equivalent to non-v1 for 0.26.0.

2015-12-07 Thread Till Toenshoff
> On Dec. 8, 2015, 1 a.m., Michael Park wrote: > > include/mesos/v1/mesos.proto, lines 1507-1508 > > > > > > It looks like we're also missing this from `include/mesos/mesos.proto`? > > ``` > > 1510 // Th

Re: Review Request 41060: Made v1 API in mesos.proto equivalent to non-v1 for 0.26.0.

2015-12-07 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41060/ --- (Updated Dec. 8, 2015, 2:06 a.m.) Review request for mesos, Bernd Mathiske, Ben

Re: Review Request 41060: Made v1 API in mesos.proto equivalent to non-v1.

2015-12-07 Thread Till Toenshoff
> On Dec. 8, 2015, 1 a.m., Michael Park wrote: > > include/mesos/v1/mesos.proto, lines 1507-1508 > > > > > > It looks like we're also missing this from `include/mesos/mesos.proto`? > > ``` > > 1510 // Th

Re: Review Request 41060: Made v1 API in mesos.proto equivalent to non-v1.

2015-12-07 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41060/#review109229 --- Ship it! Looks good to me overall! The non-issues are just me leav

Re: Review Request 41060: Made v1 API in mesos.proto equivalent to non-v1.

2015-12-07 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41060/ --- (Updated Dec. 8, 2015, 12:47 a.m.) Review request for mesos, Bernd Mathiske, Be

Re: Review Request 41060: Made v1 API in mesos.proto equivalent to non-v1.

2015-12-07 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41060/ --- (Updated Dec. 8, 2015, 12:24 a.m.) Review request for mesos, Bernd Mathiske, Be

Review Request 41060: Made v1 API in mesos.proto equivalent to non-v1.

2015-12-07 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41060/ --- Review request for mesos, Bernd Mathiske, Ben Mahler, and Joris Van Remoortere.