Re: Review Request 41101: Add documentation about the Mesos "sandbox"

2015-12-08 Thread Joseph Wu 


> On Dec. 8, 2015, 1:35 p.m., Jie Yu wrote:
> > docs/sandbox.md, lines 145-147
> > 
> >
> > Mention that posix/disk isolator needs to be specified in '--isolation' 
> > flag in order to enforce disk quota.

Ah, didn't find that detail.  Thanks!


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41101/#review109396
---


On Dec. 8, 2015, 1:45 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41101/
> ---
> 
> (Updated Dec. 8, 2015, 1:45 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Neil Conway.
> 
> 
> Bugs: MESOS-2782
> https://issues.apache.org/jira/browse/MESOS-2782
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The sandbox holds logs and files that useful for debugging.  This document 
> describes:
> 
> * What the sandbox holds,
> * Where the sandbox is, 
> * How to access the sandbox, and 
> * Some nuances of the sandbox.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 3498368ef2ebdbf814eb4fd2e500461974ed4f13 
>   docs/fetcher.md 8e64341130b551299949a1f5da927f8d9d5725c8 
>   docs/home.md 6ef8a0e21c64042dd79638799da144aecd681151 
>   docs/sandbox.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41101/diff/
> 
> 
> Testing
> ---
> 
> docker build -t mesos/website support/site-docker
> docker run -it --rm -p 4567:4567 -v /path/to/mesos:/mesos mesos/website
> 
> Checked changes visually.  Checked links for correctness.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 41101: Add documentation about the Mesos "sandbox"

2015-12-08 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41101/
---

(Updated Dec. 8, 2015, 1:45 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Neil Conway.


Changes
---

Addressed comments and double-checked visually.


Bugs: MESOS-2782
https://issues.apache.org/jira/browse/MESOS-2782


Repository: mesos


Description
---

The sandbox holds logs and files that useful for debugging.  This document 
describes:

* What the sandbox holds,
* Where the sandbox is, 
* How to access the sandbox, and 
* Some nuances of the sandbox.


Diffs (updated)
-

  docs/configuration.md 3498368ef2ebdbf814eb4fd2e500461974ed4f13 
  docs/fetcher.md 8e64341130b551299949a1f5da927f8d9d5725c8 
  docs/home.md 6ef8a0e21c64042dd79638799da144aecd681151 
  docs/sandbox.md PRE-CREATION 

Diff: https://reviews.apache.org/r/41101/diff/


Testing
---

docker build -t mesos/website support/site-docker
docker run -it --rm -p 4567:4567 -v /path/to/mesos:/mesos mesos/website

Checked changes visually.  Checked links for correctness.


Thanks,

Joseph Wu

Re: Review Request 41101: Add documentation about the Mesos "sandbox"

2015-12-08 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41101/#review109396
---

Ship it!


Awesome!


docs/home.md (line 45)


Can you remove the extra leading space here?



docs/sandbox.md (lines 145 - 147)


Mention that posix/disk isolator needs to be specified in '--isolation' 
flag in order to enforce disk quota.


- Jie Yu


On Dec. 8, 2015, 9:16 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41101/
> ---
> 
> (Updated Dec. 8, 2015, 9:16 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Neil Conway.
> 
> 
> Bugs: MESOS-2782
> https://issues.apache.org/jira/browse/MESOS-2782
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The sandbox holds logs and files that useful for debugging.  This document 
> describes:
> 
> * What the sandbox holds,
> * Where the sandbox is, 
> * How to access the sandbox, and 
> * Some nuances of the sandbox.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 3498368ef2ebdbf814eb4fd2e500461974ed4f13 
>   docs/fetcher.md 8e64341130b551299949a1f5da927f8d9d5725c8 
>   docs/home.md 6ef8a0e21c64042dd79638799da144aecd681151 
>   docs/sandbox.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41101/diff/
> 
> 
> Testing
> ---
> 
> docker build -t mesos/website support/site-docker
> docker run -it --rm -p 4567:4567 -v /path/to/mesos:/mesos mesos/website
> 
> Checked changes visually.  Checked links for correctness.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 41101: Add documentation about the Mesos "sandbox"

2015-12-08 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41101/#review109394
---

Ship it!


Nice work -- this is great!

- Neil Conway


On Dec. 8, 2015, 9:16 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41101/
> ---
> 
> (Updated Dec. 8, 2015, 9:16 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Neil Conway.
> 
> 
> Bugs: MESOS-2782
> https://issues.apache.org/jira/browse/MESOS-2782
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The sandbox holds logs and files that useful for debugging.  This document 
> describes:
> 
> * What the sandbox holds,
> * Where the sandbox is, 
> * How to access the sandbox, and 
> * Some nuances of the sandbox.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 3498368ef2ebdbf814eb4fd2e500461974ed4f13 
>   docs/fetcher.md 8e64341130b551299949a1f5da927f8d9d5725c8 
>   docs/home.md 6ef8a0e21c64042dd79638799da144aecd681151 
>   docs/sandbox.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41101/diff/
> 
> 
> Testing
> ---
> 
> docker build -t mesos/website support/site-docker
> docker run -it --rm -p 4567:4567 -v /path/to/mesos:/mesos mesos/website
> 
> Checked changes visually.  Checked links for correctness.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Review Request 41101: Add documentation about the Mesos "sandbox"

2015-12-08 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41101/
---

Review request for mesos, Artem Harutyunyan, Jie Yu, and Neil Conway.


Bugs: MESOS-2782
https://issues.apache.org/jira/browse/MESOS-2782


Repository: mesos


Description
---

The sandbox holds logs and files that useful for debugging.  This document 
describes:

* What the sandbox holds,
* Where the sandbox is, 
* How to access the sandbox, and 
* Some nuances of the sandbox.


Diffs
-

  docs/configuration.md 3498368ef2ebdbf814eb4fd2e500461974ed4f13 
  docs/fetcher.md 8e64341130b551299949a1f5da927f8d9d5725c8 
  docs/home.md 6ef8a0e21c64042dd79638799da144aecd681151 
  docs/sandbox.md PRE-CREATION 

Diff: https://reviews.apache.org/r/41101/diff/


Testing
---

docker build -t mesos/website support/site-docker
docker run -it --rm -p 4567:4567 -v /path/to/mesos:/mesos mesos/website

Checked changes visually.  Checked links for correctness.


Thanks,

Joseph Wu