Re: Review Request 41178: Fixed a message dropping bug in the health checker.

2015-12-09 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41178/#review109664 --- src/tests/health_check_tests.cpp (line 633)

Review Request 41178: Fixed a message dropping bug in the health checker.

2015-12-09 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41178/ --- Review request for mesos, Artem Harutyunyan and Timothy Chen. Bugs: MESOS-1613

Re: Review Request 41178: Fixed a message dropping bug in the health checker.

2015-12-09 Thread Ben Mahler
> On Dec. 10, 2015, 2:10 a.m., Neil Conway wrote: > > src/tests/health_check_tests.cpp, line 633 > > > > > > Comment needs updating. Thanks for catching this! - Ben

Re: Review Request 41178: Fixed a message dropping bug in the health checker.

2015-12-09 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41178/#review109668 --- Ship it! Ship It! - Artem Harutyunyan On Dec. 9, 2015, 6:01

Re: Review Request 41178: Fixed a message dropping bug in the health checker.

2015-12-09 Thread Ben Mahler
> On Dec. 10, 2015, 2:35 a.m., Artem Harutyunyan wrote: > > src/health-check/main.cpp, line 120 > > > > > > Do we need to create a JIRA for eventually get rid of the hack? Good idea, I filed MESOS-4111 and will