----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41270/#review110008 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On Dec. 11, 2015, 8:04 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41270/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2015, 8:04 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4072 > https://issues.apache.org/jira/browse/MESOS-4072 > > > Repository: mesos > > > Description > ------- > > `CHECK` macros are not appropriate for user-facing error messages. > > > Diffs > ----- > > src/log/replica.cpp 233da166fafc24193740502ec116fe90f3fe1d12 > > Diff: https://reviews.apache.org/r/41270/diff/ > > > Testing > ------- > > Tested error situation and examined resulting error message. > > > Thanks, > > Neil Conway > >
