Re: Review Request 41277: Added environment variables to be used by HTTP executors for connection/retrying disconnections.

2016-01-05 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41277/
---

(Updated Jan. 6, 2016, 1:22 a.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
---

Modified environment variable name for `Backoff` and got rid of other variables.


Bugs: MESOS-3550
https://issues.apache.org/jira/browse/MESOS-3550


Repository: mesos


Description
---

This change adds some environment variables that are used by the HTTP executors 
upon startup for connecting/retrying to the agent. These variables are 
discussed in more detail in the Executor HTTP API Design Doc.


Diffs (updated)
-

  src/slave/containerizer/containerizer.cpp 
dcdf98fea4ca6f96658886db5d09c99f3bff501d 

Diff: https://reviews.apache.org/r/41277/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 41277: Added environment variables to be used by HTTP executors for connection/retrying disconnections.

2015-12-29 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41277/
---

(Updated Dec. 30, 2015, 1:27 a.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
---

Review comments


Bugs: MESOS-3550
https://issues.apache.org/jira/browse/MESOS-3550


Repository: mesos


Description
---

This change adds some environment variables that are used by the HTTP executors 
upon startup for connecting/retrying to the agent. These variables are 
discussed in more detail in the Executor HTTP API Design Doc.


Diffs (updated)
-

  src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 
  src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 
  src/slave/containerizer/containerizer.cpp 
dcdf98fea4ca6f96658886db5d09c99f3bff501d 

Diff: https://reviews.apache.org/r/41277/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 41277: Added environment variables to be used by HTTP executors for connection/retrying disconnections.

2015-12-29 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41277/#review112246
---



src/slave/constants.hpp (lines 124 - 128)


can we make these names consistent with scheduler constants defined in 
sched/constants.cpp?

EXECUTOR_REGISTRATION_BACKOFF_FACTOR

EXECUTOR_REGISTRATION_RETRY_INTERVAL_MAX

alternatively, you can keep these in an executor namespace and get rid of 
the EXECUTOR_ prefix.



src/slave/constants.cpp (line 55)


this variable seems to be unused?



src/slave/containerizer/containerizer.cpp (line 316)


new line.


- Vinod Kone


On Dec. 14, 2015, 11:08 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41277/
> ---
> 
> (Updated Dec. 14, 2015, 11:08 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-3550
> https://issues.apache.org/jira/browse/MESOS-3550
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change adds some environment variables that are used by the HTTP 
> executors upon startup for connecting/retrying to the agent. These variables 
> are discussed in more detail in the Executor HTTP API Design Doc.
> 
> 
> Diffs
> -
> 
>   src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 
>   src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 
>   src/slave/containerizer/containerizer.cpp 
> dcdf98fea4ca6f96658886db5d09c99f3bff501d 
> 
> Diff: https://reviews.apache.org/r/41277/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 41277: Added environment variables to be used by HTTP executors for connection/retrying disconnections.

2015-12-14 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41277/
---

(Updated Dec. 14, 2015, 11:08 p.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Changes
---

Modified CR to only set `MESOS_RETRY_MAX_BACKOFF_FACTOR` when framework 
checkpointing is enabled.


Bugs: MESOS-3550
https://issues.apache.org/jira/browse/MESOS-3550


Repository: mesos


Description
---

This change adds some environment variables that are used by the HTTP executors 
upon startup for connecting/retrying to the agent. These variables are 
discussed in more detail in the Executor HTTP API Design Doc.


Diffs (updated)
-

  src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 
  src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 
  src/slave/containerizer/containerizer.cpp 
dcdf98fea4ca6f96658886db5d09c99f3bff501d 

Diff: https://reviews.apache.org/r/41277/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Review Request 41277: Added environment variables to be used by HTTP executors for connection/retrying disconnections.

2015-12-11 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41277/
---

Review request for mesos, Ben Mahler and Vinod Kone.


Bugs: MESOS-3550
https://issues.apache.org/jira/browse/MESOS-3550


Repository: mesos


Description
---

This change adds some environment variables that are used by the HTTP executors 
upon startup for connecting/retrying to the agent. These variables are 
discussed in more detail in the Executor HTTP API Design Doc.


Diffs
-

  src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 
  src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 
  src/slave/containerizer/containerizer.cpp 
dcdf98fea4ca6f96658886db5d09c99f3bff501d 

Diff: https://reviews.apache.org/r/41277/diff/


Testing
---

make check


Thanks,

Anand Mazumdar