Re: Review Request 41487: Provisioner: Changed docker v2 manifest naming.

2015-12-18 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41487/#review111204 --- Ship it!

Re: Review Request 41487: Provisioner: Changed docker v2 manifest naming.

2015-12-18 Thread Gilbert Song
> On Dec. 18, 2015, 9:16 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/docker/spec.hpp, line 35 > > > > > > s/validateManifest/validate/ This is fixed in https://reviews.apache.org/r/41489/ >

Re: Review Request 41487: Provisioner: Changed docker v2 manifest naming.

2015-12-18 Thread Jie Yu
> On Dec. 18, 2015, 5:16 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/provisioner/docker/spec.hpp, line 35 > > > > > > s/validateManifest/validate/ > > Gilbert Song wrote: > This is fixed in

Re: Review Request 41487: Provisioner: Changed docker v2 manifest naming.

2015-12-18 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41487/ --- (Updated Dec. 18, 2015, 12:10 p.m.) Review request for mesos, Artem

Re: Review Request 41487: Provisioner: Changed docker v2 manifest naming.

2015-12-18 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41487/ --- (Updated Dec. 18, 2015, 1:31 p.m.) Review request for mesos, Artem

Re: Review Request 41487: Provisioner: Changed docker v2 manifest naming.

2015-12-17 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41487/ --- (Updated Dec. 17, 2015, 1:18 a.m.) Review request for mesos, Artem

Re: Review Request 41487: Provisioner: Changed docker v2 manifest naming.

2015-12-17 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41487/#review111024 --- Since you're on it. Can you rename docker::DockerImageManifest to

Review Request 41487: Provisioner: Changed docker v2 manifest naming.

2015-12-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41487/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. Bugs:

Re: Review Request 41487: Provisioner: Changed docker v2 manifest naming.

2015-12-16 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41487/#review110909 --- Ship it! Ship It!