Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

2015-12-31 Thread Gilbert Song
> On Dec. 30, 2015, 6:41 p.m., Jie Yu wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp, line 1614 > > > > > > Why change this test? Because we need to os::write manifest to disk and move it to store

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

2015-12-31 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41491/ --- (Updated Dec. 31, 2015, 3:06 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

2015-12-30 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41491/#review112369 --- src/slave/containerizer/mesos/provisioner/docker/store.cpp (lines

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

2015-12-28 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41491/ --- (Updated Dec. 28, 2015, 3:49 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

2015-12-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41491/#review111321 --- Patch looks great! Reviews applied: [41011, 41125, 41194, 41406, 4

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

2015-12-18 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41491/ --- (Updated Dec. 18, 2015, 1:31 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

2015-12-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41491/#review83 --- Bad patch! Reviews applied: [41011, 41125, 41194, 41406, 41407] F

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

2015-12-18 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41491/ --- (Updated Dec. 18, 2015, 1:21 a.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

2015-12-16 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41491/#review110880 --- Bad patch! Reviews applied: [41011, 41125, 41194, 41406, 41407] F

Review Request 41491: Unified Container: Implemented passing entrypoint in runtime config.

2015-12-16 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41491/ --- Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. Bugs: ME