Re: Review Request 41612: Fixed handling of failed authorization for (un)reserve operations.

2016-01-07 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41612/#review113331
---

Ship it!


Ship It!

- Jie Yu


On Jan. 6, 2016, 8:59 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41612/
> ---
> 
> (Updated Jan. 6, 2016, 8:59 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed handling of failed authorization for (un)reserve operations.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
> 
> Diff: https://reviews.apache.org/r/41612/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 41612: Fixed handling of failed authorization for (un)reserve operations.

2016-01-06 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41612/#review113184
---


Patch looks great!

Reviews applied: [41612]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 6, 2016, 8:59 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41612/
> ---
> 
> (Updated Jan. 6, 2016, 8:59 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed handling of failed authorization for (un)reserve operations.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
> 
> Diff: https://reviews.apache.org/r/41612/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 41612: Fixed handling of failed authorization for (un)reserve operations.

2016-01-06 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41612/
---

(Updated Jan. 6, 2016, 8:59 p.m.)


Review request for mesos, Alexander Rukletsov, Jie Yu, and Michael Park.


Changes
---

Rebase.


Repository: mesos


Description
---

Fixed handling of failed authorization for (un)reserve operations.


Diffs (updated)
-

  src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 

Diff: https://reviews.apache.org/r/41612/diff/


Testing
---

`make check`


Thanks,

Greg Mann



Re: Review Request 41612: Fixed handling of failed authorization for (un)reserve operations.

2015-12-22 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41612/#review111590
---

Ship it!


- Alexander Rukletsov


On Dec. 21, 2015, 7:12 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41612/
> ---
> 
> (Updated Dec. 21, 2015, 7:12 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed handling of failed authorization for (un)reserve operations.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
> 
> Diff: https://reviews.apache.org/r/41612/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 41612: Fixed handling of failed authorization for (un)reserve operations.

2015-12-21 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41612/#review111572
---


Patch looks great!

Reviews applied: [41612]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 21, 2015, 7:12 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41612/
> ---
> 
> (Updated Dec. 21, 2015, 7:12 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed handling of failed authorization for (un)reserve operations.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
> 
> Diff: https://reviews.apache.org/r/41612/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 41612: Fixed handling of failed authorization for (un)reserve operations.

2015-12-21 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41612/#review111552
---

Ship it!


Ship It!

- Guangya Liu


On 十二月 21, 2015, 7:12 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41612/
> ---
> 
> (Updated 十二月 21, 2015, 7:12 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed handling of failed authorization for (un)reserve operations.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 
> 
> Diff: https://reviews.apache.org/r/41612/diff/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Review Request 41612: Fixed handling of failed authorization for (un)reserve operations.

2015-12-21 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41612/
---

Review request for mesos, Alexander Rukletsov, Jie Yu, and Michael Park.


Repository: mesos


Description
---

Fixed handling of failed authorization for (un)reserve operations.


Diffs
-

  src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 

Diff: https://reviews.apache.org/r/41612/diff/


Testing
---

`make check`


Thanks,

Greg Mann