Re: Review Request 41658: Track the allocation candidates to bound the allocation queue.

2016-06-27 Thread Guangya Liu
> On 六月 27, 2016, 12:34 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 534 > > > > > > I think we do not need to insert slave here but only insert slave in > > addSlave and remove sla

Re: Review Request 41658: Track the allocation candidates to bound the allocation queue.

2016-06-27 Thread James Peach
> On June 27, 2016, 12:34 p.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 534 > > > > > > I think we do not need to insert slave here but only insert slave in > > addSlave and remove s

Re: Review Request 41658: Track the allocation candidates to bound the allocation queue.

2016-06-27 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41658/#review111696 --- src/master/allocator/mesos/hierarchical.cpp (line 534)

Re: Review Request 41658: Track the allocation candidates to bound the allocation queue.

2016-06-21 Thread James Peach
> On June 21, 2016, 3:25 p.m., Jiang Yan Xu wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 368 > > > > > > Instead of using a counter I think the following is equivalent but > > simpler: > > > >

Re: Review Request 41658: Track the allocation candidates to bound the allocation queue.

2016-06-21 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41658/ --- (Updated June 22, 2016, 4:32 a.m.) Review request for mesos, Benjamin Mahler an

Re: Review Request 41658: Track the allocation candidates to bound the allocation queue.

2016-06-21 Thread Jiang Yan Xu
> On June 21, 2016, 8:25 a.m., Jiang Yan Xu wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 368 > > > > > > Instead of using a counter I think the following is equivalent but > > simpler: > > > >

Re: Review Request 41658: Track the allocation candidates to bound the allocation queue.

2016-06-21 Thread James Peach
> On June 21, 2016, 3:25 p.m., Jiang Yan Xu wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 368 > > > > > > Instead of using a counter I think the following is equivalent but > > simpler: > > > >

Re: Review Request 41658: Track the allocation candidates to bound the allocation queue.

2016-06-21 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41658/#review138796 --- We recently ran some benchmark and found this is helping with perf

Re: Review Request 41658: Track the allocation candidates to bound the allocation queue.

2015-12-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41658/#review111675 --- Patch looks great! Reviews applied: [41658] Passed command: expor

Review Request 41658: Track the allocation candidates to bound the allocation queue.

2015-12-22 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41658/ --- Review request for mesos, Ben Mahler and Klaus Ma. Bugs: MESOS-3157 https:/