Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated March 8, 2016, 12:47 p.m.) Review request for mesos, Adam B, Neil Conw

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

> On March 8, 2016, 8:07 a.m., Adam B wrote: > > src/master/master.hpp, lines 1040-1042 > > > > > > So if I try to update N roles in one request, but I am not authorized > > to update 1, then I would get back a si

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review122479 --- Fix it, then Ship it! Would love to commit this asap, but we *n

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated March 7, 2016, 12:19 p.m.) Review request for mesos, Adam B, Neil Conw

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Feb. 28, 2016, 10:27 a.m.) Review request for mesos, Adam B, Neil Conw

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review121130 --- Just a couple of suggested comment rewordings, as I've been lookin

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

> On Feb. 19, 2016, 10:24 a.m., Alexander Rukletsov wrote: > > src/master/master.hpp, lines 1530-1531 > > > > > > Let's pull at least the implementation out of the header. You may look > > at maintenance and quota

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

> On Feb. 19, 2016, 2:24 a.m., Alexander Rukletsov wrote: > > src/master/master.hpp, lines 1530-1531 > > > > > > Let's pull at least the implementation out of the header. You may look > > at maintenance and quota

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

> On Feb. 19, 2016, 10:24 a.m., Alexander Rukletsov wrote: > > src/master/master.hpp, lines 1530-1531 > > > > > > Let's pull at least the implementation out of the header. You may look > > at maintenance and quota

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review119857 --- I'd suggest splitting the patch into three parts: authz-related +

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Feb. 14, 2016, 12:02 p.m.) Review request for mesos, Adam B, Neil Conw

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

> On Feb. 9, 2016, 7:07 a.m., Adam B wrote: > > src/master/master.cpp, lines 1560-1561 > > > > > > Can you explain more clearly why this needs to be done? Is it because > > we already initialized the allocator

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review118362 --- I like the reworking of the recover logic, but I'm still unclear a

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 25, 2016, 3:36 p.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 25, 2016, 3:23 p.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

> On Jan. 22, 2016, 9:34 a.m., Adam B wrote: > > src/master/master.hpp, line 1547 > > > > > > It's a shame we can't store the weights as a map in the registry, so we > > don't have to iterate through all the regis

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 24, 2016, 5 a.m.) Review request for mesos, Adam B, Neil Conway,

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review115818 --- src/master/weights_handler.cpp (lines 92 - 94)

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

> On Jan. 20, 2016, 1:51 a.m., Adam B wrote: > > src/master/master.hpp, line 1577 > > > > > > Can it ever return anything but `true`? Are there any error conditions > > at all? > > Yongqiao Wang wrote: > I ha

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review115815 --- Ship it! Looks good except for a handful of nits. Fix these up and

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review115434 --- Patch looks great! Reviews applied: [41597, 41681] Passed command

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

> On Jan. 20, 2016, 9:51 a.m., Adam B wrote: > > src/master/master.hpp, line 1577 > > > > > > Can it ever return anything but `true`? Are there any error conditions > > at all? I have double checked that there ar

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 20, 2016, 2:16 p.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review115379 --- Getting close. Just get rid of the special 1.0 behavior and I'll gi

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 18, 2016, 2:09 p.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 18, 2016, 6:50 a.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 12, 2016, 7:29 a.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 12, 2016, 4:04 a.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 11, 2016, 2:48 p.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 11, 2016, 11:32 a.m.) Review request for mesos, Adam B, Neil Conw

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 9, 2016, 11:37 a.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 9, 2016, 10:24 a.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

> On Jan. 8, 2016, 10:36 a.m., Adam B wrote: > > Here's my first full pass over this patch. Couldn't find anything major > > except the PUT vs. POST question. > > I'll admit I was surprised to see in your testing section that `role1` > > showed up in `/roles` even though it has a default weight

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 8, 2016, 3 p.m.) Review request for mesos, Adam B, Neil Conway, a

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

> On Jan. 8, 2016, 10:36 a.m., Adam B wrote: > > src/master/weights_handler.cpp, lines 97-100 > > > > > > Why the ostringstream here? In order to convert double to string. > On Jan. 8, 2016, 10:36 a.m., Adam B wro

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review113439 --- Here's my first full pass over this patch. Couldn't find anything m

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 6, 2016, 2:15 a.m.) Review request for mesos, Adam B, Neil Conway

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 6, 2016, 2:06 a.m.) Review request for mesos, Adam B, Neil Conway

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 6, 2016, 1:53 a.m.) Review request for mesos, Adam B, Neil Conway

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 5, 2016, 1:40 p.m.) Review request for mesos, Adam B, Neil Conway

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 5, 2016, 12:55 p.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 5, 2016, 12:51 p.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 5, 2016, 11:39 a.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 5, 2016, 7:24 a.m.) Review request for mesos, Adam B, Neil Conway

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 4, 2016, 1:52 p.m.) Review request for mesos, Adam B, Neil Conway

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Jan. 4, 2016, 11:21 a.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Dec. 31, 2015, 11:54 a.m.) Review request for mesos, Adam B, Neil Conw

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review112368 --- src/master/master.cpp (line 1445)

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Dec. 30, 2015, 11:54 a.m.) Review request for mesos, Adam B, Neil Conw

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Dec. 30, 2015, 8:32 a.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Dec. 30, 2015, 8:07 a.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review112188 --- Patch looks great! Reviews applied: [41597, 41681] Passed command

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Dec. 29, 2015, 12:51 p.m.) Review request for mesos, Adam B, Neil Conw

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review112147 --- Patch looks great! Reviews applied: [41597, 41681] Passed command

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Dec. 29, 2015, 9:54 a.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Dec. 29, 2015, 9:03 a.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Dec. 29, 2015, 9 a.m.) Review request for mesos, Adam B, Neil Conway,

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review112132 --- Patch looks great! Reviews applied: [41597, 41681] Passed command

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Dec. 29, 2015, 6:40 a.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review111904 --- Patch looks great! Reviews applied: [41597, 41681] Passed command

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- (Updated Dec. 26, 2015, 2:22 a.m.) Review request for mesos, Adam B, Neil Conwa

Re: Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/#review111770 --- Bad patch! Reviews applied: [41597, 41681] Failed command: ./supp

Review Request 41681: Introduce HTTP endpoint /weights for updating weight.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41681/ --- Review request for mesos, Adam B, Neil Conway, and Qian Zhang. Bugs: MESOS-4214