Re: Review Request 41790: Add tests for /weights endpoint.

2016-03-14 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated March 14, 2016, 10:04 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41790: Add tests for /weights endpoint.

2016-03-14 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review123380 --- src/tests/dynamic_weights_tests.cpp (line 171)

Re: Review Request 41790: Add tests for /weights endpoint.

2016-03-14 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review123358 --- Fix it, then Ship it! Thanks for updating this back to a GET

Re: Review Request 41790: Add tests for /weights endpoint.

2016-03-09 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated March 9, 2016, 9:47 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41790: Add tests for /weights endpoint.

2016-03-09 Thread Yongqiao Wang
> On March 9, 2016, 8:26 a.m., Adam B wrote: > > src/tests/dynamic_weights_tests.cpp, line 89 > > > > > > We don't (yet) use `CHECK_GE/LE/GT/LT` anywhere, I think because we > > want tests themselves to try to be

Re: Review Request 41790: Add tests for /weights endpoint.

2016-03-09 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review122696 --- Looks like you bumped this down in the review chain to come last,

Re: Review Request 41790: Add tests for /weights endpoint.

2016-03-09 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review121134 --- src/tests/dynamic_weights_tests.cpp (line 345)

Re: Review Request 41790: Add tests for /weights endpoint.

2016-03-08 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated March 9, 2016, 5:52 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41790: Add tests for /weights endpoint.

2016-02-28 Thread Yongqiao Wang
> On Feb. 27, 2016, 12:21 p.m., Adam B wrote: > > Sorry this took me forever to get to. Looks pretty good except for some > > indentation and some unnecessary lines. > > I'd also like to see a couple of registrar tests, like AlexR suggested. > > Yongqiao Wang wrote: > Thanks Adam. I will

Re: Review Request 41790: Add tests for /weights endpoint.

2016-02-28 Thread Adam B
> On Feb. 27, 2016, 4:21 a.m., Adam B wrote: > > Sorry this took me forever to get to. Looks pretty good except for some > > indentation and some unnecessary lines. > > I'd also like to see a couple of registrar tests, like AlexR suggested. > > Yongqiao Wang wrote: > Thanks Adam. I will

Re: Review Request 41790: Add tests for /weights endpoint.

2016-02-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review121092 --- Patch looks great! Reviews applied: [41597, 41681, 43863, 41790]

Re: Review Request 41790: Add tests for /weights endpoint.

2016-02-27 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Feb. 27, 2016, 1:55 p.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41790: Add tests for /weights endpoint.

2016-02-27 Thread Yongqiao Wang
> On Feb. 27, 2016, 12:21 p.m., Adam B wrote: > > Sorry this took me forever to get to. Looks pretty good except for some > > indentation and some unnecessary lines. > > I'd also like to see a couple of registrar tests, like AlexR suggested. Thanks Adam. I will add a couple of registrar tests

Re: Review Request 41790: Add tests for /weights endpoint.

2016-02-27 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review121077 --- Sorry this took me forever to get to. Looks pretty good except

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-25 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Jan. 25, 2016, 3:47 p.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-25 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review116141 --- Patch looks great! Reviews applied: [41597, 41681, 41789, 41790]

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-24 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Jan. 25, 2016, 1:51 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review116040 --- Bad patch! Reviews applied: [41597] Failed command:

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-21 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Jan. 21, 2016, 9:57 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-20 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Jan. 21, 2016, 3:08 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-20 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Jan. 20, 2016, 11:13 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review113980 --- Patch looks great! Reviews applied: [41597, 41681, 41789, 41790]

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-11 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Jan. 12, 2016, 7:30 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-11 Thread Yongqiao Wang
> On Jan. 11, 2016, 7:55 a.m., Adam B wrote: > > src/tests/dynamic_weights_tests.cpp, line 329 > > > > > > "specified role"? Which one? You mean WEIGHTS? Yes, I have improved the comments to more clear. > On Jan.

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-11 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Jan. 11, 2016, 2:47 p.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review113810 --- Bad patch! Reviews applied: [41597, 41681, 41789, 41790] Failed

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-10 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review113689 --- A good set of tests for the functionality, but I've got some

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review113678 --- Patch looks great! Reviews applied: [41597, 41681, 41789, 41790]

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-09 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Jan. 9, 2016, 11:38 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review113028 --- Patch looks great! Reviews applied: [41597, 41681, 41789, 41790]

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review112865 --- Patch looks great! Reviews applied: [41597, 41681, 41789, 41790]

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-05 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Jan. 5, 2016, 1:42 p.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-05 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Jan. 6, 2016, 2:07 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review112641 --- Patch looks great! Reviews applied: [41597, 41681, 41789, 41790]

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-04 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Jan. 4, 2016, 11:23 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-04 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Jan. 4, 2016, 11:23 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review112565 --- Bad patch! Reviews applied: [41597] Failed command:

Re: Review Request 41790: Add tests for /weights endpoint.

2016-01-04 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Jan. 4, 2016, 1:53 p.m.) Review request for mesos, Adam B, Neil

Review Request 41790: Add tests for /weights endpoint.

2015-12-30 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- Review request for mesos, Adam B, Neil Conway, and Qian Zhang. Bugs:

Re: Review Request 41790: Add tests for /weights endpoint.

2015-12-30 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Dec. 30, 2015, 11:56 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41790: Add tests for /weights endpoint.

2015-12-30 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Dec. 30, 2015, 10:59 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41790: Add tests for /weights endpoint.

2015-12-30 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/ --- (Updated Dec. 30, 2015, 11:24 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41790: Add tests for /weights endpoint.

2015-12-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review112297 --- Patch looks great! Reviews applied: [41597, 41681, 41789, 41790]

Re: Review Request 41790: Add tests for /weights endpoint.

2015-12-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41790/#review112308 --- Patch looks great! Reviews applied: [41597, 41681, 41789, 41790]