Re: Review Request 41855: [WIP][MESOS-3982] Trace pending executors

2016-01-03 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41855/#review112509
---



src/slave/slave.hpp (line 795)


Add a blank line before 
hashmap pendingExecutors;



src/slave/slave.cpp (line 5240)


It is better add this comment after `Slave::checkAvailabeResource` was 
added.

s/;/.


- Guangya Liu


On Jan. 3, 2016, 1:56 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41855/
> ---
> 
> (Updated Jan. 3, 2016, 1:56 a.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-3982
> https://issues.apache.org/jira/browse/MESOS-3982
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Trace the executor that are not launched; after launching, it's removed from 
> pendingExecutor list.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 
> 
> Diff: https://reviews.apache.org/r/41855/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>



Review Request 41855: [WIP][MESOS-3982] Trace pending executors

2016-01-02 Thread Klaus Ma

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41855/
---

Review request for mesos and Guangya Liu.


Bugs: MESOS-3982
https://issues.apache.org/jira/browse/MESOS-3982


Repository: mesos


Description
---

Trace the executor that are not launched; after launching, it's removed from 
pendingExecutor list.


Diffs
-

  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 

Diff: https://reviews.apache.org/r/41855/diff/


Testing
---


Thanks,

Klaus Ma