Re: Review Request 41856: [WIP][MESOS-3892] Helper functions to get allocation slack

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41856/
---

(Updated Jan. 7, 2016, 11:25 a.m.)


Review request for mesos and Guangya Liu.


Changes
---

Update summary to start with a capital letter.


Summary (updated)
-

[WIP][MESOS-3892] Helper functions to get allocation slack


Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892


Repository: mesos


Description (updated)
---

Helper functions to get allocation slack


Diffs
-

  include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa 
  include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c 
  src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 
  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f 
  src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc 

Diff: https://reviews.apache.org/r/41856/diff/


Testing
---


Thanks,

Klaus Ma

Re: Review Request 41856: [WIP][MESOS-3892] helper functions to get allocation slack

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41856/
---

(Updated Jan. 6, 2016, 11:10 p.m.)


Review request for mesos and Guangya Liu.


Changes
---

rebase


Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892


Repository: mesos


Description
---

helper functions to get allocation slack


Diffs (updated)
-

  include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa 
  include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c 
  src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 
  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f 
  src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc 

Diff: https://reviews.apache.org/r/41856/diff/


Testing
---


Thanks,

Klaus Ma

Re: Review Request 41856: [WIP][MESOS-3892] helper functions to get allocation slack

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41856/#review112512
---



src/slave/slave.hpp (lines 392 - 400)


Can you please explain why not adding some global counters for 
totalAllocationSlack, pendingAllocationSlac, occupiedAllocationSlack etc?



src/slave/slave.hpp (line 399)


It is better add some comments for those helper functions especially for 
eviciting allocation slack which is used to calculate some potential allocation 
slack resources.



src/slave/slave.hpp (line 588)


It is better add more comments to explain this kind of executors.



src/slave/slave.cpp (line 3937)


Why account the queued task here? Does not this handled by 
framework->penging and framework->pendingExecutors?


- Guangya Liu


On Jan. 4, 2016, 5:29 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41856/
> ---
> 
> (Updated Jan. 4, 2016, 5:29 a.m.)
> 
> 
> Review request for mesos and Guangya Liu.
> 
> 
> Bugs: MESOS-3892
> https://issues.apache.org/jira/browse/MESOS-3892
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> helper functions to get allocation slack
> 
> 
> Diffs
> -
> 
>   src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
>   src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 
> 
> Diff: https://reviews.apache.org/r/41856/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Re: Review Request 41856: [WIP][MESOS-3892] helper functions to get allocation slack

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41856/
---

(Updated Jan. 4, 2016, 1:29 p.m.)


Review request for mesos and Guangya Liu.


Changes
---

Add evictingExecutors map


Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892


Repository: mesos


Description
---

helper functions to get allocation slack


Diffs (updated)
-

  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 

Diff: https://reviews.apache.org/r/41856/diff/


Testing
---


Thanks,

Klaus Ma

Review Request 41856: [WIP][MESOS-3892] helper functions to get allocation slack

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41856/
---

Review request for mesos and Guangya Liu.


Bugs: MESOS-3892
https://issues.apache.org/jira/browse/MESOS-3892


Repository: mesos


Description
---

helper functions to get allocation slack


Diffs
-

  src/slave/slave.hpp b7586ce42bfac9d9885a3eb8d82deb94680c236c 
  src/slave/slave.cpp 9d80c96d8e28085c7fa47ce21b9b055c0926d12c 

Diff: https://reviews.apache.org/r/41856/diff/


Testing
---


Thanks,

Klaus Ma