Re: Review Request 41870: [stout] Added ref-qualifiers to Option::get().

[Michael Park]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41870/#review114266
---

Ship it!



3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp (line 108)


Space between `const` and `&`.


- Michael Park


On Jan. 7, 2016, 4:47 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41870/
> ---
> 
> (Updated Jan. 7, 2016, 4:47 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This trivial change adds ref-qualifiers introduced in C++11 to Option::get(). 
> This is in sync with what boost/folly `optional` already have.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
> b58350b312c1969aa86ec679e95af0f97846c141 
> 
> Diff: https://reviews.apache.org/r/41870/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Verified this enables operations like the following to incur a move instead 
> of a copy:
> 
> ```
> Option create();
> T t = create().get();
> ```
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 41870: [stout] Added ref-qualifiers to Option::get().

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41870/
---

(Updated Jan. 13, 2016, 8:11 p.m.)


Review request for mesos, Joris Van Remoortere and Michael Park.


Changes
---

Review comment


Repository: mesos


Description
---

This trivial change adds ref-qualifiers introduced in C++11 to Option::get(). 
This is in sync with what boost/folly `optional` already have.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
b58350b312c1969aa86ec679e95af0f97846c141 

Diff: https://reviews.apache.org/r/41870/diff/


Testing
---

make check

Verified this enables operations like the following to incur a move instead of 
a copy:

```
Option create();
T t = create().get();
```


Thanks,

Anand Mazumdar

Re: Review Request 41870: [stout] Added ref-qualifiers to Option::get().

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41870/#review113236
---


Bad patch!

Reviews applied: [42015, 41870]

Failed command: ./support/apply-review.sh -n -r 41870

Error:
 2016-01-07 11:12:44 URL:https://reviews.apache.org/r/41870/diff/raw/ [915/915] 
-> "41870.patch" [1]
Total errors found: 0
Checking 1 files
Error: Commit message summary (the first line) must start with a capital letter.

- Mesos ReviewBot


On Jan. 7, 2016, 4:47 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41870/
> ---
> 
> (Updated Jan. 7, 2016, 4:47 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This trivial change adds ref-qualifiers introduced in C++11 to Option::get(). 
> This is in sync with what boost/folly `optional` already have.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
> b58350b312c1969aa86ec679e95af0f97846c141 
> 
> Diff: https://reviews.apache.org/r/41870/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Verified this enables operations like the following to incur a move instead 
> of a copy:
> 
> ```
> Option create();
> T t = create().get();
> ```
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 41870: [stout] Added ref-qualifiers to Option::get().

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41870/
---

(Updated Jan. 7, 2016, 4:47 a.m.)


Review request for mesos, Joris Van Remoortere and Michael Park.


Changes
---

Updated review deps.


Repository: mesos


Description
---

This trivial change adds ref-qualifiers introduced in C++11 to Option::get(). 
This is in sync with what boost/folly `optional` already have.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
b58350b312c1969aa86ec679e95af0f97846c141 

Diff: https://reviews.apache.org/r/41870/diff/


Testing
---

make check

Verified this enables operations like the following to incur a move instead of 
a copy:

```
Option create();
T t = create().get();
```


Thanks,

Anand Mazumdar

Re: Review Request 41870: [stout] Added ref-qualifiers to Option::get().

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41870/#review112519
---


Patch looks great!

Reviews applied: [41870]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 4, 2016, 7:09 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41870/
> ---
> 
> (Updated Jan. 4, 2016, 7:09 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This trivial change adds ref-qualifiers introduced in C++11 to Option::get(). 
> This is in sync with what boost/folly `optional` already have.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
> b58350b312c1969aa86ec679e95af0f97846c141 
> 
> Diff: https://reviews.apache.org/r/41870/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Verified this enables operations like the following to incur a move instead 
> of a copy:
> 
> ```
> Option create();
> T t = create().get();
> ```
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 41870: [stout] Added ref-qualifiers to Option::get().

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41870/
---

(Updated Jan. 5, 2016, 6:28 a.m.)


Review request for mesos, Joris Van Remoortere and Michael Park.


Changes
---

Based on MPark's review comments. Left the decision whether or not to make the 
copy upon the user and not the library similar to what Boost `Optional` does.


Repository: mesos


Description
---

This trivial change adds ref-qualifiers introduced in C++11 to Option::get(). 
This is in sync with what boost/folly `optional` already have.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
b58350b312c1969aa86ec679e95af0f97846c141 

Diff: https://reviews.apache.org/r/41870/diff/


Testing
---

make check

Verified this enables operations like the following to incur a move instead of 
a copy:

```
Option create();
T t = create().get();
```


Thanks,

Anand Mazumdar

Re: Review Request 41870: [stout] Added ref-qualifiers to Option::get().

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41870/#review112658
---


Waiting on dev-list e-mail regarding support for gcc 4.8.1 and above, as this 
is not supported in 4.8.0.

- Joris Van Remoortere


On Jan. 4, 2016, 7:09 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41870/
> ---
> 
> (Updated Jan. 4, 2016, 7:09 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This trivial change adds ref-qualifiers introduced in C++11 to Option::get(). 
> This is in sync with what boost/folly `optional` already have.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
> b58350b312c1969aa86ec679e95af0f97846c141 
> 
> Diff: https://reviews.apache.org/r/41870/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> Verified this enables operations like the following to incur a move instead 
> of a copy:
> 
> ```
> Option create();
> T t = create().get();
> ```
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Review Request 41870: [stout] Added ref-qualifiers to Option::get().

[Anand Mazumdar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41870/
---

Review request for mesos, Joris Van Remoortere and Michael Park.


Repository: mesos


Description
---

This trivial change adds ref-qualifiers introduced in C++11 to Option::get(). 
This is in sync with what boost/folly `optional` already have.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp 
b58350b312c1969aa86ec679e95af0f97846c141 

Diff: https://reviews.apache.org/r/41870/diff/


Testing
---

make check

Verified this enables operations like the following to incur a move instead of 
a copy:

```
Option create();
T t = create().get();
```


Thanks,

Anand Mazumdar