Re: Review Request 41880: Removed redundant constructor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41880/#review112737 --- Patch looks great! Reviews applied: [41880] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Jan. 4, 2016, 8:28 p.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41880/ > --- > > (Updated Jan. 4, 2016, 8:28 p.m.) > > > Review request for mesos, Alexander Rukletsov, Till Toenshoff, and Vinod Kone. > > > Bugs: MESOS-4276 > https://issues.apache.org/jira/browse/MESOS-4276 > > > Repository: mesos > > > Description > --- > > Removed redundant constructor. > > > Diffs > - > > include/mesos/v1/scheduler.hpp b3157b953de21e676ef955cf704718ff94132c62 > src/examples/event_call_framework.cpp > c7b4de225bc1731c3fae79b97864d426198cf671 > src/scheduler/scheduler.cpp 797f8c81a45daac77f003793dfca777f482445b8 > src/tests/master_maintenance_tests.cpp > a14435c0e3f44b5a61e2f5a9debd20f4e447491f > > Diff: https://reviews.apache.org/r/41880/diff/ > > > Testing > --- > > make check (Debian8 and OS X 10.10.5) > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 41880: Removed redundant constructor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41880/ --- (Updated Jan. 4, 2016, 8:28 p.m.) Review request for mesos, Alexander Rukletsov, Till Toenshoff, and Vinod Kone. Changes --- Mentioned testing done for posterity. Bugs: MESOS-4276 https://issues.apache.org/jira/browse/MESOS-4276 Repository: mesos Description --- Removed redundant constructor. Diffs - include/mesos/v1/scheduler.hpp b3157b953de21e676ef955cf704718ff94132c62 src/examples/event_call_framework.cpp c7b4de225bc1731c3fae79b97864d426198cf671 src/scheduler/scheduler.cpp 797f8c81a45daac77f003793dfca777f482445b8 src/tests/master_maintenance_tests.cpp a14435c0e3f44b5a61e2f5a9debd20f4e447491f Diff: https://reviews.apache.org/r/41880/diff/ Testing (updated) --- make check (Debian8 and OS X 10.10.5) Thanks, Benjamin Bannier
Re: Review Request 41880: Removed redundant constructor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41880/#review112608 --- Ship it! Ship It! - Vinod Kone On Jan. 4, 2016, 11:28 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41880/ > --- > > (Updated Jan. 4, 2016, 11:28 a.m.) > > > Review request for mesos, Alexander Rukletsov, Till Toenshoff, and Vinod Kone. > > > Bugs: MESOS-4276 > https://issues.apache.org/jira/browse/MESOS-4276 > > > Repository: mesos > > > Description > --- > > Removed redundant constructor. > > > Diffs > - > > include/mesos/v1/scheduler.hpp b3157b953de21e676ef955cf704718ff94132c62 > src/examples/event_call_framework.cpp > c7b4de225bc1731c3fae79b97864d426198cf671 > src/scheduler/scheduler.cpp 797f8c81a45daac77f003793dfca777f482445b8 > src/tests/master_maintenance_tests.cpp > a14435c0e3f44b5a61e2f5a9debd20f4e447491f > > Diff: https://reviews.apache.org/r/41880/diff/ > > > Testing > --- > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 41880: Removed redundant constructor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41880/#review112571 --- Ship it! Ship It! - Guangya Liu On 一月 4, 2016, 11:28 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41880/ > --- > > (Updated 一月 4, 2016, 11:28 a.m.) > > > Review request for mesos, Alexander Rukletsov, Till Toenshoff, and Vinod Kone. > > > Bugs: MESOS-4276 > https://issues.apache.org/jira/browse/MESOS-4276 > > > Repository: mesos > > > Description > --- > > Removed redundant constructor. > > > Diffs > - > > include/mesos/v1/scheduler.hpp b3157b953de21e676ef955cf704718ff94132c62 > src/examples/event_call_framework.cpp > c7b4de225bc1731c3fae79b97864d426198cf671 > src/scheduler/scheduler.cpp 797f8c81a45daac77f003793dfca777f482445b8 > src/tests/master_maintenance_tests.cpp > a14435c0e3f44b5a61e2f5a9debd20f4e447491f > > Diff: https://reviews.apache.org/r/41880/diff/ > > > Testing > --- > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 41880: Removed redundant constructor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41880/#review112568 --- Ship it! Mind mentioning the testing you've done? - Alexander Rukletsov On Jan. 4, 2016, 11:28 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41880/ > --- > > (Updated Jan. 4, 2016, 11:28 a.m.) > > > Review request for mesos, Alexander Rukletsov, Till Toenshoff, and Vinod Kone. > > > Bugs: MESOS-4276 > https://issues.apache.org/jira/browse/MESOS-4276 > > > Repository: mesos > > > Description > --- > > Removed redundant constructor. > > > Diffs > - > > include/mesos/v1/scheduler.hpp b3157b953de21e676ef955cf704718ff94132c62 > src/examples/event_call_framework.cpp > c7b4de225bc1731c3fae79b97864d426198cf671 > src/scheduler/scheduler.cpp 797f8c81a45daac77f003793dfca777f482445b8 > src/tests/master_maintenance_tests.cpp > a14435c0e3f44b5a61e2f5a9debd20f4e447491f > > Diff: https://reviews.apache.org/r/41880/diff/ > > > Testing > --- > > > Thanks, > > Benjamin Bannier > >
Re: Review Request 41880: Removed redundant constructor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41880/#review112542 --- Ship it! Ship It! - Till Toenshoff On Jan. 4, 2016, 10:39 a.m., Benjamin Bannier wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41880/ > --- > > (Updated Jan. 4, 2016, 10:39 a.m.) > > > Review request for mesos, Alexander Rukletsov and Vinod Kone. > > > Bugs: MESOS-4276 > https://issues.apache.org/jira/browse/MESOS-4276 > > > Repository: mesos > > > Description > --- > > Removed redundant constructor. > > > Diffs > - > > include/mesos/v1/scheduler.hpp b3157b953de21e676ef955cf704718ff94132c62 > src/examples/event_call_framework.cpp > c7b4de225bc1731c3fae79b97864d426198cf671 > src/scheduler/scheduler.cpp 797f8c81a45daac77f003793dfca777f482445b8 > src/tests/master_maintenance_tests.cpp > a14435c0e3f44b5a61e2f5a9debd20f4e447491f > > Diff: https://reviews.apache.org/r/41880/diff/ > > > Testing > --- > > > Thanks, > > Benjamin Bannier > >
Review Request 41880: Removed redundant constructor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41880/ --- Review request for mesos, Alexander Rukletsov and Vinod Kone. Bugs: MESOS-4276 https://issues.apache.org/jira/browse/MESOS-4276 Repository: mesos Description --- Removed redundant constructor. Diffs - include/mesos/v1/scheduler.hpp b3157b953de21e676ef955cf704718ff94132c62 src/examples/event_call_framework.cpp c7b4de225bc1731c3fae79b97864d426198cf671 src/scheduler/scheduler.cpp 797f8c81a45daac77f003793dfca777f482445b8 src/tests/master_maintenance_tests.cpp a14435c0e3f44b5a61e2f5a9debd20f4e447491f Diff: https://reviews.apache.org/r/41880/diff/ Testing --- Thanks, Benjamin Bannier
