Re: Review Request 41932: Updated "teardown_framework" requests in the authorizer.

2016-01-21 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41932/#review115598
---

Ship it!


Ship it! I can make this minor change when I commit, so don't worry about it.


src/tests/teardown_tests.cpp (line 188)


s/good ACLs/deprecated (but still good) ACLs,/


- Adam B


On Jan. 21, 2016, 12:52 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41932/
> ---
> 
> (Updated Jan. 21, 2016, 12:52 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4154
> https://issues.apache.org/jira/browse/MESOS-4154
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated "teardown_framework" requests in the authorizer.
> 
> 
> Diffs
> -
> 
>   src/authorizer/local/authorizer.cpp 
> c1db9c2131ea8fbf835278203a240f108c6372c5 
>   src/tests/teardown_tests.cpp d979e07cacd1438e3d44adbe84229020f9159811 
> 
> Diff: https://reviews.apache.org/r/41932/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 41932: Updated "teardown_framework" requests in the authorizer.

2016-01-21 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41932/#review115593
---


Looks great. Create a separate test for shutdown vs. teardown ACLs, and then we 
can Ship It!


src/tests/teardown_tests.cpp (lines 150 - 157)


In this case, you should be testing both ACLs separately, rather than one 
test for a single ACLs message that includes the same policy in both message 
formats.
So how about a TeardownEndpointGoodACLs and a 
TeardownEndpointGoodDeprecatedACLs?


- Adam B


On Jan. 13, 2016, 11:53 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41932/
> ---
> 
> (Updated Jan. 13, 2016, 11:53 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4154
> https://issues.apache.org/jira/browse/MESOS-4154
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated "teardown_framework" requests in the authorizer.
> 
> 
> Diffs
> -
> 
>   src/authorizer/local/authorizer.cpp 
> c1db9c2131ea8fbf835278203a240f108c6372c5 
>   src/tests/teardown_tests.cpp 97cc89ba168aefff8512f6d1a25c4f7ddf180bae 
> 
> Diff: https://reviews.apache.org/r/41932/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 41932: Updated "teardown_framework" requests in the authorizer.

2016-01-21 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41932/
---

(Updated 一月 21, 2016, 8:52 a.m.)


Review request for mesos and Adam B.


Bugs: MESOS-4154
https://issues.apache.org/jira/browse/MESOS-4154


Repository: mesos


Description
---

Updated "teardown_framework" requests in the authorizer.


Diffs (updated)
-

  src/authorizer/local/authorizer.cpp c1db9c2131ea8fbf835278203a240f108c6372c5 
  src/tests/teardown_tests.cpp d979e07cacd1438e3d44adbe84229020f9159811 

Diff: https://reviews.apache.org/r/41932/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 41932: Updated "teardown_framework" requests in the authorizer.

2016-01-13 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41932/
---

(Updated 一月 14, 2016, 7:53 a.m.)


Review request for mesos and Adam B.


Bugs: MESOS-4154
https://issues.apache.org/jira/browse/MESOS-4154


Repository: mesos


Description (updated)
---

Updated "teardown_framework" requests in the authorizer.


Diffs (updated)
-

  src/authorizer/local/authorizer.cpp c1db9c2131ea8fbf835278203a240f108c6372c5 
  src/tests/teardown_tests.cpp 97cc89ba168aefff8512f6d1a25c4f7ddf180bae 

Diff: https://reviews.apache.org/r/41932/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Review Request 41932: Updated "teardown_framework" requests in the authorizer.

2016-01-06 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41932/
---

Review request for mesos and Adam B.


Bugs: MESOS-4154
https://issues.apache.org/jira/browse/MESOS-4154


Repository: mesos


Description
---

See Summary.


Diffs
-

  src/authorizer/local/authorizer.cpp 1d135fb6906c7050a788cbac9ca2d8164ff064ef 
  src/tests/teardown_tests.cpp 97cc89ba168aefff8512f6d1a25c4f7ddf180bae 

Diff: https://reviews.apache.org/r/41932/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 41932: Updated "teardown_framework" requests in the authorizer.

2016-01-06 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41932/#review113076
---


Patch looks great!

Reviews applied: [41933, 41930, 41932]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 6, 2016, 2:36 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41932/
> ---
> 
> (Updated Jan. 6, 2016, 2:36 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4154
> https://issues.apache.org/jira/browse/MESOS-4154
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See Summary.
> 
> 
> Diffs
> -
> 
>   src/authorizer/local/authorizer.cpp 
> 1d135fb6906c7050a788cbac9ca2d8164ff064ef 
>   src/tests/teardown_tests.cpp 97cc89ba168aefff8512f6d1a25c4f7ddf180bae 
> 
> Diff: https://reviews.apache.org/r/41932/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>