Review Request 41933: Updated master help message for acls.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41933/ --- Review request for mesos and Adam B. Bugs: MESOS-4293 https://issues.apache.org/jira/browse/MESOS-4293 Repository: mesos Description --- The ACL messages now moved from mesos.proto to authorizer.proto, the mesos master help message should also be updated to reflect this. Diffs - docs/configuration.md a33e802a3ff1246d25f52b15da7905c5b22e339d src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d Diff: https://reviews.apache.org/r/41933/diff/ Testing --- Thanks, Guangya Liu
Re: Review Request 41933: Updated master help message for acls.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41933/#review112902 --- Patch looks great! Reviews applied: [41933] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Jan. 5, 2016, 3:33 p.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41933/ > --- > > (Updated Jan. 5, 2016, 3:33 p.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-4293 > https://issues.apache.org/jira/browse/MESOS-4293 > > > Repository: mesos > > > Description > --- > > The ACL messages now moved from mesos.proto to authorizer.proto, > the mesos master help message should also be updated to reflect this. > > > Diffs > - > > docs/configuration.md a33e802a3ff1246d25f52b15da7905c5b22e339d > src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d > > Diff: https://reviews.apache.org/r/41933/diff/ > > > Testing > --- > > > Thanks, > > Guangya Liu > >
Re: Review Request 41933: Updated master help message for acls.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41933/ --- (Updated 一月 6, 2016, 3:37 a.m.) Review request for mesos and Adam B. Changes --- Rebase Bugs: MESOS-4293 https://issues.apache.org/jira/browse/MESOS-4293 Repository: mesos Description (updated) --- The ACL messages now moved from mesos.proto to authorizer.proto, the mesos master help message and authorization.md should also be updated to reflect this. Diffs (updated) - docs/authorization.md 900922855723581f4f7b77ecbc2fd3dbbd33e572 src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d Diff: https://reviews.apache.org/r/41933/diff/ Testing --- Thanks, Guangya Liu
Re: Review Request 41933: Updated master help message for acls.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41933/#review112966 --- Thanks for noticing and fixing this. - You missed a couple of references in authorization.md as well though. Could you fix those too? - Adam B On Jan. 5, 2016, 7:33 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41933/ > --- > > (Updated Jan. 5, 2016, 7:33 a.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-4293 > https://issues.apache.org/jira/browse/MESOS-4293 > > > Repository: mesos > > > Description > --- > > The ACL messages now moved from mesos.proto to authorizer.proto, > the mesos master help message should also be updated to reflect this. > > > Diffs > - > > docs/configuration.md a33e802a3ff1246d25f52b15da7905c5b22e339d > src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d > > Diff: https://reviews.apache.org/r/41933/diff/ > > > Testing > --- > > > Thanks, > > Guangya Liu > >
Re: Review Request 41933: Updated master help message for acls.
> On Jan. 5, 2016, 4:06 p.m., Adam B wrote: > > Thanks for noticing and fixing this. > > - You missed a couple of references in authorization.md as well though. > > Could you fix those too? (probably need a rebase after Greg's recent change to configuration.md) - Adam --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41933/#review112966 --- On Jan. 5, 2016, 7:33 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41933/ > --- > > (Updated Jan. 5, 2016, 7:33 a.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-4293 > https://issues.apache.org/jira/browse/MESOS-4293 > > > Repository: mesos > > > Description > --- > > The ACL messages now moved from mesos.proto to authorizer.proto, > the mesos master help message should also be updated to reflect this. > > > Diffs > - > > docs/configuration.md a33e802a3ff1246d25f52b15da7905c5b22e339d > src/master/flags.cpp 800e54a302386f26f9b2f21edacad8840abbb42d > > Diff: https://reviews.apache.org/r/41933/diff/ > > > Testing > --- > > > Thanks, > > Guangya Liu > >
