Re: Review Request 41989: Added docs for persistent volume endpoint authorization.

2016-01-07 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41989/#review11
---

Ship it!


Ship It!

- Jie Yu


On Jan. 6, 2016, 8:51 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41989/
> ---
> 
> (Updated Jan. 6, 2016, 8:51 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-3903
> https://issues.apache.org/jira/browse/MESOS-3903
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added docs for persistent volume endpoint authorization.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md 6375c9ad26c0996de14909664e71f80167992a09 
>   docs/persistent-volume.md 766e62a497558692f3df89a0e666c9d96c6c0fcb 
> 
> Diff: https://reviews.apache.org/r/41989/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 41989: Added docs for persistent volume endpoint authorization.

2016-01-07 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41989/#review113233
---


Patch looks great!

Reviews applied: [41934, 41935, 41989]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 6, 2016, 8:51 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41989/
> ---
> 
> (Updated Jan. 6, 2016, 8:51 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-3903
> https://issues.apache.org/jira/browse/MESOS-3903
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added docs for persistent volume endpoint authorization.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md 6375c9ad26c0996de14909664e71f80167992a09 
>   docs/persistent-volume.md 766e62a497558692f3df89a0e666c9d96c6c0fcb 
> 
> Diff: https://reviews.apache.org/r/41989/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 41989: Added docs for persistent volume endpoint authorization.

2016-01-06 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41989/#review113176
---



docs/persistent-volume.md (line 33)


move this to above line?


- Guangya Liu


On 一月 6, 2016, 8:51 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41989/
> ---
> 
> (Updated 一月 6, 2016, 8:51 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-3903
> https://issues.apache.org/jira/browse/MESOS-3903
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added docs for persistent volume endpoint authorization.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md 6375c9ad26c0996de14909664e71f80167992a09 
>   docs/persistent-volume.md 766e62a497558692f3df89a0e666c9d96c6c0fcb 
> 
> Diff: https://reviews.apache.org/r/41989/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 41989: Added docs for persistent volume endpoint authorization.

2016-01-06 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41989/
---

(Updated Jan. 6, 2016, 8:51 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Rebase.


Bugs: MESOS-3903
https://issues.apache.org/jira/browse/MESOS-3903


Repository: mesos


Description
---

Added docs for persistent volume endpoint authorization.


Diffs (updated)
-

  docs/authorization.md 6375c9ad26c0996de14909664e71f80167992a09 
  docs/persistent-volume.md 766e62a497558692f3df89a0e666c9d96c6c0fcb 

Diff: https://reviews.apache.org/r/41989/diff/


Testing
---


Thanks,

Greg Mann

Re: Review Request 41989: Added docs for persistent volume endpoint authorization.

2016-01-06 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41989/#review113132
---


Bad patch!

Reviews applied: [41934, 41935, 41989]

Failed command: ./support/apply-review.sh -n -r 41989

Error:
 2016-01-06 20:33:11 URL:https://reviews.apache.org/r/41989/diff/raw/ 
[2094/2094] -> "41989.patch" [1]
error: patch failed: docs/authorization.md:11
error: docs/authorization.md: patch does not apply

- Mesos ReviewBot


On Jan. 6, 2016, 6:09 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41989/
> ---
> 
> (Updated Jan. 6, 2016, 6:09 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-3903
> https://issues.apache.org/jira/browse/MESOS-3903
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added docs for persistent volume endpoint authorization.
> 
> 
> Diffs
> -
> 
>   docs/authorization.md 900922855723581f4f7b77ecbc2fd3dbbd33e572 
>   docs/persistent-volume.md 766e62a497558692f3df89a0e666c9d96c6c0fcb 
> 
> Diff: https://reviews.apache.org/r/41989/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 41989: Added docs for persistent volume endpoint authorization.

2016-01-06 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41989/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-3903
https://issues.apache.org/jira/browse/MESOS-3903


Repository: mesos


Description
---

Added docs for persistent volume endpoint authorization.


Diffs
-

  docs/authorization.md 900922855723581f4f7b77ecbc2fd3dbbd33e572 
  docs/persistent-volume.md 766e62a497558692f3df89a0e666c9d96c6c0fcb 

Diff: https://reviews.apache.org/r/41989/diff/


Testing
---


Thanks,

Greg Mann