Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

2016-07-09 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/#review141565
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Feb. 28, 2016, 2:14 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42100/
> ---
> 
> (Updated Feb. 28, 2016, 2:14 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-4258
> https://issues.apache.org/jira/browse/MESOS-4258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the jenkins build script to copy out xml testing reports.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
>   support/gitignore 90b6697d19a5e0a68805b23b587b362731a1df25 
> 
> Diff: https://reviews.apache.org/r/42100/diff/
> 
> 
> Testing
> ---
> 
> On ubuntu 14.04 64bit machine: 
> 
> ``` sh
> $ cd /path/to/mesos
> $ export OS=ubuntu:14.04 CONFIGURATION=--verbose COMPILER=gcc 
> ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'
> $ ./support/docker_build.sh
> $ ls -1 *.xml
> libprocess-tests.xml
> lt-mesos-tests.xml
> stout-tests.xml
> ```
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

2016-02-28 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/#review121147
---



Patch looks great!

Reviews applied: [42100]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 28, 2016, 2:14 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42100/
> ---
> 
> (Updated Feb. 28, 2016, 2:14 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4258
> https://issues.apache.org/jira/browse/MESOS-4258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the jenkins build script to copy out xml testing reports.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
>   support/gitignore 90b6697d19a5e0a68805b23b587b362731a1df25 
> 
> Diff: https://reviews.apache.org/r/42100/diff/
> 
> 
> Testing
> ---
> 
> On ubuntu 14.04 64bit machine: 
> 
> ``` sh
> $ cd /path/to/mesos
> $ export OS=ubuntu:14.04 CONFIGURATION=--verbose COMPILER=gcc 
> ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'
> $ ./support/docker_build.sh
> $ ls -1 *.xml
> libprocess-tests.xml
> lt-mesos-tests.xml
> stout-tests.xml
> ```
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

2016-02-28 Thread Shuai Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/
---

(Updated Feb. 28, 2016, 2:14 p.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-4258
https://issues.apache.org/jira/browse/MESOS-4258


Repository: mesos


Description
---

Updated the jenkins build script to copy out xml testing reports.


Diffs (updated)
-

  support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
  support/gitignore 90b6697d19a5e0a68805b23b587b362731a1df25 

Diff: https://reviews.apache.org/r/42100/diff/


Testing (updated)
---

On ubuntu 14.04 64bit machine: 

``` sh
$ cd /path/to/mesos
$ export OS=ubuntu:14.04 CONFIGURATION=--verbose COMPILER=gcc 
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'
$ ./support/docker_build.sh
$ ls -1 *.xml
libprocess-tests.xml
lt-mesos-tests.xml
stout-tests.xml
```


Thanks,

Shuai Lin

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

2016-02-28 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/#review121144
---



Patch looks great!

Reviews applied: [42100]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 28, 2016, 12:57 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42100/
> ---
> 
> (Updated Feb. 28, 2016, 12:57 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4258
> https://issues.apache.org/jira/browse/MESOS-4258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the jenkins build script to copy out xml testing reports.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
>   support/gitignore 90b6697d19a5e0a68805b23b587b362731a1df25 
> 
> Diff: https://reviews.apache.org/r/42100/diff/
> 
> 
> Testing
> ---
> 
> On ubuntu 14.04 64bit machine: 
> 
> ``` sh
> $ cd /path/to/mesos
> $ export OS=ubuntu:14.04 CONFIGURATION=--verbose COMPILER=gcc 
> ENVIRONMENT=GLOG_v=1 MESOS_VERBOSE=1
> $ ./support/docker_build.sh
> $ ls -1 *.xml
> libprocess-tests.xml
> mesos-tests.xml
> stout-tests.xml
> ```
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

2016-02-28 Thread Shuai Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/
---

(Updated Feb. 28, 2016, 12:57 p.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-4258
https://issues.apache.org/jira/browse/MESOS-4258


Repository: mesos


Description
---

Updated the jenkins build script to copy out xml testing reports.


Diffs
-

  support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
  support/gitignore 90b6697d19a5e0a68805b23b587b362731a1df25 

Diff: https://reviews.apache.org/r/42100/diff/


Testing (updated)
---

On ubuntu 14.04 64bit machine: 

``` sh
$ cd /path/to/mesos
$ export OS=ubuntu:14.04 CONFIGURATION=--verbose COMPILER=gcc 
ENVIRONMENT=GLOG_v=1 MESOS_VERBOSE=1
$ ./support/docker_build.sh
$ ls -1 *.xml
libprocess-tests.xml
mesos-tests.xml
stout-tests.xml
```


Thanks,

Shuai Lin

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

2016-02-28 Thread Shuai Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/
---

(Updated Feb. 28, 2016, 12:57 p.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-4258
https://issues.apache.org/jira/browse/MESOS-4258


Repository: mesos


Description
---

Updated the jenkins build script to copy out xml testing reports.


Diffs
-

  support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
  support/gitignore 90b6697d19a5e0a68805b23b587b362731a1df25 

Diff: https://reviews.apache.org/r/42100/diff/


Testing (updated)
---

On ubuntu 14.04 64:

``` sh
$ cd /path/to/mesos
$ export OS=ubuntu:14.04 CONFIGURATION=--verbose COMPILER=gcc 
ENVIRONMENT=GLOG_v=1 MESOS_VERBOSE=1
$ ./support/docker_build.sh
$ ls -1 *.xml
libprocess-tests.xml
mesos-tests.xml
stout-tests.xml
```


Thanks,

Shuai Lin

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

2016-02-28 Thread Shuai Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/
---

(Updated Feb. 28, 2016, 12:55 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

Update the script after testing && address comment reviews.


Bugs: MESOS-4258
https://issues.apache.org/jira/browse/MESOS-4258


Repository: mesos


Description
---

Updated the jenkins build script to copy out xml testing reports.


Diffs (updated)
-

  support/docker_build.sh e9b1d7219b261475fb29118ee27d11743c2c5e0d 
  support/gitignore 90b6697d19a5e0a68805b23b587b362731a1df25 

Diff: https://reviews.apache.org/r/42100/diff/


Testing
---

On ubuntu 14.04 64:

```
export OS=ubuntu:14.04 CONFIGURATION=--verbose COMPILER=gcc 
ENVIRONMENT=GLOG_v=1 MESOS_VERBOSE=1
./support/docker_build.sh
```


Thanks,

Shuai Lin

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

2016-02-24 Thread Shuai Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/
---

(Updated Feb. 25, 2016, 2:02 a.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-4258
https://issues.apache.org/jira/browse/MESOS-4258


Repository: mesos


Description
---

Updated the jenkins build script to copy out xml testing reports.


Diffs
-

  support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 

Diff: https://reviews.apache.org/r/42100/diff/


Testing (updated)
---

On ubuntu 14.04 64:

```
export OS=ubuntu:14.04 CONFIGURATION=--verbose COMPILER=gcc 
ENVIRONMENT=GLOG_v=1 MESOS_VERBOSE=1
./support/docker_build.sh
```


Thanks,

Shuai Lin

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

2016-02-24 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/#review120572
---



Have you tested this change? Please explain in the "Testing done" section.


support/docker_build.sh (line 125)


lets just call this function cleanup().


- Vinod Kone


On Jan. 17, 2016, 6:49 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42100/
> ---
> 
> (Updated Jan. 17, 2016, 6:49 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4258
> https://issues.apache.org/jira/browse/MESOS-4258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the jenkins build script to copy out xml testing reports.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 
> 
> Diff: https://reviews.apache.org/r/42100/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

2016-01-16 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/#review114896
---


Thanks! Just a small comment below.


support/docker_build.sh (lines 125 - 135)


Are you sure that this doesn't over-write the period trap?


http://stackoverflow.com/questions/3338030/multiple-bash-traps-for-the-same-signal


- Ben Mahler


On Jan. 9, 2016, 2:38 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42100/
> ---
> 
> (Updated Jan. 9, 2016, 2:38 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4258
> https://issues.apache.org/jira/browse/MESOS-4258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the jenkins build script to copy out xml testing reports.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 
> 
> Diff: https://reviews.apache.org/r/42100/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

2016-01-16 Thread Shuai Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/
---

(Updated Jan. 17, 2016, 6:48 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

put all trap handlers in the same function


Bugs: MESOS-4258
https://issues.apache.org/jira/browse/MESOS-4258


Repository: mesos


Description (updated)
---

Review: https://reviews.apache.org/r/42100


Diffs (updated)
-

  support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 

Diff: https://reviews.apache.org/r/42100/diff/


Testing
---


Thanks,

Shuai Lin

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

2016-01-16 Thread Shuai Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/
---

(Updated Jan. 17, 2016, 6:49 a.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-4258
https://issues.apache.org/jira/browse/MESOS-4258


Repository: mesos


Description (updated)
---

Updated the jenkins build script to copy out xml testing reports.


Diffs
-

  support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 

Diff: https://reviews.apache.org/r/42100/diff/


Testing
---


Thanks,

Shuai Lin

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

2016-01-16 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/#review114898
---


Patch looks great!

Reviews applied: [42100]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 17, 2016, 6:49 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42100/
> ---
> 
> (Updated Jan. 17, 2016, 6:49 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4258
> https://issues.apache.org/jira/browse/MESOS-4258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the jenkins build script to copy out xml testing reports.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 
> 
> Diff: https://reviews.apache.org/r/42100/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

2016-01-10 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/#review113669
---


Patch looks great!

Reviews applied: [42100]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 9, 2016, 2:38 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42100/
> ---
> 
> (Updated Jan. 9, 2016, 2:38 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4258
> https://issues.apache.org/jira/browse/MESOS-4258
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated the jenkins build script to copy out xml testing reports.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 
> 
> Diff: https://reviews.apache.org/r/42100/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Review Request 42100: Updated the jenkins build script to copy out xml testing reports.

2016-01-08 Thread Shuai Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42100/
---

Review request for mesos and Ben Mahler.


Bugs: MESOS-4258
https://issues.apache.org/jira/browse/MESOS-4258


Repository: mesos


Description
---

Updated the jenkins build script to copy out xml testing reports.


Diffs
-

  support/docker_build.sh da94be87fae98825e60331634259eab0e7a4ebd1 

Diff: https://reviews.apache.org/r/42100/diff/


Testing
---


Thanks,

Shuai Lin