Re: Review Request 42113: WIP: Handle unreserve logic for dynamic reservation (2/3).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42113/ --- (Updated 一月 13, 2016, 9:03 a.m.) Review request for mesos and Klaus Ma. Summary (updated) - WIP: Handle unreserve logic for dynamic reservation (2/3). Repository: mesos Description --- Handle unreserve logic for dynamic reservation with allocation slack. This patch is halding the case when using updateAllocation to unreserve some resources. Diffs (updated) - src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f src/tests/hierarchical_allocator_tests.cpp e044f832c2c16e53e663c6ced5452649bb0dcb59 Diff: https://reviews.apache.org/r/42113/diff/ Testing --- make make check Thanks, Guangya Liu
Re: Review Request 42113: WIP: Handle unreserve logic for dynamic reservation (1/2).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42113/ --- (Updated 一月 12, 2016, 2:55 p.m.) Review request for mesos and Klaus Ma. Summary (updated) - WIP: Handle unreserve logic for dynamic reservation (1/2). Repository: mesos Description (updated) --- Handle unreserve logic for dynamic reservation with allocation slack. This patch is halding the case when using updateAllocation to unreserve some resources. Diffs (updated) - include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c src/cli/execute.cpp a2b610f32da3deb9d3df99c225d22a425e03cdba src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f src/master/master.cpp 2d9b7f9540574aa3ef9e5af3b2b8922dffeebac8 src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f src/tests/hierarchical_allocator_tests.cpp e044f832c2c16e53e663c6ced5452649bb0dcb59 src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc Diff: https://reviews.apache.org/r/42113/diff/ Testing --- make make check Thanks, Guangya Liu
Re: Review Request 42113: WIP: Handle unreserve logic for dynamic reservation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42113/#review113748 --- Patch looks great! Reviews applied: [40375, 41334, 41333, 40529, 41772, 40339, 40632, 41847, 41791, 42113] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Jan. 11, 2016, 1:35 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42113/ > --- > > (Updated Jan. 11, 2016, 1:35 a.m.) > > > Review request for mesos and Klaus Ma. > > > Repository: mesos > > > Description > --- > > Handle unreserve logic for dynamic reservation with allocation slack. > > This will be split to two patches for updateAllocation and updateAvailable > with unit test enabled. > > > Diffs > - > > include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa > include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c > src/cli/execute.cpp a2b610f32da3deb9d3df99c225d22a425e03cdba > src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 > src/master/allocator/mesos/hierarchical.cpp > df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f > src/master/master.cpp 2d9b7f9540574aa3ef9e5af3b2b8922dffeebac8 > src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f > src/tests/hierarchical_allocator_tests.cpp > e044f832c2c16e53e663c6ced5452649bb0dcb59 > src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 > src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc > > Diff: https://reviews.apache.org/r/42113/diff/ > > > Testing > --- > > make > make check > > > Thanks, > > Guangya Liu > >
Review Request 42113: WIP: Handle unreserve logic for dynamic reservation.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42113/ --- Review request for mesos and Klaus Ma. Repository: mesos Description --- Handle unreserve logic for dynamic reservation with allocation slack. This will be split to two patches for updateAllocation and updateAvailable with unit test enabled. Diffs - include/mesos/resources.hpp cc8fef9470d779078aa408ed03e747e5a492deaa include/mesos/v1/resources.hpp f4892977f8d7b0439db6e9cf7921334f606a496c src/cli/execute.cpp a2b610f32da3deb9d3df99c225d22a425e03cdba src/common/resources.cpp 6afd2dfd81adecf7bdb3e523bc840efb62b79ef4 src/master/allocator/mesos/hierarchical.cpp df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f src/master/master.cpp 2d9b7f9540574aa3ef9e5af3b2b8922dffeebac8 src/slave/slave.cpp 90d0fecd2d83fd174134870a577ac59d79c0006f src/tests/hierarchical_allocator_tests.cpp e044f832c2c16e53e663c6ced5452649bb0dcb59 src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 src/v1/resources.cpp 8de6672ba9b34947db81c74b8e03e8965e8af5fc Diff: https://reviews.apache.org/r/42113/diff/ Testing --- make make check Thanks, Guangya Liu
