Re: Review Request 42127: Did not rescind offer if only ALLOCATION_SLACK resources incuded.

2016-03-10 Thread Klaus Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42127/
---

(Updated March 11, 2016, 3:13 p.m.)


Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van 
Remoortere, Joseph Wu, and Jian Qiu.


Changes
---

rebase


Bugs: MESOS-4320
https://issues.apache.org/jira/browse/MESOS-4320


Repository: mesos


Description
---

Did not rescind offer if only ALLOCATION_SLACK resources incuded.


Diffs (updated)
-

  src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc 
  src/tests/oversubscription_tests.cpp e528476cd83b0e3f7ae8cea7d86dfabc1f66484e 

Diff: https://reviews.apache.org/r/42127/diff/


Testing
---

make
make check


Thanks,

Klaus Ma

Review Request 42127: Did not rescind offer if only ALLOCATION_SLACK resources incuded.

2016-01-10 Thread Klaus Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42127/
---

Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris Van 
Remoortere, Joseph Wu, and Jian Qiu.


Bugs: MESOS-4320
https://issues.apache.org/jira/browse/MESOS-4320


Repository: mesos


Description
---

Did not rescind offer if only ALLOCATION_SLACK resources incuded.


Diffs
-

  src/master/master.cpp 2d9b7f9540574aa3ef9e5af3b2b8922dffeebac8 
  src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a 

Diff: https://reviews.apache.org/r/42127/diff/


Testing
---

make
make check


Thanks,

Klaus Ma

Re: Review Request 42127: Did not rescind offer if only ALLOCATION_SLACK resources incuded.

2016-01-10 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42127/#review113688
---



src/master/master.cpp (line 4654)


Comments needs to be updated.



src/master/master.cpp (line 4660)


Log needs to be updated.


- Guangya Liu


On 一月 11, 2016, 5:51 a.m., Klaus Ma wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42127/
> ---
> 
> (Updated 一月 11, 2016, 5:51 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Guangya Liu, Artem Harutyunyan, Joris 
> Van Remoortere, Joseph Wu, and Jian Qiu.
> 
> 
> Bugs: MESOS-4320
> https://issues.apache.org/jira/browse/MESOS-4320
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Did not rescind offer if only ALLOCATION_SLACK resources incuded.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 2d9b7f9540574aa3ef9e5af3b2b8922dffeebac8 
>   src/tests/oversubscription_tests.cpp 
> 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a 
> 
> Diff: https://reviews.apache.org/r/42127/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>