Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-14 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42212/
---

(Updated Jan. 14, 2016, 4:11 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

This change attempts to address all of the issues brought up by bmahler 
mentioned previously.


Bugs: MESOS-3307
https://issues.apache.org/jira/browse/MESOS-3307


Repository: mesos


Description (updated)
---

This commit adds a unit test to verify that the the max_frameworks and
max_tasks_per_frameworks flags for master work properly. Specifically,
we test to verify that the proper amount of history is maintained for
both 0 values to these flags as well as positive values <= to the total
number of frameworks and tasks per framework actually launched.


Diffs (updated)
-

  src/tests/master_tests.cpp 223b9d20a3a8a8194a3a6a605ec2394c37ab5957 

Diff: https://reviews.apache.org/r/42212/diff/


Testing (updated)
---

This is a unit test.  I ran it on my mac and on ubuntu 14.04.

GTEST_FILTER="MasterTest.MaxCompletedTasksPerFrameworkFlag:MasterTest.MaxCompletedFrameworksFlag"
 make check -j 7


Thanks,

Kevin Klues

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-14 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42212/#review114633
---


Patch looks great!

Reviews applied: [42053, 42212]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 15, 2016, 12:49 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42212/
> ---
> 
> (Updated Jan. 15, 2016, 12:49 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3307
> https://issues.apache.org/jira/browse/MESOS-3307
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit adds a unit test to verify that the the max_frameworks and
> max_tasks_per_frameworks flags for master work properly. Specifically,
> we test to verify that the proper amount of history is maintained for
> both 0 values to these flags as well as positive values <= to the total
> number of frameworks and tasks per framework actually launched.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 9638fb867b07f85a02d3b78f8282843d8871cabe 
> 
> Diff: https://reviews.apache.org/r/42212/diff/
> 
> 
> Testing
> ---
> 
> This is a unit test.  I ran it on my mac and on ubuntu 14.04.
> 
> GTEST_FILTER="MasterTest.MaxCompletedTasksPerFrameworkFlag:MasterTest.MaxCompletedFrameworksFlag"
>  make check -j 7
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-14 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42212/
---

(Updated Jan. 15, 2016, 12:49 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

Address bmahler's comments.


Bugs: MESOS-3307
https://issues.apache.org/jira/browse/MESOS-3307


Repository: mesos


Description
---

This commit adds a unit test to verify that the the max_frameworks and
max_tasks_per_frameworks flags for master work properly. Specifically,
we test to verify that the proper amount of history is maintained for
both 0 values to these flags as well as positive values <= to the total
number of frameworks and tasks per framework actually launched.


Diffs (updated)
-

  src/tests/master_tests.cpp 9638fb867b07f85a02d3b78f8282843d8871cabe 

Diff: https://reviews.apache.org/r/42212/diff/


Testing
---

This is a unit test.  I ran it on my mac and on ubuntu 14.04.

GTEST_FILTER="MasterTest.MaxCompletedTasksPerFrameworkFlag:MasterTest.MaxCompletedFrameworksFlag"
 make check -j 7


Thanks,

Kevin Klues

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-14 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42212/#review114599
---


These issues ae based on offline discussions with bmahler.


src/tests/master_tests.cpp (line 23)


Remove in favor of stringify.hpp in stout



src/tests/master_tests.cpp (line 3964)


The array is now below, not above.



src/tests/master_tests.cpp (line 3965)


The only real interesting cases here are with maxFrameworksArray = {0, 1, 
and 2}, with totalFrameworks = 2. This covers the case of maxFramworks == 0, 
something <= to the totalFrameworks launched, and something == to the total 
frameworks launched.  There is no need to go all the way up to the default, 
which may be raised in the future and cause things to slow down.



src/tests/master_tests.cpp (line 3987)


Remove these obvious comments. Only add comments where the code itself is a 
little unclear in what it's doing.



src/tests/master_tests.cpp (line 4023)


replace get() with -> as before.



src/tests/master_tests.cpp (line 4052)


Array is now below.



src/tests/master_tests.cpp (line 4059)


Also, change this to only cover 0,1,2 cases as above.



src/tests/master_tests.cpp (line 4148)


ditto as above


- Kevin Klues


On Jan. 14, 2016, 4:11 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42212/
> ---
> 
> (Updated Jan. 14, 2016, 4:11 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3307
> https://issues.apache.org/jira/browse/MESOS-3307
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit adds a unit test to verify that the the max_frameworks and
> max_tasks_per_frameworks flags for master work properly. Specifically,
> we test to verify that the proper amount of history is maintained for
> both 0 values to these flags as well as positive values <= to the total
> number of frameworks and tasks per framework actually launched.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 223b9d20a3a8a8194a3a6a605ec2394c37ab5957 
> 
> Diff: https://reviews.apache.org/r/42212/diff/
> 
> 
> Testing
> ---
> 
> This is a unit test.  I ran it on my mac and on ubuntu 14.04.
> 
> GTEST_FILTER="MasterTest.MaxCompletedTasksPerFrameworkFlag:MasterTest.MaxCompletedFrameworksFlag"
>  make check -j 7
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-14 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42212/#review114615
---



src/tests/master_tests.cpp (line 4032)


One more comment from bmahler.  In general, EXPECT_* and ASSERT_* lines 
tend to be separated from the logic that precedes them in order to make them 
pop more.  Exceptions exist when it's clear that we are asserting the existence 
of something just after creating it, but for most things, we should be more 
liberal with our white space.


- Kevin Klues


On Jan. 14, 2016, 4:11 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42212/
> ---
> 
> (Updated Jan. 14, 2016, 4:11 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3307
> https://issues.apache.org/jira/browse/MESOS-3307
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit adds a unit test to verify that the the max_frameworks and
> max_tasks_per_frameworks flags for master work properly. Specifically,
> we test to verify that the proper amount of history is maintained for
> both 0 values to these flags as well as positive values <= to the total
> number of frameworks and tasks per framework actually launched.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 223b9d20a3a8a8194a3a6a605ec2394c37ab5957 
> 
> Diff: https://reviews.apache.org/r/42212/diff/
> 
> 
> Testing
> ---
> 
> This is a unit test.  I ran it on my mac and on ubuntu 14.04.
> 
> GTEST_FILTER="MasterTest.MaxCompletedTasksPerFrameworkFlag:MasterTest.MaxCompletedFrameworksFlag"
>  make check -j 7
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-14 Thread Ben Mahler 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42212/#review114672
---

Ship it!


Very nice! I'll make some minor adjustments based on the comments and get this 
committed for you.


src/tests/master_tests.cpp (lines 3921 - 3939)


I tried to consolidate these comments by pulling down the parts of the test 
level comment into the test body:

```
// Test the max_completed_framework flag for master.
TEST_F(MasterTest, MaxCompletedTasksPerFrameworkFlag)
{
  // In order to verify that the proper amount of history
  // is maintained, we launch exactly 2 frameworks when
  // 'max_completed_frameworks' is set to 0, 1 and 2. This
  // covers the cases of maintaining 0 history, some history
  // less than the total number of frameworks launched, and
  // history equal to the total number of frameworks launched.
  const size_t totalFrameworks = 2;
  const size_t maxFrameworksArray[] = {0, 1, 2};
```



src/tests/master_tests.cpp (lines 3993 - 4011)


Tried to consolidate here as well:

```
// Test the max_completed_tasks_per_framework flag for master.
TEST_F(MasterTest, MaxCompletedTasksPerFrameworkFlag)
{
  // We verify that the proper amount of history is maintained
  // by launching a single framework with exactly 2 tasks. We
  // do this when setting `max_completed_tasks_per_framework`
  // to 0, 1, and 2. This covers the cases of maintaining no
  // history, some history less than the total number of tasks
  // launched, and history equal to the total number of tasks
  // launched.
  const size_t totalTasksPerFramework = 2;
  const size_t maxTasksPerFrameworkArray[] = {0, 1, 2};
```



src/tests/master_tests.cpp (line 4011)


whoops: s/{ /{/



src/tests/master_tests.cpp (line 4085)


Perhaps:

```
// There should be only 1 completed framework.
```

Specifically, not sure if we need to describe that we "count" here?


- Ben Mahler


On Jan. 15, 2016, 12:49 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42212/
> ---
> 
> (Updated Jan. 15, 2016, 12:49 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3307
> https://issues.apache.org/jira/browse/MESOS-3307
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit adds a unit test to verify that the the max_frameworks and
> max_tasks_per_frameworks flags for master work properly. Specifically,
> we test to verify that the proper amount of history is maintained for
> both 0 values to these flags as well as positive values <= to the total
> number of frameworks and tasks per framework actually launched.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 9638fb867b07f85a02d3b78f8282843d8871cabe 
> 
> Diff: https://reviews.apache.org/r/42212/diff/
> 
> 
> Testing
> ---
> 
> This is a unit test.  I ran it on my mac and on ubuntu 14.04.
> 
> GTEST_FILTER="MasterTest.MaxCompletedTasksPerFrameworkFlag:MasterTest.MaxCompletedFrameworksFlag"
>  make check -j 7
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-14 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42212/#review114539
---


Patch looks great!

Reviews applied: [42053, 42212]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 14, 2016, 4:11 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42212/
> ---
> 
> (Updated Jan. 14, 2016, 4:11 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3307
> https://issues.apache.org/jira/browse/MESOS-3307
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit adds a unit test to verify that the the max_frameworks and
> max_tasks_per_frameworks flags for master work properly. Specifically,
> we test to verify that the proper amount of history is maintained for
> both 0 values to these flags as well as positive values <= to the total
> number of frameworks and tasks per framework actually launched.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 223b9d20a3a8a8194a3a6a605ec2394c37ab5957 
> 
> Diff: https://reviews.apache.org/r/42212/diff/
> 
> 
> Testing
> ---
> 
> This is a unit test.  I ran it on my mac and on ubuntu 14.04.
> 
> GTEST_FILTER="MasterTest.MaxCompletedTasksPerFrameworkFlag:MasterTest.MaxCompletedFrameworksFlag"
>  make check -j 7
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-13 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42212/
---

(Updated Jan. 13, 2016, 11:01 a.m.)


Review request for mesos and Ben Mahler.


Changes
---

Change EXPECT_LE to EXPECT_EQ for comparing maxFrameworks/numFrameworks and 
maxTasksPerFramework/numTaskPerFramework. This change is OK, and actually more 
correct given the setup of the test (i.e. we will always be limited by max*). 
Also fix up some comments.


Bugs: MESOS-3307
https://issues.apache.org/jira/browse/MESOS-3307


Repository: mesos


Description
---

This commit adds a unit test to verify that the the max_frameworks and
max_tasks_per_frameworks flags for master work properly. Specifically,
we test to verify that the proper amount of history is maintained for
both 0 values to these flags as well as positive values <= to the total
number frameworks and tasks per framework actually launched.


Diffs (updated)
-

  src/tests/master_tests.cpp 223b9d20a3a8a8194a3a6a605ec2394c37ab5957 

Diff: https://reviews.apache.org/r/42212/diff/


Testing
---

This is a unit test.  I ran it on my mac and on ubuntu 14.04.

GTEST_FILTER="MasterTest.FrameworksTasksCompletedFlags" make check -j 7


Thanks,

Kevin Klues

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-13 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42212/#review114198
---


Patch looks great!

Reviews applied: [42053, 42212]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 13, 2016, 11:01 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42212/
> ---
> 
> (Updated Jan. 13, 2016, 11:01 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3307
> https://issues.apache.org/jira/browse/MESOS-3307
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit adds a unit test to verify that the the max_frameworks and
> max_tasks_per_frameworks flags for master work properly. Specifically,
> we test to verify that the proper amount of history is maintained for
> both 0 values to these flags as well as positive values <= to the total
> number frameworks and tasks per framework actually launched.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 223b9d20a3a8a8194a3a6a605ec2394c37ab5957 
> 
> Diff: https://reviews.apache.org/r/42212/diff/
> 
> 
> Testing
> ---
> 
> This is a unit test.  I ran it on my mac and on ubuntu 14.04.
> 
> GTEST_FILTER="MasterTest.FrameworksTasksCompletedFlags" make check -j 7
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-13 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42212/#review114384
---



src/tests/master_tests.cpp (line 4090)


Talking to bmahler offline, we can now use -> to avoid calling .get() on 
{Option, Result, Try, Future, etc.}.  I plan to patch up all instance of this 
in this test.


- Kevin Klues


On Jan. 13, 2016, 11:01 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42212/
> ---
> 
> (Updated Jan. 13, 2016, 11:01 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3307
> https://issues.apache.org/jira/browse/MESOS-3307
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit adds a unit test to verify that the the max_frameworks and
> max_tasks_per_frameworks flags for master work properly. Specifically,
> we test to verify that the proper amount of history is maintained for
> both 0 values to these flags as well as positive values <= to the total
> number frameworks and tasks per framework actually launched.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 223b9d20a3a8a8194a3a6a605ec2394c37ab5957 
> 
> Diff: https://reviews.apache.org/r/42212/diff/
> 
> 
> Testing
> ---
> 
> This is a unit test.  I ran it on my mac and on ubuntu 14.04.
> 
> GTEST_FILTER="MasterTest.FrameworksTasksCompletedFlags" make check -j 7
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-13 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42212/#review114382
---


Talking to bmahler offline, we decided to split the current test into two (more 
isolated) tests, which test the max_completed_frameworks and 
max_completed_tasks_per_framework flags separately.

- Kevin Klues


On Jan. 13, 2016, 11:01 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42212/
> ---
> 
> (Updated Jan. 13, 2016, 11:01 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3307
> https://issues.apache.org/jira/browse/MESOS-3307
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit adds a unit test to verify that the the max_frameworks and
> max_tasks_per_frameworks flags for master work properly. Specifically,
> we test to verify that the proper amount of history is maintained for
> both 0 values to these flags as well as positive values <= to the total
> number frameworks and tasks per framework actually launched.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 223b9d20a3a8a8194a3a6a605ec2394c37ab5957 
> 
> Diff: https://reviews.apache.org/r/42212/diff/
> 
> 
> Testing
> ---
> 
> This is a unit test.  I ran it on my mac and on ubuntu 14.04.
> 
> GTEST_FILTER="MasterTest.FrameworksTasksCompletedFlags" make check -j 7
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-13 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42212/#review114385
---



src/tests/master_tests.cpp (line 3989)


As bmahler pointed out offline, mesos doesn't typically use loop variables 
such as 'fid' and 'tid'. It prefers simple variable names such as {i, j} or 
more explicit variable names such as {frameworkIndex, taskIndex}.  I will 
update this throughout.



src/tests/master_tests.cpp (line 4104)


As bmahler pointed out offline, this comment is unnecessary. It doesn't add 
to the story being told by this code and implies that such a comment would be 
needed in all tests that called Shutdown().

What I meant to clarify was that we were shutting down the current master 
for this iteration of the loop -- which isn't necessarily clear and does 
deserve a comment. I plan to update the comment accordingly.



src/tests/master_tests.cpp (line 4106)


As bmahler pointed out offline, we should really be using 
Stop(master.get()) here instead of shutdown.

I originally called Shutdown() due to a comment in MesosTest::Shutdown() 
about properly unsetting the authenticators on the master upon shutdown. 
However, bmahler said this shouldn't be an issue for the current test and that 
Stop() is more appropriate in this loop with a single master per iteration.


- Kevin Klues


On Jan. 13, 2016, 11:01 a.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42212/
> ---
> 
> (Updated Jan. 13, 2016, 11:01 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3307
> https://issues.apache.org/jira/browse/MESOS-3307
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit adds a unit test to verify that the the max_frameworks and
> max_tasks_per_frameworks flags for master work properly. Specifically,
> we test to verify that the proper amount of history is maintained for
> both 0 values to these flags as well as positive values <= to the total
> number frameworks and tasks per framework actually launched.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 223b9d20a3a8a8194a3a6a605ec2394c37ab5957 
> 
> Diff: https://reviews.apache.org/r/42212/diff/
> 
> 
> Testing
> ---
> 
> This is a unit test.  I ran it on my mac and on ubuntu 14.04.
> 
> GTEST_FILTER="MasterTest.FrameworksTasksCompletedFlags" make check -j 7
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>

Review Request 42212: Added unit test for framework/task history flags.

2016-01-12 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42212/
---

Review request for mesos and Ben Mahler.


Bugs: MESOS-3307
https://issues.apache.org/jira/browse/MESOS-3307


Repository: mesos


Description
---

This commit adds a unit test to verify that the the max_frameworks and
max_tasks_per_frameworks flags for master work properly. Specifically,
we test to verify that the proper amount of history is maintained for
both 0 values to these flags as well as positive values <= to the total
number frameworks and tasks per framework actually launched.


Diffs
-

  src/tests/master_tests.cpp 223b9d20a3a8a8194a3a6a605ec2394c37ab5957 

Diff: https://reviews.apache.org/r/42212/diff/


Testing
---

This is a unit test.  I ran it on my mac and on ubuntu 14.04.


Thanks,

Kevin Klues

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-12 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42212/
---

(Updated Jan. 12, 2016, 10:12 p.m.)


Review request for mesos and Ben Mahler.


Bugs: MESOS-3307
https://issues.apache.org/jira/browse/MESOS-3307


Repository: mesos


Description
---

This commit adds a unit test to verify that the the max_frameworks and
max_tasks_per_frameworks flags for master work properly. Specifically,
we test to verify that the proper amount of history is maintained for
both 0 values to these flags as well as positive values <= to the total
number frameworks and tasks per framework actually launched.


Diffs
-

  src/tests/master_tests.cpp 223b9d20a3a8a8194a3a6a605ec2394c37ab5957 

Diff: https://reviews.apache.org/r/42212/diff/


Testing (updated)
---

This is a unit test.  I ran it on my mac and on ubuntu 14.04.

GTEST_FILTER="MasterTest.FrameworksTasksCompletedFlags" make check -j 7


Thanks,

Kevin Klues

Re: Review Request 42212: Added unit test for framework/task history flags.

2016-01-12 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42212/#review114119
---


Patch looks great!

Reviews applied: [42053, 42212]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 12, 2016, 10:12 p.m., Kevin Klues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42212/
> ---
> 
> (Updated Jan. 12, 2016, 10:12 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3307
> https://issues.apache.org/jira/browse/MESOS-3307
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This commit adds a unit test to verify that the the max_frameworks and
> max_tasks_per_frameworks flags for master work properly. Specifically,
> we test to verify that the proper amount of history is maintained for
> both 0 values to these flags as well as positive values <= to the total
> number frameworks and tasks per framework actually launched.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 223b9d20a3a8a8194a3a6a605ec2394c37ab5957 
> 
> Diff: https://reviews.apache.org/r/42212/diff/
> 
> 
> Testing
> ---
> 
> This is a unit test.  I ran it on my mac and on ubuntu 14.04.
> 
> GTEST_FILTER="MasterTest.FrameworksTasksCompletedFlags" make check -j 7
> 
> 
> Thanks,
> 
> Kevin Klues
> 
>