Re: Review Request 42216: Fixed gmock warnings in hook tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42216/#review114601 --- Ship it! Ship It! - Timothy Chen On Jan. 13, 2016, 10:20 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42216/ > --- > > (Updated Jan. 13, 2016, 10:20 p.m.) > > > Review request for mesos, Joris Van Remoortere, Neil Conway, and Timothy Chen. > > > Bugs: MESOS-4348 > https://issues.apache.org/jira/browse/MESOS-4348 > > > Repository: mesos > > > Description > --- > > We did not have an expectation on the `shutdown` method of the > `MockExecutor`. This led to the gmock warning being emitted in some runs. The > tests that are being fixed are: > > - `HookTest.VerifyMasterLaunchTaskHook` > - `HookTest.VerifySlaveRunTaskHook` > - `HookTest.VerifySlaveTaskStatusDecorator` > > > Diffs > - > > src/tests/hook_tests.cpp 715b0b07e1befdca5b09172a439edccd7546d77f > > Diff: https://reviews.apache.org/r/42216/diff/ > > > Testing > --- > > Loop the tests for 1000 times. > > > Thanks, > > Anand Mazumdar > >
Re: Review Request 42216: Fixed gmock warnings in hook tests.
> On Jan. 13, 2016, 9:17 p.m., Neil Conway wrote: > > Can you include the names of the tests in the commit message? Done. - Anand --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42216/#review114282 --- On Jan. 13, 2016, 10:20 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42216/ > --- > > (Updated Jan. 13, 2016, 10:20 p.m.) > > > Review request for mesos, Joris Van Remoortere, Neil Conway, and Timothy Chen. > > > Bugs: MESOS-4348 > https://issues.apache.org/jira/browse/MESOS-4348 > > > Repository: mesos > > > Description > --- > > We did not have an expectation on the `shutdown` method of the > `MockExecutor`. This led to the gmock warning being emitted in some runs. The > tests that are being fixed are: > > - `HookTest.VerifyMasterLaunchTaskHook` > - `HookTest.VerifySlaveRunTaskHook` > - `HookTest.VerifySlaveTaskStatusDecorator` > > > Diffs > - > > src/tests/hook_tests.cpp 715b0b07e1befdca5b09172a439edccd7546d77f > > Diff: https://reviews.apache.org/r/42216/diff/ > > > Testing > --- > > Loop the tests for 1000 times. > > > Thanks, > > Anand Mazumdar > >
Re: Review Request 42216: Fixed gmock warnings in hook tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42216/ --- (Updated Jan. 13, 2016, 10:20 p.m.) Review request for mesos, Joris Van Remoortere, Neil Conway, and Timothy Chen. Changes --- Modified description to include test names Bugs: MESOS-4348 https://issues.apache.org/jira/browse/MESOS-4348 Repository: mesos Description (updated) --- We did not have an expectation on the `shutdown` method of the `MockExecutor`. This led to the gmock warning being emitted in some runs. The tests that are being fixed are: - `HookTest.VerifyMasterLaunchTaskHook` - `HookTest.VerifySlaveRunTaskHook` - `HookTest.VerifySlaveTaskStatusDecorator` Diffs - src/tests/hook_tests.cpp 715b0b07e1befdca5b09172a439edccd7546d77f Diff: https://reviews.apache.org/r/42216/diff/ Testing --- Loop the tests for 1000 times. Thanks, Anand Mazumdar
Re: Review Request 42216: Fixed gmock warnings in hook tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42216/#review114282 --- Can you include the names of the tests in the commit message? - Neil Conway On Jan. 12, 2016, 10:27 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42216/ > --- > > (Updated Jan. 12, 2016, 10:27 p.m.) > > > Review request for mesos, Joris Van Remoortere and Neil Conway. > > > Bugs: MESOS-4348 > https://issues.apache.org/jira/browse/MESOS-4348 > > > Repository: mesos > > > Description > --- > > We did not have an expectation on the `shutdown` method of the > `MockExecutor`. This led to the gmock warning being emitted in some runs. > > > Diffs > - > > src/tests/hook_tests.cpp 715b0b07e1befdca5b09172a439edccd7546d77f > > Diff: https://reviews.apache.org/r/42216/diff/ > > > Testing > --- > > Loop the tests for 1000 times. > > > Thanks, > > Anand Mazumdar > >
Re: Review Request 42216: Fixed gmock warnings in hook tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42216/#review114271 --- Ship it! Ship It! - Neil Conway On Jan. 12, 2016, 10:27 p.m., Anand Mazumdar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42216/ > --- > > (Updated Jan. 12, 2016, 10:27 p.m.) > > > Review request for mesos, Joris Van Remoortere and Neil Conway. > > > Bugs: MESOS-4348 > https://issues.apache.org/jira/browse/MESOS-4348 > > > Repository: mesos > > > Description > --- > > We did not have an expectation on the `shutdown` method of the > `MockExecutor`. This led to the gmock warning being emitted in some runs. > > > Diffs > - > > src/tests/hook_tests.cpp 715b0b07e1befdca5b09172a439edccd7546d77f > > Diff: https://reviews.apache.org/r/42216/diff/ > > > Testing > --- > > Loop the tests for 1000 times. > > > Thanks, > > Anand Mazumdar > >
Review Request 42216: Fixed gmock warnings in hook tests.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42216/ --- Review request for mesos, Joris Van Remoortere and Neil Conway. Bugs: MESOS-4348 https://issues.apache.org/jira/browse/MESOS-4348 Repository: mesos Description --- We did not have an expectation on the `shutdown` method of the `MockExecutor`. This led to the gmock warning being emitted in some runs. Diffs - src/tests/hook_tests.cpp 715b0b07e1befdca5b09172a439edccd7546d77f Diff: https://reviews.apache.org/r/42216/diff/ Testing --- Loop the tests for 1000 times. Thanks, Anand Mazumdar
