Re: Review Request 42237: Added docker image manifest parsing functions for strings.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42237/ --- (Updated Jan. 17, 2016, 9:51 p.m.) Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen. Changes --- Rebased. Bugs: MESOS-4296 https://issues.apache.org/jira/browse/MESOS-4296 Repository: mesos Description --- Added docker image manifest parsing functions for strings. Diffs (updated) - include/mesos/docker/spec.hpp 822b2383c6d6bd691cb1fdbfcd699ae3ae3585bd src/docker/spec.cpp 0188078037b3528acefa42d39f05bd60789b19b2 Diff: https://reviews.apache.org/r/42237/diff/ Testing --- make check Thanks, Jie Yu
Re: Review Request 42237: Added docker image manifest parsing functions for strings.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42237/#review114436 --- Ship it! Ship It! - Qian Zhang On Jan. 13, 2016, 2:23 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42237/ > --- > > (Updated Jan. 13, 2016, 2:23 p.m.) > > > Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and > Timothy Chen. > > > Bugs: MESOS-4296 > https://issues.apache.org/jira/browse/MESOS-4296 > > > Repository: mesos > > > Description > --- > > Added docker image manifest parsing functions for strings. > > > Diffs > - > > include/mesos/docker/spec.hpp 822b2383c6d6bd691cb1fdbfcd699ae3ae3585bd > src/docker/spec.cpp 0188078037b3528acefa42d39f05bd60789b19b2 > > Diff: https://reviews.apache.org/r/42237/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jie Yu > >
Re: Review Request 42237: Added docker image manifest parsing functions for strings.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42237/#review114277 --- Ship it! Ship It! - Timothy Chen On Jan. 13, 2016, 6:23 a.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42237/ > --- > > (Updated Jan. 13, 2016, 6:23 a.m.) > > > Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and > Timothy Chen. > > > Bugs: MESOS-4296 > https://issues.apache.org/jira/browse/MESOS-4296 > > > Repository: mesos > > > Description > --- > > Added docker image manifest parsing functions for strings. > > > Diffs > - > > include/mesos/docker/spec.hpp 822b2383c6d6bd691cb1fdbfcd699ae3ae3585bd > src/docker/spec.cpp 0188078037b3528acefa42d39f05bd60789b19b2 > > Diff: https://reviews.apache.org/r/42237/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jie Yu > >
Re: Review Request 42237: Added docker image manifest parsing functions for strings.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42237/#review114260 --- Ship it! LGTM! - Gilbert Song On Jan. 12, 2016, 10:23 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42237/ > --- > > (Updated Jan. 12, 2016, 10:23 p.m.) > > > Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and > Timothy Chen. > > > Bugs: MESOS-4296 > https://issues.apache.org/jira/browse/MESOS-4296 > > > Repository: mesos > > > Description > --- > > Added docker image manifest parsing functions for strings. > > > Diffs > - > > include/mesos/docker/spec.hpp 822b2383c6d6bd691cb1fdbfcd699ae3ae3585bd > src/docker/spec.cpp 0188078037b3528acefa42d39f05bd60789b19b2 > > Diff: https://reviews.apache.org/r/42237/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jie Yu > >
Review Request 42237: Added docker image manifest parsing functions for strings.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42237/ --- Review request for mesos, Ben Mahler, Gilbert Song, Jojy Varghese, and Timothy Chen. Bugs: MESOS-4296 https://issues.apache.org/jira/browse/MESOS-4296 Repository: mesos Description --- Added docker image manifest parsing functions for strings. Diffs - include/mesos/docker/spec.hpp 822b2383c6d6bd691cb1fdbfcd699ae3ae3585bd src/docker/spec.cpp 0188078037b3528acefa42d39f05bd60789b19b2 Diff: https://reviews.apache.org/r/42237/diff/ Testing --- make check Thanks, Jie Yu
