Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-04-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/#review128422 --- Ship it! Ship It! - Alexander Rukletsov On April 9, 2016,

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-04-09 Thread Jian Qiu
> On 二月 19, 2016, 2:50 a.m., Anand Mazumdar wrote: > > src/tests/hook_tests.cpp, line 396 > > > > > > Is there a need to explicitly invoke `Clock::resume()` here? If not, > > kill it. > > Alexander Rukletsov

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-04-09 Thread Jian Qiu
> On 四月 8, 2016, 2:52 p.m., Alexander Rukletsov wrote: > > src/tests/hook_tests.cpp, line 392 > > > > > > we don't need `settle` here because AWAIT_READY does it for us. > > However, we should resume the clock

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-04-09 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/ --- (Updated 四月 9, 2016, 2:45 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-04-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/#review127792 --- src/tests/hook_tests.cpp (line 391)

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-04-08 Thread Anand Mazumdar
> On Feb. 19, 2016, 2:50 a.m., Anand Mazumdar wrote: > > src/tests/hook_tests.cpp, line 396 > > > > > > Is there a need to explicitly invoke `Clock::resume()` here? If not, > > kill it. > > Alexander Rukletsov

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-04-08 Thread Alexander Rukletsov
> On Feb. 19, 2016, 2:50 a.m., Anand Mazumdar wrote: > > src/tests/hook_tests.cpp, line 396 > > > > > > Is there a need to explicitly invoke `Clock::resume()` here? If not, > > kill it. > > Alexander Rukletsov

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-04-08 Thread Anand Mazumdar
> On Feb. 19, 2016, 2:50 a.m., Anand Mazumdar wrote: > > src/tests/hook_tests.cpp, line 396 > > > > > > Is there a need to explicitly invoke `Clock::resume()` here? If not, > > kill it. > > Alexander Rukletsov

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-04-08 Thread Alexander Rukletsov
> On Feb. 19, 2016, 2:50 a.m., Anand Mazumdar wrote: > > src/tests/hook_tests.cpp, line 396 > > > > > > Is there a need to explicitly invoke `Clock::resume()` here? If not, > > kill it. Let's leave the test with

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-02-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/#review119861 --- Patch looks great! Reviews applied: [42241] Passed command:

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-02-18 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/#review119807 --- Ship it! Ship It! - Anand Mazumdar On Feb. 19, 2016, 4:36

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-02-18 Thread Jian Qiu
> On 二月 19, 2016, 2:50 a.m., Anand Mazumdar wrote: > > src/tests/hook_tests.cpp, line 390 > > > > > > hmm ... Can't we just do: > > > > ``` > > Clock::pause(); > > Clock::advance(...); > >

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-02-18 Thread Anand Mazumdar
> On Feb. 19, 2016, 2:50 a.m., Anand Mazumdar wrote: > > src/tests/hook_tests.cpp, line 390 > > > > > > hmm ... Can't we just do: > > > > ``` > > Clock::pause(); > > Clock::advance(...); > >

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-02-18 Thread Jian Qiu
> On 二月 19, 2016, 2:50 a.m., Anand Mazumdar wrote: > > src/tests/hook_tests.cpp, line 390 > > > > > > hmm ... Can't we just do: > > > > ``` > > Clock::pause(); > > Clock::advance(...); > >

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-02-18 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/ --- (Updated 二月 19, 2016, 3:29 a.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-02-18 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/#review119797 --- LGTM, some minor comments around avoiding redundant use of

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-01-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/#review115038 --- Patch looks great! Reviews applied: [42241] Passed command:

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-01-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/#review114994 --- src/tests/hook_tests.cpp (lines 396 - 399)

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-01-18 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/ --- (Updated 一月 18, 2016, 4:03 p.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-01-18 Thread Jian Qiu
> On 一月 18, 2016, 11:49 a.m., Alexander Rukletsov wrote: > > src/tests/hook_tests.cpp, lines 396-399 > > > > > > Why do you need a loop here? Isn't it enought to advance once and then > > settle? Right...there is

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-01-18 Thread Jian Qiu
> On 一月 15, 2016, 8:53 p.m., Timothy Chen wrote: > > src/tests/hook_tests.cpp, line 389 > > > > > > If hookFuture never becomes ready that this blocks forever right? > > AWAIT_READY has a timeout built in, and

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-01-17 Thread Jian Qiu
> On 一月 15, 2016, 8:53 p.m., Timothy Chen wrote: > > src/tests/hook_tests.cpp, line 389 > > > > > > If hookFuture never becomes ready that this blocks forever right? > > AWAIT_READY has a timeout built in, and

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-01-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/#review114941 --- Patch looks great! Reviews applied: [42241] Passed command:

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-01-17 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/ --- (Updated 一月 18, 2016, 2:28 a.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-01-15 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/ --- (Updated Jan. 15, 2016, 6:20 p.m.) Review request for mesos, Alexander

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-01-15 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/#review114762 --- src/tests/hook_tests.cpp (line 389)

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-01-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/#review114802 --- Patch looks great! Reviews applied: [42241] Passed command:

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-01-14 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/#review114675 --- Ship it! Ship It! - Guangya Liu On 一月 15, 2016, 5:10 a.m.,

Re: Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-01-14 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/#review114673 --- Ship it! Ship It! - haosdent huang On Jan. 15, 2016, 5:10

Review Request 42241: Speed up HookTest.VerifySlaveLaunchExecutorHook.

2016-01-13 Thread Jian Qiu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42241/ --- Review request for mesos and Alexander Rukletsov. Bugs: MESOS-4174