Re: Review Request 42389: Fixed unmount order in linux filesystem isolator cleanup.

2016-01-20 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42389/#review115530
---

Ship it!


Ship It!

- Jie Yu


On Jan. 19, 2016, 12:10 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42389/
> ---
> 
> (Updated Jan. 19, 2016, 12:10 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Jie Yu.
> 
> 
> Bugs: MESOS-3379
> https://issues.apache.org/jira/browse/MESOS-3379
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed unmount order in linux filesystem isolator cleanup.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> ace9e305c24a9841f1716c9bf40cd13b16ef0cec 
> 
> Diff: https://reviews.apache.org/r/42389/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>



Re: Review Request 42389: Fixed unmount order in linux filesystem isolator cleanup.

2016-01-18 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42389/#review115094
---


Patch looks great!

Reviews applied: [42379, 42389]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 19, 2016, 12:10 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42389/
> ---
> 
> (Updated Jan. 19, 2016, 12:10 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Jie Yu.
> 
> 
> Bugs: MESOS-3379
> https://issues.apache.org/jira/browse/MESOS-3379
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed unmount order in linux filesystem isolator cleanup.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> ace9e305c24a9841f1716c9bf40cd13b16ef0cec 
> 
> Diff: https://reviews.apache.org/r/42389/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>



Re: Review Request 42389: Fixed unmount order in linux filesystem isolator cleanup.

2016-01-18 Thread Timothy Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42389/
---

(Updated Jan. 19, 2016, 12:10 a.m.)


Review request for mesos, haosdent huang and Jie Yu.


Bugs: MESOS-3379
https://issues.apache.org/jira/browse/MESOS-3379


Repository: mesos


Description
---

Fixed unmount order in linux filesystem isolator cleanup.


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
ace9e305c24a9841f1716c9bf40cd13b16ef0cec 

Diff: https://reviews.apache.org/r/42389/diff/


Testing
---

make check


Thanks,

Timothy Chen



Re: Review Request 42389: Fixed unmount order in linux filesystem isolator cleanup.

2016-01-16 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42389/#review114855
---

Ship it!


Ship It!

- haosdent huang


On Jan. 16, 2016, 8:45 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42389/
> ---
> 
> (Updated Jan. 16, 2016, 8:45 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Jie Yu.
> 
> 
> Bugs: MESOS-3379
> https://issues.apache.org/jira/browse/MESOS-3379
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed unmount order in linux filesystem isolator cleanup.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> ace9e305c24a9841f1716c9bf40cd13b16ef0cec 
> 
> Diff: https://reviews.apache.org/r/42389/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>



Re: Review Request 42389: Fixed unmount order in linux filesystem isolator cleanup.

2016-01-16 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42389/#review114854
---


Patch looks great!

Reviews applied: [42379, 42389]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 16, 2016, 8:45 a.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42389/
> ---
> 
> (Updated Jan. 16, 2016, 8:45 a.m.)
> 
> 
> Review request for mesos, haosdent huang and Jie Yu.
> 
> 
> Bugs: MESOS-3379
> https://issues.apache.org/jira/browse/MESOS-3379
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed unmount order in linux filesystem isolator cleanup.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
> ace9e305c24a9841f1716c9bf40cd13b16ef0cec 
> 
> Diff: https://reviews.apache.org/r/42389/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>



Review Request 42389: Fixed unmount order in linux filesystem isolator cleanup.

2016-01-16 Thread Timothy Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42389/
---

Review request for mesos, haosdent huang and Jie Yu.


Bugs: MESOS-3379
https://issues.apache.org/jira/browse/MESOS-3379


Repository: mesos


Description
---

Fixed unmount order in linux filesystem isolator cleanup.


Diffs
-

  src/slave/containerizer/mesos/isolators/filesystem/linux.cpp 
ace9e305c24a9841f1716c9bf40cd13b16ef0cec 

Diff: https://reviews.apache.org/r/42389/diff/


Testing
---

make check


Thanks,

Timothy Chen