Re: Review Request 42517: Added discussion about allowing multiple frameworks in a role.

2016-01-28 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42517/#review116928
---


Ship it!




Ship It!

- Joris Van Remoortere


On Jan. 20, 2016, 9:57 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42517/
> ---
> 
> (Updated Jan. 20, 2016, 9:57 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added discussion about allowing multiple frameworks in a role.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 4af7d6e8dc648fb630f56db5fbad1b7b438ebcfb 
>   docs/roles.md 609a63cbff2d9c652af45ba16152ce3caf48 
> 
> Diff: https://reviews.apache.org/r/42517/diff/
> 
> 
> Testing
> ---
> 
> Previewed on github.
> 
> Note that the link to `roles.md` doesn't work at the moment, but I believe it 
> should work once Joerg's fix for the `Rakefile` is merged.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42517: Added discussion about allowing multiple frameworks in a role.

2016-01-20 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42517/#review115565
---


Patch looks great!

Reviews applied: [42517]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 20, 2016, 9:57 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42517/
> ---
> 
> (Updated Jan. 20, 2016, 9:57 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added discussion about allowing multiple frameworks in a role.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 4af7d6e8dc648fb630f56db5fbad1b7b438ebcfb 
>   docs/roles.md 609a63cbff2d9c652af45ba16152ce3caf48 
> 
> Diff: https://reviews.apache.org/r/42517/diff/
> 
> 
> Testing
> ---
> 
> Previewed on github.
> 
> Note that the link to `roles.md` doesn't work at the moment, but I believe it 
> should work once Joerg's fix for the `Rakefile` is merged.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42517: Added discussion about allowing multiple frameworks in a role.

2016-01-20 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42517/#review115538
---

Ship it!


Ship It!

- Guangya Liu


On 一月 20, 2016, 9:57 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42517/
> ---
> 
> (Updated 一月 20, 2016, 9:57 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added discussion about allowing multiple frameworks in a role.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 4af7d6e8dc648fb630f56db5fbad1b7b438ebcfb 
>   docs/roles.md 609a63cbff2d9c652af45ba16152ce3caf48 
> 
> Diff: https://reviews.apache.org/r/42517/diff/
> 
> 
> Testing
> ---
> 
> Previewed on github.
> 
> Note that the link to `roles.md` doesn't work at the moment, but I believe it 
> should work once Joerg's fix for the `Rakefile` is merged.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42517: Added discussion about allowing multiple frameworks in a role.

2016-01-20 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42517/#review115529
---

Ship it!


Ship It!

- Alexander Rukletsov


On Jan. 20, 2016, 9:57 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42517/
> ---
> 
> (Updated Jan. 20, 2016, 9:57 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added discussion about allowing multiple frameworks in a role.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 4af7d6e8dc648fb630f56db5fbad1b7b438ebcfb 
>   docs/roles.md 609a63cbff2d9c652af45ba16152ce3caf48 
> 
> Diff: https://reviews.apache.org/r/42517/diff/
> 
> 
> Testing
> ---
> 
> Previewed on github.
> 
> Note that the link to `roles.md` doesn't work at the moment, but I believe it 
> should work once Joerg's fix for the `Rakefile` is merged.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42517: Added discussion about allowing multiple frameworks in a role.

2016-01-20 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42517/
---

(Updated Jan. 20, 2016, 9:57 p.m.)


Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.


Repository: mesos


Description
---

Added discussion about allowing multiple frameworks in a role.


Diffs
-

  docs/persistent-volume.md 4af7d6e8dc648fb630f56db5fbad1b7b438ebcfb 
  docs/roles.md 609a63cbff2d9c652af45ba16152ce3caf48 

Diff: https://reviews.apache.org/r/42517/diff/


Testing (updated)
---

Previewed on github.

Note that the link to `roles.md` doesn't work at the moment, but I believe it 
should work once Joerg's fix for the `Rakefile` is merged.


Thanks,

Neil Conway

Re: Review Request 42517: Added discussion about allowing multiple frameworks in a role.

2016-01-20 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42517/
---

(Updated Jan. 20, 2016, 9:56 p.m.)


Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.


Changes
---

Address review comments.


Repository: mesos


Description
---

Added discussion about allowing multiple frameworks in a role.


Diffs (updated)
-

  docs/persistent-volume.md 4af7d6e8dc648fb630f56db5fbad1b7b438ebcfb 
  docs/roles.md 609a63cbff2d9c652af45ba16152ce3caf48 

Diff: https://reviews.apache.org/r/42517/diff/


Testing
---

Previewed on github.


Thanks,

Neil Conway

Re: Review Request 42517: Added discussion about allowing multiple frameworks in a role.

2016-01-20 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42517/#review115454
---


Patch looks great!

Reviews applied: [42517]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 19, 2016, 7:34 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42517/
> ---
> 
> (Updated Jan. 19, 2016, 7:34 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added discussion about allowing multiple frameworks in a role.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 4af7d6e8dc648fb630f56db5fbad1b7b438ebcfb 
> 
> Diff: https://reviews.apache.org/r/42517/diff/
> 
> 
> Testing
> ---
> 
> Previewed on github.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42517: Added discussion about allowing multiple frameworks in a role.

2016-01-20 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42517/#review115405
---



docs/persistent-volume.md (lines 406 - 407)


I would suggest to clarify that this makes it hard to check, whether the 
request succeeded and no timeouts will help. It may seem obvious, but let's 
stay on the safe side and explain it explicitly.



docs/persistent-volume.md (lines 411 - 413)


You have a great section on multi-framework-in-a-role topic in roles.md, 
let's link it here!


- Alexander Rukletsov


On Jan. 19, 2016, 7:34 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42517/
> ---
> 
> (Updated Jan. 19, 2016, 7:34 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added discussion about allowing multiple frameworks in a role.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 4af7d6e8dc648fb630f56db5fbad1b7b438ebcfb 
> 
> Diff: https://reviews.apache.org/r/42517/diff/
> 
> 
> Testing
> ---
> 
> Previewed on github.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 42517: Added discussion about allowing multiple frameworks in a role.

2016-01-19 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42517/#review115330
---



docs/persistent-volume.md (line 404)


s/As discussed above//

s/with a role. This/with a role, this/


- Guangya Liu


On 一月 19, 2016, 7:34 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42517/
> ---
> 
> (Updated 一月 19, 2016, 7:34 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added discussion about allowing multiple frameworks in a role.
> 
> 
> Diffs
> -
> 
>   docs/persistent-volume.md 4af7d6e8dc648fb630f56db5fbad1b7b438ebcfb 
> 
> Diff: https://reviews.apache.org/r/42517/diff/
> 
> 
> Testing
> ---
> 
> Previewed on github.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Review Request 42517: Added discussion about allowing multiple frameworks in a role.

2016-01-19 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42517/
---

Review request for mesos, Alexander Rukletsov and Joris Van Remoortere.


Repository: mesos


Description
---

Added discussion about allowing multiple frameworks in a role.


Diffs
-

  docs/persistent-volume.md 4af7d6e8dc648fb630f56db5fbad1b7b438ebcfb 

Diff: https://reviews.apache.org/r/42517/diff/


Testing
---

Previewed on github.


Thanks,

Neil Conway