Re: Review Request 42554: Added 'dependencies' message to AppcImageManifest.

2016-01-28 Thread Jie Yu 


> On Jan. 28, 2016, 10:08 p.m., Anand Mazumdar wrote:
> > include/mesos/mesos.proto, line 1637
> > 
> >
> > hmmm .. we have generally just used `name` as the field-name at other 
> > places for specifying the image name in this file. What is different about 
> > this occurence?
> > 
> > In a similar vein, `imageID` should just be `id`?

Anand, the reason is that we need to match the same in the following spec:
https://github.com/appc/spec/blob/master/spec/aci.md

So that our json->protobuf parsing will work properly.


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42554/#review116823
---


On Jan. 26, 2016, 2:19 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42554/
> ---
> 
> (Updated Jan. 26, 2016, 2:19 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 'dependencies' message to AppcImageManifest.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b 
> 
> Diff: https://reviews.apache.org/r/42554/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 42554: Added 'dependencies' message to AppcImageManifest.

2016-01-28 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42554/#review116822
---


Fix it, then Ship it!





include/mesos/mesos.proto (line 1640)


Use uint64 here?


- Jie Yu


On Jan. 26, 2016, 2:19 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42554/
> ---
> 
> (Updated Jan. 26, 2016, 2:19 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 'dependencies' message to AppcImageManifest.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b 
> 
> Diff: https://reviews.apache.org/r/42554/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 42554: Added 'dependencies' message to AppcImageManifest.

2016-01-28 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42554/#review116823
---




include/mesos/mesos.proto (line 1637)


hmmm .. we have generally just used `name` as the field-name at other 
places for specifying the image name in this file. What is different about this 
occurence?

In a similar vein, `imageID` should just be `id`?


- Anand Mazumdar


On Jan. 26, 2016, 2:19 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42554/
> ---
> 
> (Updated Jan. 26, 2016, 2:19 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 'dependencies' message to AppcImageManifest.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b 
> 
> Diff: https://reviews.apache.org/r/42554/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 42554: Added 'dependencies' message to AppcImageManifest.

2016-01-28 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42554/#review116826
---



it's strange that this protobuf is exposed in Mesos API. Similar to Docker, can 
we move this to include/mesos/appc/spec.proto?

- Jie Yu


On Jan. 26, 2016, 2:19 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42554/
> ---
> 
> (Updated Jan. 26, 2016, 2:19 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 'dependencies' message to AppcImageManifest.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b 
> 
> Diff: https://reviews.apache.org/r/42554/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 42554: Added 'dependencies' message to AppcImageManifest.

2016-01-28 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42554/
---

(Updated Jan. 29, 2016, 12:56 a.m.)


Review request for mesos and Jie Yu.


Changes
---

review addressed


Repository: mesos


Description
---

Added 'dependencies' message to AppcImageManifest.


Diffs (updated)
-

  include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247 

Diff: https://reviews.apache.org/r/42554/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 42554: Added 'dependencies' message to AppcImageManifest.

2016-01-28 Thread Jojy Varghese 


> On Jan. 28, 2016, 10:12 p.m., Jie Yu wrote:
> > it's strange that this protobuf is exposed in Mesos API. Similar to Docker, 
> > can we move this to include/mesos/appc/spec.proto?

Will be working on a separate patch for moving this message to appc/spec.proto.


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42554/#review116826
---


On Jan. 26, 2016, 2:19 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42554/
> ---
> 
> (Updated Jan. 26, 2016, 2:19 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 'dependencies' message to AppcImageManifest.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b 
> 
> Diff: https://reviews.apache.org/r/42554/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 42554: Added 'dependencies' message to AppcImageManifest.

2016-01-28 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42554/
---

(Updated Jan. 29, 2016, 1:27 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4438
https://issues.apache.org/jira/browse/MESOS-4438


Repository: mesos


Description
---

Added 'dependencies' message to AppcImageManifest.


Diffs
-

  include/mesos/mesos.proto 96b911fb370223933df52f9370897871827d2247 

Diff: https://reviews.apache.org/r/42554/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 42554: Added 'dependencies' message to AppcImageManifest.

2016-01-25 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42554/
---

(Updated Jan. 26, 2016, 2:19 a.m.)


Review request for mesos and Jie Yu.


Changes
---

rebased.


Repository: mesos


Description
---

Added 'dependencies' message to AppcImageManifest.


Diffs (updated)
-

  include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b 

Diff: https://reviews.apache.org/r/42554/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 42554: Added 'dependencies' message to AppcImageManifest.

2016-01-22 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42554/
---

(Updated Jan. 22, 2016, 5:38 p.m.)


Review request for mesos and Jie Yu.


Changes
---

rebased


Repository: mesos


Description (updated)
---

Added 'dependencies' message to AppcImageManifest.


Diffs (updated)
-

  include/mesos/mesos.proto 0be4bed336e86a5c377e87ac6212c70ac3b4c66b 

Diff: https://reviews.apache.org/r/42554/diff/


Testing
---

make check.


Thanks,

Jojy Varghese