Re: Review Request 42591: Added Framework protobufs to registry.

2016-07-09 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42591/#review141536
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Feb. 1, 2016, 7:23 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42591/
> ---
> 
> (Updated Feb. 1, 2016, 7:23 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Klaus Ma, Klaus Ma, 
> Qian Zhang, Jian Qiu, and Vinod Kone.
> 
> 
> Bugs: MESOS-1719
> https://issues.apache.org/jira/browse/MESOS-1719
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add the protobufs in registry to persist some framework informations which do 
> not allow to change when framework re-register.
> 
> 
> Diffs
> -
> 
>   src/master/registry.proto 9958f9c2bdb785390fca2f292b65d5a9310434d5 
> 
> Diff: https://reviews.apache.org/r/42591/diff/
> 
> 
> Testing
> ---
> 
> Make && Make check successfully
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 42591: Added Framework protobufs to registry.

2016-02-02 Thread Yongqiao Wang 


> On Feb. 1, 2016, 8:34 a.m., Jian Qiu wrote:
> > src/master/registry.proto, line 58
> > 
> >
> > Why do we persist these fields instead of the whole frameworkInfo or 
> > frameworkId only?

The current proposal is only to persist the information which can not be 
chagned after framework register. Persist other information is usless, and will 
bring a bad performance due to frequently sync up between the discributed 
registry log.


- Yongqiao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42591/#review117192
---


On Feb. 1, 2016, 7:23 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42591/
> ---
> 
> (Updated Feb. 1, 2016, 7:23 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Guangya Liu, Klaus Ma, Klaus Ma, Qian 
> Zhang, Jian Qiu, and Vinod Kone.
> 
> 
> Bugs: MESOS-1719
> https://issues.apache.org/jira/browse/MESOS-1719
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add the protobufs in registry to persist some framework informations which do 
> not allow to change when framework re-register.
> 
> 
> Diffs
> -
> 
>   src/master/registry.proto 9958f9c2bdb785390fca2f292b65d5a9310434d5 
> 
> Diff: https://reviews.apache.org/r/42591/diff/
> 
> 
> Testing
> ---
> 
> Make && Make check successfully
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 42591: Added Framework protobufs to registry.

2016-02-01 Thread Jian Qiu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42591/#review117192
---




src/master/registry.proto (line 58)


Why do we persist these fields instead of the whole frameworkInfo or 
frameworkId only?


- Jian Qiu


On 二月 1, 2016, 7:23 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42591/
> ---
> 
> (Updated 二月 1, 2016, 7:23 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Guangya Liu, Klaus Ma, Klaus Ma, Qian 
> Zhang, Jian Qiu, and Vinod Kone.
> 
> 
> Bugs: MESOS-1719
> https://issues.apache.org/jira/browse/MESOS-1719
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add the protobufs in registry to persist some framework informations which do 
> not allow to change when framework re-register.
> 
> 
> Diffs
> -
> 
>   src/master/registry.proto 9958f9c2bdb785390fca2f292b65d5a9310434d5 
> 
> Diff: https://reviews.apache.org/r/42591/diff/
> 
> 
> Testing
> ---
> 
> Make && Make check successfully
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 42591: Added Framework protobufs to registry.

2016-01-21 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42591/#review115604
---


Patch looks great!

Reviews applied: [42591]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 21, 2016, 6:44 a.m., Yongqiao Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42591/
> ---
> 
> (Updated Jan. 21, 2016, 6:44 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-1719
> https://issues.apache.org/jira/browse/MESOS-1719
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Add the protobufs in registry to persist some framework informations which do 
> not allow to change when framework re-register.
> 
> 
> Diffs
> -
> 
>   src/master/registry.proto 9958f9c2bdb785390fca2f292b65d5a9310434d5 
> 
> Diff: https://reviews.apache.org/r/42591/diff/
> 
> 
> Testing
> ---
> 
> Make && Make check successfully
> 
> 
> Thanks,
> 
> Yongqiao Wang
> 
>

Re: Review Request 42591: Added Framework protobufs to registry.

2016-01-20 Thread Yongqiao Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42591/
---

(Updated Jan. 21, 2016, 6:44 a.m.)


Review request for mesos, Ben Mahler and Vinod Kone.


Bugs: MESOS-1719
https://issues.apache.org/jira/browse/MESOS-1719


Repository: mesos


Description (updated)
---

Add the protobufs in registry to persist some framework informations which do 
not allow to change when framework re-register.


Diffs
-

  src/master/registry.proto 9958f9c2bdb785390fca2f292b65d5a9310434d5 

Diff: https://reviews.apache.org/r/42591/diff/


Testing
---

Make && Make check successfully


Thanks,

Yongqiao Wang

Review Request 42591: Added Framework protobufs to registry.

2016-01-20 Thread Yongqiao Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42591/
---

Review request for mesos, Ben Mahler and Vinod Kone.


Bugs: MESOS-1719
https://issues.apache.org/jira/browse/MESOS-1719


Repository: mesos


Description
---

Define the protobufs in registry to persist some framework infoamation which do 
not allowed to changed when framework re-register.


Diffs
-

  src/master/registry.proto 9958f9c2bdb785390fca2f292b65d5a9310434d5 

Diff: https://reviews.apache.org/r/42591/diff/


Testing
---

Make && Make check successfully


Thanks,

Yongqiao Wang